external/DAWN
1
0
Fork 0
mirror of https://github.com/berlin-open-wireless-lab/DAWN.git synced 2025-02-12 08:41:51 +00:00
Code Issues Releases Wiki Activity

ubus: add missing lock for ubus hearing_map

Browse source 
In the build_hearing_map_sort_client there was a dawn_mutex_require
without having locked the mutex resulting in warnings:

  daemon.warn dawn: MUTEX require = 4226B8@ubus.c:2003[2012069248l] - appears to be UNLOCKED!
  daemon.warn dawn: MUTEX require = 4226B8@datastorage.c:694[2012069248l] - appears to be UNLOCKED!

I guess it was a typo, because before entering the
client_array_get_client function the mutex client_array_mutex needs to
be locked and not required.

Signed-off-by: Nick Hainke <vincent@systemli.org>
This commit is contained in:
Nick Hainke 2022-07-16 19:11:48 +02:00
parent 4b7db09166
commit 181549f7bb
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/utils/ubus.c
View file

@ -2000,8 +2000,9 @@ int build_hearing_map_sort_client(struct blob_buf *b) {
}
// Find the client if it is actually connected somewhere...
dawn_mutex_require(&client_array_mutex);
dawn_mutex_lock(&client_array_mutex);
client* this_client = client_array_get_client(this_entry->k->client_addr);
dawn_mutex_unlock(&client_array_mutex);
// Add the probe details
char ap_mac_buf[20];