external/DAWN
1
0
Fork 0
mirror of https://github.com/berlin-open-wireless-lab/DAWN.git synced 2025-03-09 15:40:12 +00:00
Code Issues Releases Wiki Activity

data storage: match SSID when searching ap entry

Browse source 
Currenty, ap_array_get_ap returns an entry by matching just the bssid,
without checking if the SSID matches.

ap_array_find_first_entry does a binary search through the ap set
without cheking the SSID, which is bad, as the list is sorted by SSID
then by bssid_mac.

As a side effect, if you have more than one ssid, the network ap list
grows unbounded over time.

Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
This commit is contained in:
Eneas U de Queiroz 2021-07-05 16:27:19 -03:00 • committed by Polynomdivision
parent a22f5a79d6
commit 3db9607b14
4 changed files with 35 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/test/test_storage.c
View file

@ -170,7 +170,7 @@ static int array_auto_helper(int action, int i0, int i1)
time_moves_on();
}
else
ap_array_delete(ap_array_get_ap(this_mac));
ap_array_delete(ap_array_get_ap(this_mac, NULL));
break;
case HELPER_CLIENT:
; // Empty statement to allow label before declaration
@ -938,7 +938,7 @@ static int consume_actions(int argc, char* argv[], int harness_verbosity)
hwaddr_aton(argv[1], kick_mac.u8);
load_u32(&kick_id, argv[2]);
while ((kick_clients(ap_array_get_ap(kick_mac), kick_id) != 0) && safety_count--);
while ((kick_clients(ap_array_get_ap(kick_mac, NULL), kick_id) != 0) && safety_count--);
}
}
else if (strcmp(*argv, "better_ap_available") == 0)
@ -971,11 +971,11 @@ static int consume_actions(int argc, char* argv[], int harness_verbosity)
strcpy(nb, argv[4]);
}
tr = better_ap_available(ap_array_get_ap(bssid_mac), client_mac, nb);
tr = better_ap_available(ap_array_get_ap(bssid_mac, NULL), client_mac, nb);
}
else
{
tr = better_ap_available(ap_array_get_ap(bssid_mac), client_mac, NULL);
tr = better_ap_available(ap_array_get_ap(bssid_mac, NULL), client_mac, NULL);
}
printf("better_ap_available returned %d (with neighbour report %s)\n", tr, nb);
@ -1000,7 +1000,7 @@ static int consume_actions(int argc, char* argv[], int harness_verbosity)
}
else
{
ap* ap_entry = ap_array_get_ap(pr0->bssid_addr);
ap* ap_entry = ap_array_get_ap(pr0->bssid_addr, NULL);
int this_metric = eval_probe_metric(pr0, ap_entry);
printf("eval_probe_metric: Returned %d\n", this_metric);