external/DAWN
1
0
Fork 0
mirror of https://github.com/berlin-open-wireless-lab/DAWN.git synced 2025-03-09 15:40:12 +00:00
Code Issues Releases Wiki Activity

treewide: fix bugs from Coverity Scan

Browse source 
- Fix a couple of bugs in hardly ever (never?) used code paths that Coverity spotted
- Add comments for things that look a bit odd, but not sure if they are bugs

[cleanup commit message]
Signed-off-by: Nick Hainke <vincent@systemli.org>
This commit is contained in:
Ian Clowes 2022-01-31 11:28:21 +00:00 • committed by Nick Hainke
parent 4a88222722
commit 5b1eddc6f4
6 changed files with 18 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/include/datastorage.h
View file

@ -116,17 +116,18 @@ struct local_config_s {
int loglevel;
};
// FIXME: Are these with or without NUL terminator? Adjust values, string allocation and strncpy() to agree.
#define MAX_IP_LENGTH 46
#define MAX_KEY_LENGTH 65
struct network_config_s {
char broadcast_ip[MAX_IP_LENGTH];
char broadcast_ip[MAX_IP_LENGTH + 1];
int broadcast_port;
char server_ip[MAX_IP_LENGTH];
char server_ip[MAX_IP_LENGTH + 1];
int tcp_port;
int network_option;
char shared_key[MAX_KEY_LENGTH];
char iv[MAX_KEY_LENGTH];
char shared_key[MAX_KEY_LENGTH + 1];
char iv[MAX_KEY_LENGTH + 1];
int use_symm_enc;
int collision_domain;
int bandwidth;
@ -160,7 +161,7 @@ typedef struct probe_entry_s {
uint8_t ht_capabilities; // eval_probe_metric()
uint8_t vht_capabilities; // eval_probe_metric()
time_t time; // remove_old...entries
int counter;
int counter; // FIXME: Never gets reset to zero. Rely on deletion to create new for non-802.11k client?
int deny_counter; // TODO: Never used?
uint8_t max_supp_datarate; // TODO: Never used?
uint8_t min_supp_datarate; // TODO: Never used?

2
src/include/utils.h
View file

@ -116,4 +116,4 @@ int _dawn_mutex_lock(pthread_mutex_t* m, char* f, int l);
#define dawn_mutex_unlock(m) _dawn_mutex_unlock(m, __FILE__, __LINE__)
int _dawn_mutex_unlock(pthread_mutex_t* m, char* f, int l);
#endif
#endif
#endif