external/DAWN
1
0
Fork 0
mirror of https://github.com/berlin-open-wireless-lab/DAWN.git synced 2025-03-09 15:40:12 +00:00
Code Issues Releases Wiki Activity

treewide: improve mutex handling

Browse source 
- Add dawn_mutex_require() to indicate when code is accessing resources
- Use pthread_mutex_trylock() to actively test required mutex are locked

[cleanup commit message]
Signed-off-by: Nick Hainke <vincent@systemli.org>
This commit is contained in:
Ian Clowes 2022-01-31 11:38:50 +00:00 • committed by Nick Hainke
parent 32d6d6d57d
commit 60ea5b4daf
6 changed files with 200 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/include/utils.h
View file

@ -104,16 +104,27 @@ const char* dawnlog_basename(const char* file);
/**
** Wrap mutex operations to help track down mis-matches
*/
#if DAWNLOG_COMPILING(DAWNLOG_DEBUG)
#define DAWN_MUTEX_WRAP
#endif
#ifndef DAWN_MUTEX_WRAP
#define dawn_mutex_lock(m) pthread_mutex_lock(m)
#define dawn_mutex_unlock(m) pthread_mutex_unlock(m)
#else
#ifdef DAWN_MUTEX_WRAP
// Log that a mutex managed resource is being accessed so that messages can be scrutinised for bugs
// Place these liberally near any code that accesses or retains a pointer to resources that could go away
#define dawn_mutex_require(m) _dawn_mutex_require(m, __FILE__, __LINE__)
void _dawn_mutex_require(pthread_mutex_t* m, char* f, int l);
// Log that a mutex managed resource is being locked so that messages can be scrutinised for bugs
#define dawn_mutex_lock(m) _dawn_mutex_lock(m, __FILE__, __LINE__)
int _dawn_mutex_lock(pthread_mutex_t* m, char* f, int l);
// Log that a mutex managed resource is being unlocked so that messages can be scrutinised for bugs
#define dawn_mutex_unlock(m) _dawn_mutex_unlock(m, __FILE__, __LINE__)
int _dawn_mutex_unlock(pthread_mutex_t* m, char* f, int l);
#else
#define dawn_mutex_require(m)
#define dawn_mutex_lock(m) pthread_mutex_lock(m)
#define dawn_mutex_unlock(m) pthread_mutex_unlock(m)
#endif
#endif
#endif