external/VirtScreen
1
0
Fork 0
mirror of https://github.com/kbumsik/VirtScreen.git synced 2025-03-09 15:40:18 +00:00
Code Issues Releases Wiki Activity

Backend: Marked TODO for error handling state

Browse source
This commit is contained in:
Bumsik Kim 2018-05-16 10:52:13 -04:00
parent bc0de4f368
commit 5ef4e1bcbd
No known key found for this signature in database
GPG key ID: E31041C8EC5B01C6
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
virtscreen.py
View file

@ -48,7 +48,7 @@ class SubprocessWrapper:
def run(self, arg: str, input: str = None) -> str: def run(self, arg: str, input: str = None) -> str:
if input: if input:
input = input.encode('utf-8') input = input.encode('utf-8')
return subprocess.run(arg.split(), input=input, stdout=subprocess.PIPE, return subprocess.run(arg.split(), input=input, stdout=subprocess.PIPE,
stderr=subprocess.STDOUT).stdout.decode('utf-8') stderr=subprocess.STDOUT).stdout.decode('utf-8')
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
@ -463,7 +463,7 @@ class Backend(QObject):
def createVirtScreen(self, width, height, portrait, hidpi): def createVirtScreen(self, width, height, portrait, hidpi):
print("Creating a Virtual Screen...") print("Creating a Virtual Screen...")
try: try:
self.xrandr.create_virtual_screen(width, height, portrait, hidpi) self.xrandr.create_virtual_screen(width, height, portrait, hidpi)
except subprocess.CalledProcessError as e: except subprocess.CalledProcessError as e:
self.onError.emit(str(e.cmd) + '\n' + e.stdout.decode('utf-8')) self.onError.emit(str(e.cmd) + '\n' + e.stdout.decode('utf-8'))
return return
@ -528,9 +528,11 @@ class Backend(QObject):
def _onEnded(exitCode): def _onEnded(exitCode):
if exitCode is not 0: if exitCode is not 0:
self.vncState = self.VNCState.ERROR self.vncState = self.VNCState.ERROR
self.onError.emit('X11VNC: Error occurred.') self.onError.emit('X11VNC: Error occurred.\nDouble check if the port is already used.')
self.vncState = self.VNCState.OFF # TODO: better handling error state
else:
self.vncState = self.VNCState.OFF
print("VNC Exited.") print("VNC Exited.")
self.vncState = self.VNCState.OFF
atexit.unregister(self.stopVNC) atexit.unregister(self.stopVNC)
logfile = open(X11VNC_LOG_PATH, "wb") logfile = open(X11VNC_LOG_PATH, "wb")
self.vncServer = ProcessProtocol(_onConnected, _onReceived, _onReceived, _onEnded, logfile) self.vncServer = ProcessProtocol(_onConnected, _onReceived, _onReceived, _onEnded, logfile)