external/cde
1
0
Fork 0
mirror of git://git.code.sf.net/p/cdesktopenv/code synced 2025-02-13 19:52:20 +00:00
Code Issues Releases Wiki Activity

ksh segfaults in job_chksave after receiving SIGCHLD

Browse source 
Upstreaming Debian patch:

Prior to this update, the compiler optimization dropped parts from the ksh job
locking mechanism from the binary code. As a consequence, ksh could terminate
unexpectedly with a segmentation fault after it received the SIGCHLD signal.
This update implements a fix to ensure the compiler does not drop parts of the
ksh mechanism and the crash no longer occurs.

Author: Michal Hlavinka mhlavink@redhat.com
Origin: Red Hat fix, ksh-20120801-locking.patch
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1123467
Bug-Ubuntu: https://bugs.launchpad.net/bugs/1697501
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=867181
This commit is contained in:
Anuradha Weeraman 2020-06-14 14:19:13 -04:00
parent 5498d9ec25
commit 07cc71b880
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/cmd/ksh93/include/jobs.h
View file

@ -149,15 +149,18 @@ extern struct jobs job;
#define vmbusy() 0 #define vmbusy() 0
#endif #endif
#define job_lock() (job.in_critical++) #define asoincint(p) __sync_fetch_and_add(p,1)
#define asodecint(p) __sync_fetch_and_sub(p,1)
#define job_lock() asoincint(&job.in_critical)
#define job_unlock() \ #define job_unlock() \
do { \ do { \
int sig; \ int sig; \
if (!--job.in_critical && (sig = job.savesig)) \ if (asodecint(&job.in_critical)==1 && (sig = job.savesig)) \
{ \ { \
if (!job.in_critical++ && !vmbusy()) \ if (!asoincint(&job.in_critical) && !vmbusy()) \
job_reap(sig); \ job_reap(sig); \
job.in_critical--; \ asodecint(&job.in_critical); \
} \ } \
} while(0) } while(0)