From 16c3ed36502c8e91b121b60d47798d2a33e1ca0e Mon Sep 17 00:00:00 2001 From: Peter Howkins Date: Thu, 23 Dec 2021 19:50:38 +0000 Subject: [PATCH] dtprintinfo: Resolve format-overflow issues --- cde/programs/dtprintinfo/UI/DtApp.C | 4 ++-- cde/programs/dtprintinfo/UI/DtFindD.C | 2 +- cde/programs/dtprintinfo/UI/DtPrinterIcon.C | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cde/programs/dtprintinfo/UI/DtApp.C b/cde/programs/dtprintinfo/UI/DtApp.C index a01c2a239..dbb83fc5e 100644 --- a/cde/programs/dtprintinfo/UI/DtApp.C +++ b/cde/programs/dtprintinfo/UI/DtApp.C @@ -718,7 +718,7 @@ void DtApp::OpenClose(BaseUI *obj) n_icons = rc->NumChildren(); for (i = 0; i < n_jobs; i++) { - char number[5]; + char number[11]; sprintf(number, "%d", i + 1); icons[i]->TopString(number); } @@ -907,7 +907,7 @@ void DtApp::ActionCB(BaseUI *obj, char *actionReferenceName) IconObj **children = (IconObj **)parent->Children(); for (i = 0; i < parent->NumChildren(); i++) { - char number[5]; + char number[11]; sprintf(number, "%d", i + 1); children[i]->TopString(number); } diff --git a/cde/programs/dtprintinfo/UI/DtFindD.C b/cde/programs/dtprintinfo/UI/DtFindD.C index 658455317..441332203 100644 --- a/cde/programs/dtprintinfo/UI/DtFindD.C +++ b/cde/programs/dtprintinfo/UI/DtFindD.C @@ -389,7 +389,7 @@ void DtFindD::Stop() for (i = 0; i < n_matches; i++) { DtPrtJobIcon *job = (DtPrtJobIcon *)matches[i]; - char number[9]; + char number[12]; sprintf(number, "%d", job->Order() + 1); fields->fields[0] = (char *)job->Parent()->Parent()->Name(); if (n_fields == 3) diff --git a/cde/programs/dtprintinfo/UI/DtPrinterIcon.C b/cde/programs/dtprintinfo/UI/DtPrinterIcon.C index 69a65960b..305c50c7b 100644 --- a/cde/programs/dtprintinfo/UI/DtPrinterIcon.C +++ b/cde/programs/dtprintinfo/UI/DtPrinterIcon.C @@ -67,7 +67,7 @@ DtPrinterIcon::DtPrinterIcon(DtMainW *mainW, AnyUI *parent, Queue *que, if (app_mode == INITIALIZE_PRINTERS) return; - char *buf = new char[300]; + char *buf = new char[sizeof(DtPrinterIcon::homeDir) + 32]; struct stat statbuff; if (*homeDir == '\0') {