From 22d6b4527d81f592179af61e8f781702893b3789 Mon Sep 17 00:00:00 2001 From: Johnothan King Date: Mon, 8 Jun 2020 20:06:51 -0700 Subject: [PATCH] Avoid brute-forcing during the build process to prevent failed builds The default behavior of the package script is to ignore errors. This has disastrous effects if any part of ksh or libast fails to build due to something like a syntax error, as the build will stop long after the first error occurred. This commit removes the -k flag from the $makeflags variable in both copies of the package script. This forces the build to fail if a compiler error occurs. bin/package and src/cmd/INIT/package.sh: - Remove the -k assignment to $makeflags so that compiler errors cause the build to fail. (cherry picked from commit 87bfaa19f3d336feb7b7bd4f5d4caf8d553f2547) --- bin/package | 2 +- src/cmd/INIT/package.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/package b/bin/package index 5e9b10865..4b1272594 100755 --- a/bin/package +++ b/bin/package @@ -567,7 +567,7 @@ ifs=${IFS-' '} lo= make= -makeflags='-k -K' +makeflags='-K' nmakeflags= nmakesep= nl=" diff --git a/src/cmd/INIT/package.sh b/src/cmd/INIT/package.sh index 1a7ca4ac3..99f56e322 100644 --- a/src/cmd/INIT/package.sh +++ b/src/cmd/INIT/package.sh @@ -566,7 +566,7 @@ ifs=${IFS-' '} lo= make= -makeflags='-k -K' +makeflags='-K' nmakeflags= nmakesep= nl="