mirror of
git://git.code.sf.net/p/cdesktopenv/code
synced 2025-03-09 15:50:02 +00:00
build: include standards macros for all AST code (re: 7fb814e1
)
Turns out that the standards macros set by features/standards (such as _GNU_SOURCE for Linux or _DARWIN_SOURCE for macOS) were still *not* included for most C source files! Instead, they were selectively included for some files only, sometimes via FEATURE/standards (the output of features/standards), sometimes via ast_standards.h which is copied from FEATURE/standards. Consequently, there were still inconsistencies in the system header interfaces exposed on Linux, macOS, Solaris, et al. It's no wonder it sometimes took so much hackery to keep everything building. Of course, making this consistent had to break things somewhere. Breakage occurred on 32-bit Linux due to a lot of ugly hackery involving direct use of internal GNU types like off64_t and functions like fseek64(). This is now all removed and they are activated by setting the appropriate feature macro instead, so these types and functions can be used with their standard names (off_t, fseek, etc.) Before committing I've tested these changes on the following i386/x86_64 systems: Linux (glibc 32 and 64 bit, musl libc 64 bit), Solaris (32 and 64 bit), illumos (32 and 64 bit), FreeBSD (64 bit), macOS (64 bit), Cygwin (32 bit), and Haiku (64 bit). (Note: ast_standards.h is copied from FEATURE/standards, whereas ast_common.h is copied from FEATURE/common.) src/lib/libast/include/ast_std.h, src/lib/libast/stdio/stdhdr.h: - Include <ast_standards.h> first. This should cause all the AST and dependent code (such as ksh) to get the standards macros. src/lib/libast/features/standards: - For GNU (glibc), #define _FILE_OFFSET_BITS 64 to get large file support with 64-bit offsets. - Stop GNU and Cygwin <string.h> form defining the GNU version of basename(3); on Cygwin, that declaration conflicts with the AST version (and with POSIX) by using a const char* argument instead of char*. It is deactivated by defining the macro 'basename' (as 'basename'); this causes GNU string.h to consider it to be already defined by the standard libgen.h header. All other changed files: - Remove direct use of *64* types and functions and a lot of related hackery.
This commit is contained in:
parent
fb8e239cb4
commit
289dd46c05
43 changed files with 78 additions and 872 deletions
|
@ -491,13 +491,8 @@ extern Shell_t sh;
|
|||
# define write(a,b,c) sh_write(a,b,c)
|
||||
# define umask(a) sh_umask(a)
|
||||
# define dup sh_dup
|
||||
# if _lib_lseek64
|
||||
# define open64 sh_open
|
||||
# define lseek64 sh_seek
|
||||
# else
|
||||
# define open sh_open
|
||||
# define lseek sh_seek
|
||||
# endif
|
||||
# define open sh_open
|
||||
# define lseek sh_seek
|
||||
#endif /* !defs_h_defined */
|
||||
|
||||
#define SH_SIGSET 4
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue