dtinfo: Fix coverity warning related to using delete not delete []

cde/programs/dtinfo/DtMmdb/StyleSheet/BitVector.C

@@ -57,14 +57,14 @@ void BitVector::setAllBitsTo(unsigned int initValue)
 
 BitVector::~BitVector()
 {
-   delete f_array;
+   delete [] f_array;
    delete f_positionArray;
 }
 
 void BitVector::setTo(BitVector& v)
 {
    if ( f_words != v.f_words ) {
-     delete f_array;
+     delete [] f_array;
      f_array = new unsigned int[v.f_words];
    }
    f_bits = v.f_bits;

cde/programs/dtinfo/DtMmdb/StyleSheet/FeatureValue.C

@@ -532,7 +532,7 @@ FeatureValueString::operator+(const FeatureValue& x) const
      newString[len1+len2] = 0;
 
      FeatureValueString *z = new FeatureValueString(newString);
-     delete newString;
+     delete [] newString;
 
      return z;
    }

cde/programs/dtinfo/DtMmdb/api/info_lib.C

@@ -215,8 +215,8 @@ f_bad_info_base_names(0), f_bad_info_base_paths(0), f_descriptor(des)
                     memcpy(y, f_bad_info_base_paths, sizeof(charPtr)*f_bad_base_array_size);
                     f_bad_base_array_size *= 2;
 
-                    delete f_bad_info_base_names;
+                    delete [] f_bad_info_base_names;
-                    delete f_bad_info_base_paths;
+                    delete [] f_bad_info_base_paths;
 
                     f_bad_info_base_names = x;
                     f_bad_info_base_paths = y;

cde/programs/dtinfo/DtMmdb/dti_cc/CC_String.h

@@ -44,7 +44,7 @@ public: // functions
     f_string = NULL;
   }
 
-  virtual ~CC_String () { delete f_string; }
+  virtual ~CC_String () { delete [] f_string; }
 
   CC_Boolean isNull() const { 
     return( f_string[0] == '\0' );

cde/programs/dtinfo/DtMmdb/dti_cc/CC_Tokenizer.h

@@ -40,7 +40,7 @@ private:
 
 public:
   CC_Tokenizer(const CC_String & );
-  ~CC_Tokenizer() { delete str_; }
+  ~CC_Tokenizer() { delete [] str_; }
 
 
   /* Here is an example to use the code 

cde/programs/dtinfo/DtMmdb/dynhash/imp_die.C

@@ -100,8 +100,8 @@ imp_die::~imp_die()
       x = y ;
    }
 
-   delete hash_table;
+   delete [] hash_table;
-   delete bucket_array ;
+   delete [] bucket_array ;
 }
 
 //**********************************************************
@@ -113,14 +113,14 @@ void imp_die::alloc_table(int new_H)
 {
    if ( bucket_array ) {
       for ( int i = 0; i<B; delete bucket_array[i++] );
-      delete bucket_array ;
+      delete [] bucket_array ;
    }
 
    B = new_H/2;
    bucket_array = new imp_bucketPtr[B];
 
    if ( hash_table ) {
-      delete hash_table;
+      delete [] hash_table;
    }
 
    hash_table = new data_tPtr[new_H];

cde/programs/dtinfo/DtMmdb/hmphf/buckets.C

@@ -171,7 +171,7 @@ buckets::~buckets()
    for ( int i=0; i<v_no_buckets; i++ ) 
       delete v_bucket_array[i];
    
-   delete v_bucket_array;
+   delete [] v_bucket_array;
 }
 
 void buckets::set_control_bit(int cb)
@@ -284,10 +284,10 @@ void buckets::sort_by_size()
 
    for ( ; j<v_no_buckets; new_bkt_array[j++] = 0 );
 
-   delete sizes;
+   delete [] sizes;
-   delete links;
+   delete [] links;
 
-   delete v_bucket_array;
+   delete [] v_bucket_array;
    v_bucket_array = new_bkt_array;
 }
 

cde/programs/dtinfo/DtMmdb/hmphf/mphf_funcs.C

@@ -254,7 +254,7 @@ int write_spec(buckets& bs, params& pms, buffer& mphf_buffer)
    mphf_buffer.set_content_sz(fout_len);
    memcpy(mphf_buffer.get_base(), fout.str().c_str(), fout_len);
 
-   delete c_array;
+   delete [] c_array;
 
    return 0;
 }
@@ -350,7 +350,7 @@ debug(cerr, k+1);
 cerr << "=======\n";
 */
 
-   delete y;
+   delete [] y;
    return 0;
 }
 

cde/programs/dtinfo/DtMmdb/hmphf/mphf_hash_table.C

@@ -64,9 +64,9 @@ v_no_slots(params_ptr.v_n), v_num_filled_slots(0)
 
 mphf_hash_table::~mphf_hash_table()
 {
-   delete v_rep ;
+   delete [] v_rep ;
-   delete v_random_table ;
+   delete [] v_random_table ;
-   delete v_map_table ;
+   delete [] v_map_table ;
 }
 
 void mphf_hash_table::clear()

cde/programs/dtinfo/DtMmdb/hmphf/pattern.C

@@ -58,7 +58,7 @@ int_pattern::int_pattern(int i): v_rep_size(i), v_count(0)
 
 int_pattern::~int_pattern()
 {
-   delete v_rep;
+   delete [] v_rep;
 }
 
 int int_pattern::duplicate()

cde/programs/dtinfo/DtMmdb/hmphf/sorter.C

@@ -111,7 +111,7 @@ sorter::~sorter()
    delete v_bucket_array;
 
    for ( i=0; i<v_no_unique_keys; delete v_unique_keys[i++] );
-   delete v_unique_keys;
+   delete [] v_unique_keys;
 }
 
 void sorter::filter_by_hash()
@@ -137,10 +137,10 @@ void sorter::filter_by_hash()
          filter_a_bucket(v_bucket_array[i]);
    }
 
-   delete v_map_table;
+   delete [] v_map_table;
-   delete v_check_table;
+   delete [] v_check_table;
-   delete v_index_table;
+   delete [] v_index_table;
-   delete v_dup_table;
+   delete [] v_dup_table;
 }
 
 void sorter::filter_a_bucket(bucketPtr bkt)

cde/programs/dtinfo/DtMmdb/object/oid_list.C

@@ -138,7 +138,7 @@ void oid_list::init_data_member(int leng)
 //debug(cerr, (void*)this);
 //debug(cerr, (void*)list_ptr.p);
 
-   delete ptr;
+   delete [] ptr;
    v_sz = leng;
    set_mode(UPDATE, true);
 }
@@ -188,7 +188,7 @@ debug(cerr, int(&list_ptr.loc));
          storage_ptr -> appendString(list_ptr.loc, ptr, total_char_leng);
       }
 
-      delete ptr;
+      delete [] ptr;
 
       ok = true;
 

cde/programs/dtinfo/DtMmdb/oliasdb/c_api_bookcase.C

@@ -139,7 +139,7 @@ DtMmdbGetBookCaseByLocs(int infolib_descriptor, const char** locators,
       for ( int i=0; i<count; i++ )
          ds[i] = bases[i] -> index_id();
 
-      delete bases;
+      delete [] bases;
 
       if (count_ptr) *count_ptr = count;
 

cde/programs/dtinfo/DtMmdb/oliasdb/mmdb.C

@@ -72,8 +72,8 @@ OLIAS_DB::~OLIAS_DB()
       delete x;
    }
 
-   delete info_base_set_names;
+   delete [] info_base_set_names;
-   delete info_base_list_names;
+   delete [] info_base_list_names;
 }
 
 int OLIAS_DB::validInfoLibPath(const char* path)

cde/programs/dtinfo/DtMmdb/oliasdb/user_base.C

@@ -192,7 +192,7 @@ user_base::checking_status_t user_base::check_lock()
            ) {
             if ( ai_info ) {
               debug(cerr, ai_info); 
-              delete ai_info;
+              delete [] ai_info;
             }
             return user_base::RLOCK_FAIL;
         } else
@@ -220,7 +220,7 @@ user_base::checking_status_t user_base::check_lock()
 //                   return ok;
 //                }
 
-                delete ai_info;
+                delete [] ai_info;
              }
              return user_base::WLOCK_FAIL;
          } else {

cde/programs/dtinfo/DtMmdb/schema/container_desc.C

@@ -215,7 +215,7 @@ container_desc::init_index_array(object_dict& dict,
       index_array[pos] = tmp_index_array[ind];
    }
 
-   delete tmp_index_array;
+   delete [] tmp_index_array;
 }
 
 //////////////////////////////////////////////////////////////////////

cde/programs/dtinfo/DtMmdb/schema/object_dict.C

@@ -156,7 +156,7 @@ desc* object_dict::init_a_base(char* db_path, char* db_name)
    ////////////////
       x = parse(orig);
 
-      delete buf;
+      delete [] buf;
 
    }
 
@@ -268,7 +268,7 @@ desc* object_dict::init_a_base(char* define_desc_path, char* db_path,
 
    out.close();
 
-   delete schema_buf;
+   delete [] schema_buf;
 
 
    return x;

cde/programs/dtinfo/DtMmdb/schema/stored_object_desc.C

@@ -64,12 +64,12 @@ stored_object_desc::stored_object_desc(int class_code, const char* _type)
 
 stored_object_desc::~stored_object_desc() 
 { 
-   delete store_nm; 
+   free(store_nm); 
 }
 
 void stored_object_desc::set_store_nm(const char* str) 
 { 
-     delete store_nm;
+     free(store_nm);
      store_nm = strdup(str); 
 }
 

cde/programs/dtinfo/DtMmdb/storage/chunks_index.C

@@ -118,7 +118,7 @@ debug(cerr, vector[i] -> str_offset);
 
 
    binary_insert(vector, 0, vector_sz-1);
-   delete vector;
+   delete [] vector;
 }
 
 chunks_index::~chunks_index() 

cde/programs/dtinfo/DtMmdb/storage/store_test.C

@@ -93,7 +93,7 @@ void quit_store(page_storage** st, unsigned int ct)
    for ( unsigned int i=0; i<ct; i++) {
      delete st[i];
    }
-   delete st;
+   delete [] st;
 }
 
 int page_cache_test_1(int argc, char** argv)

cde/programs/dtinfo/DtMmdb/utility/ostring.C

@@ -134,7 +134,7 @@ Boolean ostring::expand(const int new_alloc_sz, Boolean pre_zero)
   
       if ( v_p ) {
          memcpy(new_p, v_p, v_sz);
-         delete v_p;
+         delete [] v_p;
       }
 
       v_p = new_p;

cde/programs/dtinfo/DtMmdb/utility/ostring.h

@@ -54,7 +54,7 @@ public:
    ostring(const int chunk_size);
    ostring(char* str, const int str_sz = -1); // -1 means take strlen(str)
    ostring(const ostring&);
-   virtual ~ostring() { delete v_p; };
+   virtual ~ostring() { delete [] v_p; };
 
 // length of the string
    int size() const { return v_sz; };                

cde/programs/dtinfo/DtMmdb/utility/randomize.C

@@ -53,5 +53,5 @@ void randomize::restore(buffer& scrambled)
       char_swap(buf[i], buf[pos[i]]);
    }
 
-   delete pos;
+   delete [] pos;
 }

cde/programs/dtinfo/DtMmdb/utility/rw_lock.C

@@ -234,7 +234,7 @@ Boolean write_lock(char* lock_file_path,
 
       if ( ok == true ) {
    
-         delete ai_info;
+         delete [] ai_info;
 /////////////////////////////////////////
 // create the access info file
 /////////////////////////////////////////

cde/programs/dtinfo/dtinfo/src/Agents/NodeHistoryAgentMotif.C

@@ -240,7 +240,7 @@ NodeHistoryAgent::refresh_list()
   // Free up memory used to make the list.
   for (i = hist_list.length() - 1; i >= 0; i--)
     XmStringFree (table[i]);
-  delete table;
+  delete [] table;
 }
 
 

cde/programs/dtinfo/dtinfo/src/Agents/NodeWindowAgentMotif.C

@@ -4668,7 +4668,7 @@ NodeWindowAgent::create_canvas_mark(_DtCvHandle  canvas,
   for (i = 0; i < markinfo.length(); i++)
     delete segs[i];
 
-  delete segs ;
+  delete [] segs ;
       
 #ifdef BOOKMARK_DEBUG
   if (status == _DtCvSTATUS_BAD)

cde/programs/dtinfo/dtinfo/src/Agents/OutlineListViewMotif.C

@@ -712,8 +712,8 @@ OutlineListView::select_end (Widget w, XEvent *event,
 	  while (subcount > 0)
 	    if (selected_list[--subcount])
 	      SelectPos (f_item_pos + subcount + 1, False);
-	  delete table;
+	  delete [] table;
-	  delete selected_list;
+	  delete [] selected_list;
 	  
 	  // Turn the wait cursor off if it was on. 
 	  if (wait_state)
@@ -787,7 +787,7 @@ OutlineListView::update_list(OutlineList *list, BitHandle handle)
   Set (args);
 
   delete table;
-  delete selected_list;
+  delete [] selected_list;
 }
 
 // /////////////////////////////////////////////////////////////////
@@ -1152,7 +1152,7 @@ OutlineListView::activate (WCallback *wcb)
                           oe->level() + 1);
           AddItemsUnselected (table, subcount, lcs->item_position + 1);
           delete table;
-          delete sel_list;
+          delete [] sel_list;
 
           // Turn the wait cursor off if it was on.
           if (wait_state)

cde/programs/dtinfo/dtinfo/src/Basic/BitField.C

@@ -103,7 +103,7 @@ BitField::BitField(unsigned long initial_bits)
 
 BitField::~BitField()
 {
-  delete f_words ;
+  delete [] f_words ;
   delete f_bits_in_use ;
 }
 
@@ -123,7 +123,7 @@ BitField::check_allocation (unsigned long word)
 	  new_use[i] = f_bits_in_use[i];
 	}
 
-      delete f_words;
+      delete [] f_words;
       f_words = new_words;
       delete f_bits_in_use;
       f_bits_in_use = new_use;
@@ -169,7 +169,7 @@ BitField::get_handle()
     new_words[f_num_words] = 0 ;
     new_use[f_num_words] = 0 ;
 
-    delete f_words ;
+    delete [] f_words ;
     f_words = new_words ;
     delete f_bits_in_use ;
     f_bits_in_use = new_use ;

cde/programs/dtinfo/dtinfo/src/UAS/DtSR/TextParser.C

@@ -233,7 +233,7 @@ StringParser::brute_force(const char* text_in, int n_of_pats,
 
     for (i = 0; i < npat; i++)
 	free (pat_tbl[i]);
-    free (pat_tbl);
+    delete[] pat_tbl;
 
     if (caped_text)
 	delete[] caped_text;

cde/programs/dtinfo/dtinfogen/infolib/etc/BookTasks.C

@@ -550,7 +550,7 @@ void BookTask::write_record(void)
     snprintf(p, plen, "%s\t%s\t%s\t%s", name, loc, line, file);
     tablines.append(p);
 
-    delete p;
+    delete [] p;
   }
 
   const char *bk_title;
@@ -600,7 +600,7 @@ void BookTask::reset()
   delete tabLines; tabLines = new StringList();
   delete tabFiles; tabFiles = new StringList();
 
-  delete tocLocator; tocLocator = NULL;
+  delete [] tocLocator; tocLocator = NULL;
 
  
   f_seq_no ++;

cde/programs/dtinfo/dtinfogen/infolib/etc/DataBase.C

@@ -154,7 +154,7 @@ DBTable::file(DB::Access access)
 	throw(PosixError(errno, path));
       }
 
-      delete path;
+      delete [] path;
     }
   }
 
@@ -458,7 +458,7 @@ void DBCursor::string_field(FILE *fp, char **out, int *lenOut)
 
     if(lenOut) *lenOut = len;
   }else{
-    delete str;
+    delete [] str;
   }
 }
 

cde/programs/dtinfo/dtinfogen/infolib/etc/Dispatch.C

@@ -192,7 +192,7 @@ Dispatch::file(const char *f)
     }
     
     search_path_table->replace_file_scope( dirname );
-    delete dirname;
+    free(dirname);
   }
 }
 

cde/programs/dtinfo/dtinfogen/infolib/etc/MixedGen.C

@@ -117,7 +117,7 @@ checkTocLink( const char *toc_file_name,
     }
   }
   
-  delete ToCFileName;
+  free(ToCFileName);
 
   if ( flag ) {
     throw(Unexpected("TOC validation failed\n"));
@@ -618,7 +618,7 @@ lookahead( char * bufptr, char * currentgi, char * indpos)
     }
     // otherwise the next start tag is the same as the current one, so no
     // change to the indicator is needed.
-    delete nextgi;
+    free(nextgi);
   }
   return;
 }
@@ -654,7 +654,7 @@ parse4last( char * bufptr )
 	} else {
 	  lookahead(bufptr, startname, indicator);
 	}
-	delete startname;
+	free(startname);
       } else {
 	// END TAG
 	for ( ; *bufptr != '>'; bufptr++) {

cde/programs/dtinfo/dtinfogen/infolib/etc/SGMLDefn.C

@@ -49,16 +49,16 @@ SGMLDefn::SGMLDefn()
 
 SGMLDefn::~SGMLDefn()
 {
-  delete sys_id;
+  delete [] sys_id;
-  delete pub_id;
+  delete [] pub_id;
-  delete file_name;
+  delete [] file_name;
 }
 
 void
 SGMLDefn::store_sys_id( char *sid )
 {
   if ( sid ) {
-    delete sys_id;
+    delete [] sys_id;
 
     int len = strlen(sid);
     sys_id = new char [len + 1];
@@ -72,7 +72,7 @@ void
 SGMLDefn::store_pub_id( char *pid )
 {
   if ( pid ) {
-    delete pub_id;
+    delete [] pub_id;
 
     int len = strlen(pid);
     pub_id = new char [len + 1];
@@ -98,7 +98,7 @@ void
 SGMLDefn::store_file_name( char *fname )
 {
   if ( fname ) {
-    delete file_name;
+    delete [] file_name;
 
     int len = strlen(fname);
     file_name = new char [len + 1];

cde/programs/dtinfo/dtinfogen/infolib/etc/StringList.C

@@ -37,7 +37,7 @@ StringList::StringList()
 StringList::~StringList()
 {
   reset();
-  delete items;
+  delete [] items;
 }
 
 void StringList::grow(size_t total)
@@ -47,7 +47,7 @@ void StringList::grow(size_t total)
     
     if(used > 0){
       memcpy(born, items, used *sizeof(items[0]));
-      delete items;
+      delete [] items;
     }
 
     items = born;

cde/programs/dtinfo/dtinfogen/infolib/etc/StyleTask.C

@@ -146,7 +146,7 @@ write_array(FlexBuffer *buffer, const char *tokens, int quotes)
         if (quotes) buffer->put( '\"' );
       }
     }
-    delete str;
+    free(str);
   } /*@# else out of memory... */
   
   buffer->put(']');

cde/programs/dtinfo/dtinfogen/infolib/etc/TOCTask.C

@@ -178,7 +178,7 @@ int TOCTask::write_tree(DBTable *tbl)
 	      INTEGER_CODE, qty,
 	      NULL);
 
-  delete children;
+  delete [] children;
   return qty;
 }
 

cde/programs/dtinfo/dtinfogen/infolib/etc/Task.C

@@ -48,7 +48,7 @@ ComplexTask::~ComplexTask()
     delete subtasks[i];
   }
 
-  if ( subtasks ) delete subtasks;
+  if ( subtasks ) delete [] subtasks;
 }
 
 void ComplexTask::removeAllSubTasks()
@@ -57,7 +57,7 @@ void ComplexTask::removeAllSubTasks()
     delete subtasks[i];
   }
 
-  if ( subtasks ) { delete subtasks; subtasks = 0; }
+  if ( subtasks ) { delete [] subtasks; subtasks = NULL; }
   used = alloc = 0;
 }
 
@@ -98,7 +98,7 @@ ComplexTask::grow(int needed)
 
     if(used){
       memcpy(born, subtasks, sizeof(Task*) * used);
-      delete subtasks; subtasks = 0;
+      delete [] subtasks; subtasks = NULL;
     }
 
     subtasks = born;