external/cde
1
0
Fork 0
mirror of git://git.code.sf.net/p/cdesktopenv/code synced 2025-03-09 15:50:02 +00:00
Code Issues Releases Wiki Activity

dtappbuilder: Resolve format-overflow issues

Browse source
This commit is contained in:
Peter Howkins 2021-12-23 19:57:22 +00:00 • committed by Jon Trulson
parent 04fcc11f12
commit 33fad36133
7 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
cde/programs/dtappbuilder/src/ab/cgen_utils.c
View file

@ -1204,7 +1204,7 @@ exec_run(void)
{ {
ABObj project= NULL; ABObj project= NULL;
char executable_name[1024]; char executable_name[1024];
char cmd[1024]; char cmd[sizeof(executable_name) + 3];
STRING argv[5]; STRING argv[5];
*executable_name = 0; *executable_name = 0;
*cmd = 0; *cmd = 0;

2
cde/programs/dtappbuilder/src/ab/projP_utils.c
View file

@ -371,7 +371,7 @@ projP_save_export_bil(
} }
else /* An error occurred with stat */ else /* An error occurred with stat */
{ {
sprintf(Buf, "%s: %s", new_filename, strerror(errno)); snprintf(Buf, sizeof(Buf), "%s: %s", new_filename, strerror(errno));
util_printf_err(Buf); util_printf_err(Buf);
} }
XtUnmanageChild(AB_generic_chooser); XtUnmanageChild(AB_generic_chooser);

6
cde/programs/dtappbuilder/src/ab/proj_utils.c
View file

@ -1492,7 +1492,7 @@ proj_save_exploded(
else /* An error occurred with stat */ else /* An error occurred with stat */
{ {
obj_set_name(project, old_name); obj_set_name(project, old_name);
sprintf(Buf, "%s: %s", mod_exp_file, strerror(errno)); snprintf(Buf, sizeof(Buf), "%s: %s", mod_exp_file, strerror(errno));
util_printf_err(Buf); util_printf_err(Buf);
if (old_name != NULL) util_free(old_name); if (old_name != NULL) util_free(old_name);
if (old_file != NULL) util_free(old_file); if (old_file != NULL) util_free(old_file);
@ -1558,7 +1558,7 @@ proj_save_exploded(
if ((iRet = util_mkdir_hier(dir)) < 0) if ((iRet = util_mkdir_hier(dir)) < 0)
{ {
obj_set_name(project, old_name); obj_set_name(project, old_name);
sprintf(Buf, "%s: %s", dir, strerror(errno)); snprintf(Buf, sizeof(Buf), "%s: %s", dir, strerror(errno));
util_printf_err(Buf); util_printf_err(Buf);
if (rel_path) util_free(rel_path); if (rel_path) util_free(rel_path);
if (old_name != NULL) util_free(old_name); if (old_name != NULL) util_free(old_name);
@ -2135,7 +2135,7 @@ save_proj_as_bix(
} }
else /* An error occurred with stat */ else /* An error occurred with stat */
{ {
sprintf(Buf, "%s: %s", bix_file, strerror(errno)); snprintf(Buf, sizeof(Buf), "%s: %s", bix_file, strerror(errno));
xm_buf = XmStringCreateLocalized(Buf); xm_buf = XmStringCreateLocalized(Buf);
dtb_proj_error_msg_initialize(&dtb_proj_error_msg); dtb_proj_error_msg_initialize(&dtb_proj_error_msg);
(void)dtb_show_modal_message(dtb_get_toplevel_widget(), (void)dtb_show_modal_message(dtb_get_toplevel_widget(),

8
cde/programs/dtappbuilder/src/abmf/generate_code.c
View file

@ -563,7 +563,7 @@ write_module_files(
strcpy(uiHeaderDefineName, strcpy(uiHeaderDefineName,
abmfP_get_define_from_file_name(uiHeaderFileName)); abmfP_get_define_from_file_name(uiHeaderFileName));
sprintf(stubsFileName, "%s_stubs.c", obj_get_name(module)); sprintf(stubsFileName, "%s_stubs.c", obj_get_name(module));
sprintf(stubsBakFileName, "%s.BAK", stubsFileName); snprintf(stubsBakFileName, sizeof(stubsBakFileName), "%s.BAK", stubsFileName);
/* /*
* ***** WRITE UI HEADER FILE ***** * ***** WRITE UI HEADER FILE *****
@ -733,7 +733,7 @@ write_module_files(
if ((stubsCFileChanged) && (deltaFile != NULL)) if ((stubsCFileChanged) && (deltaFile != NULL))
{ {
char deltaFileName[MAXPATHLEN]; char deltaFileName[MAXPATHLEN];
sprintf(deltaFileName, "%s.delta", stubsFileName); snprintf(deltaFileName, sizeof(deltaFileName), "%s.delta", stubsFileName);
replace_file(deltaFileName, deltaFile, TRUE); replace_file(deltaFileName, deltaFile, TRUE);
} }
@ -799,9 +799,9 @@ write_project_files(
sprintf(headerFileName, "%s.h", obj_get_name(project)); sprintf(headerFileName, "%s.h", obj_get_name(project));
strcpy(headerDefineName, abmfP_get_define_from_file_name(headerFileName)); strcpy(headerDefineName, abmfP_get_define_from_file_name(headerFileName));
sprintf(headerBakFileName, "%s.BAK", headerFileName); snprintf(headerBakFileName, sizeof(headerBakFileName), "%s.BAK", headerFileName);
sprintf(stubsFileName, "%s.c", obj_get_name(project)); sprintf(stubsFileName, "%s.c", obj_get_name(project));
sprintf(stubsBakFileName, "%s.BAK", stubsFileName); snprintf(stubsBakFileName, sizeof(stubsBakFileName), "%s.BAK", stubsFileName);
/***** PROJECT HEADER FILE *****/ /***** PROJECT HEADER FILE *****/

2
cde/programs/dtappbuilder/src/abmf/stubs_c_file.c
View file

@ -1026,7 +1026,7 @@ abmfP_write_action_function(
ABObj toObj = obj_get_to(action); ABObj toObj = obj_get_to(action);
ABObj module = NULL; ABObj module = NULL;
char actionName[1024]; char actionName[1024];
char actionPrintf[1024]; char actionPrintf[32 + sizeof(actionName)];
abmfP_gencode_enter_func(genCodeInfo); abmfP_gencode_enter_func(genCodeInfo);
abmfP_ip_obj(genCodeInfo) = obj_get_to(action); abmfP_ip_obj(genCodeInfo) = obj_get_to(action);

2
cde/programs/dtappbuilder/src/libABil/bil_lexer.c
View file

@ -381,7 +381,7 @@ yyerror(const char *message)
CATGETS(ABIL_MESSAGE_CATD, ABIL_MESSAGE_SET, 37, ", near '%s'"), CATGETS(ABIL_MESSAGE_CATD, ABIL_MESSAGE_SET, 37, ", near '%s'"),
tokenText); tokenText);
} }
sprintf(errMsg, "%s%s\n", message, tokenMsg); snprintf(errMsg, sizeof(errMsg), "%s%s\n", message, tokenMsg);
abil_print_custom_load_err(errMsg); abil_print_custom_load_err(errMsg);
} }

2
cde/programs/dtappbuilder/src/libABobj/obj_notify.c
View file

@ -908,7 +908,7 @@ event_print(OBJ_EVENT *event, FILE *outFile, BOOL addNewline, STRING name)
{ {
ABObj obj= NULL; ABObj obj= NULL;
char eventName[1024]; char eventName[1024];
char eventParams[1024]; char eventParams[1024 + 2];
char *eventParamsPtr= eventParams; char *eventParamsPtr= eventParams;
char buf1[256]; char buf1[256];
char buf2[256]; char buf2[256];