From 43c09c2d6f2a09af105f22ebca90e0a4c241a85b Mon Sep 17 00:00:00 2001 From: Martijn Dekker Date: Wed, 24 Jun 2020 16:40:28 +0200 Subject: [PATCH] tests/pty.sh: disable 137(C) because it actually tests vi(1) Testing the behaviour of an external editor, even the standard one, is outside the scope of the ksh regression tests. src/cmd/ksh93/tests/pty.sh: - Disable a test that invoked vi(1) and that failed, either intermittently or consistently, on too many systems because whatever vi(1) is installed locally doesn't write the string "/tmp/" exactly as and/or when expected. --- src/cmd/ksh93/tests/pty.sh | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/cmd/ksh93/tests/pty.sh b/src/cmd/ksh93/tests/pty.sh index 1ccf523d7..9a8a9b7d3 100755 --- a/src/cmd/ksh93/tests/pty.sh +++ b/src/cmd/ksh93/tests/pty.sh @@ -369,7 +369,13 @@ u #echo save r history ! -# err_exit # +# Following test is disabled because it fails on too many systems, either intermittently +# or consistently, through no fault of ksh, because vi(1) somehow fails to write "/tmp/" +# as expected. Testing the POSIX compliance of whatever vi(1) the local system happens +# to have is outside the scope of these tests, which are supposed to be testing ksh. +# It is left here for re-enabling temporarily if related changes in ksh need testing. +: <<\end_disabled +# err_(don't count me)_exit # TMPDIR=/tmp tst $LINENO <<"!" L POSIX sh 137(C) @@ -389,6 +395,7 @@ s 400 w :wq u ^hello world\r?\n$ ! +end_disabled # err_exit # tst $LINENO <<"!"