external/cde
1
0
Fork 0
mirror of git://git.code.sf.net/p/cdesktopenv/code synced 2025-02-15 04:32:24 +00:00
Code Issues Releases Wiki Activity

DtTerm: Coverity (memory corruption, moderate)

Browse source
This commit is contained in:
Jon Trulson 2014-12-26 15:59:52 -07:00
parent cedb47114f
commit 50de34a933
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
cde/lib/DtTerm/TermPrim/TermPrimDebug.c
View file

@ -444,15 +444,15 @@ enumToName
{ {
int i1; int i1;
char buffer[BUFSIZ]; char buffer[BUFSIZ];
static char *retBuffer = (char *) 0; static char *retBuffer = NULL;
for (i1 = 0; list[i1].string; i1++) { for (i1 = 0; list[i1].string; i1++) {
if (list[i1].value == value) { if (list[i1].value == value) {
return(list[i1].string); return(list[i1].string);
} }
} }
(void) sprintf(buffer, "Unknown Value %d", value); snprintf(buffer, BUFSIZ, "Unknown Value %d", value);
retBuffer = realloc(retBuffer, strlen(buffer)); retBuffer = realloc(retBuffer, strlen(buffer) + 1);
(void) strcpy(retBuffer, buffer); (void) strcpy(retBuffer, buffer);
return(retBuffer); return(retBuffer);
} }
@ -467,14 +467,14 @@ _DtTermPrimDebugDumpEvent
{ {
_DtTermProcessLock(); _DtTermProcessLock();
(void) fprintf(f, ">> widget: name=\"%s\" widget=0x%lx window=0x%lx\n", (void) fprintf(f, ">> widget: name=\"%s\" widget=0x%lx window=0x%lx\n",
XtName(w), w, XtWindow(w)); XtName(w), (long)w, XtWindow(w));
(void) fprintf(f, ">> event {\n"); (void) fprintf(f, ">> event {\n");
(void) fprintf(f, ">> type=%s;\n", (void) fprintf(f, ">> type=%s;\n",
enumToName(eventTypes, ev->xany.type)); enumToName(eventTypes, ev->xany.type));
(void) fprintf(f, ">> serial=%lu\n", ev->xany.serial); (void) fprintf(f, ">> serial=%lu\n", ev->xany.serial);
(void) fprintf(f, ">> send_event=%s\n", (void) fprintf(f, ">> send_event=%s\n",
enumToName(boolTypes, ev->xany.send_event)); enumToName(boolTypes, ev->xany.send_event));
(void) fprintf(f, ">> display=0x%lx\n", ev->xany.display); (void) fprintf(f, ">> display=0x%lx\n", (long)ev->xany.display);
(void) fprintf(f, ">> window=0x%lx\n", ev->xany.window); (void) fprintf(f, ">> window=0x%lx\n", ev->xany.window);
switch (ev->type) { switch (ev->type) {
case EnterNotify: case EnterNotify: