mirror of
git://git.code.sf.net/p/cdesktopenv/code
synced 2025-03-09 15:50:02 +00:00
Fix corner-case >&- redirection leak out of subshell
Reproducer: exec 9>&1 ( { exec 9>&1; } 9>&- ) echo "test" >&9 # => 9: cannot open [Bad file descriptor] The 9>&- incorrectly persists beyond the { } block that it was attached to *and* beyond the ( ) subshell. This is yet another bug with non-forking subshells; forking it with something like 'ulimit -t unlimited' works around the bug. In over a year we have not been able to find a real fix, but I came up with a workaround that forks a virtual subshell whenever it executes a code block with a >&- or <&- redirection attached. That use case is obscure enough that it should not cause any performance regression except in very rare corner cases. src/cmd/ksh93/sh/xec.c: sh_exec(): TSETIO: - This is where redirections attached to code blocks are handled. Check for a >&- or <&- redirection using bit flaggery from shnodes.h and fork if we're executing such in a virtual subshell. Resolves: https://github.com/ksh93/ksh/issues/161 Thanks to @ko1nksm for the bug report.
This commit is contained in:
parent
14a43a0a88
commit
6304dfce41
4 changed files with 53 additions and 2 deletions
5
NEWS
5
NEWS
|
@ -3,6 +3,11 @@ For full details, see the git log at: https://github.com/ksh93/ksh/tree/1.0
|
|||
|
||||
Any uppercase BUG_* names are modernish shell bug IDs.
|
||||
|
||||
2022-02-11:
|
||||
|
||||
- Fixed a bug in which a >&- or <&- redirection could persist past a
|
||||
subshell in certain corner cases involving 'exec' or 'redirect'.
|
||||
|
||||
2022-02-08:
|
||||
|
||||
- Multiple bugs were fixed in the method that ksh uses to execute a shell
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue