mirror of
git://git.code.sf.net/p/cdesktopenv/code
synced 2025-03-09 15:50:02 +00:00
Remove SHOPT_BASH; keep &> redir operator, '-o posix' option
On 16 June there was a call for volunteers to fix the bash compatibility mode; it has never successfully compiled in 93u+. Since no one showed up, it is now removed due to lack of interest. A couple of things are kept, which are now globally enabled: 1. The &>file redirection shorthand (for >file 2>&1). As a matter of fact, ksh93 already supported this natively, but only while running rc/profile/login scripts, and it issued a warning. This makse it globally available and removes the warning, bringing ksh93 in line with mksh, bash and zsh. 2. The '-o posix' standard compliance option. It is now enabled on startup if ksh is invoked as 'sh' or if the POSIXLY_CORRECT variable exists in the environment. To begin with, it disables the aforementioned &> redirection shorthand. Further compliance tweaks will be added in subsequent commits. The differences will be fairly minimal as ksh93 is mostly compliant already. In all changed files, code was removed that was compiled (more precisely, failed to compile/link) if the SHOPT_BASH preprocessor identifier was defined. Below are other changes worth mentioning: src/cmd/ksh93/sh/bash.c, src/cmd/ksh93/data/bash_pre_rc.sh: - Removed. src/cmd/ksh93/data/lexstates.c, src/cmd/ksh93/include/shlex.h, src/cmd/ksh93/sh/lex.c: - Globally enable &> redirection operator if SH_POSIX not active. - Remove warning that was issued when &> was used in rc scripts. src/cmd/ksh93/data/options.c, src/cmd/ksh93/include/defs.h, src/cmd/ksh93/sh/args.c: - Keep SH_POSIX option (-o posix). - Replace SH_TYPE_BASH shell type by SH_TYPE_POSIX. src/cmd/ksh93/sh/init.c: - sh_type(): Return SH_TYPE_POSIX shell type if ksh was invoked as sh (or rsh, restricted sh). - sh_init(): Enable posix option if the SH_TYPE_POSIX shell type was detected, or if the CONFORMANCE ast config variable was set to "standard" (which libast sets on init if POSIXLY_CORRECT exists in the environment). src/cmd/ksh93/tests/options.sh, src/cmd/ksh93/tests/io.sh: - Replace regression tests for &> and move to io.sh. Since &> is now for general use, no longer test in an rc script, and don't check that a warning is issued. Closes: #9 Progresses: #20
This commit is contained in:
parent
84331a96fc
commit
921bbcaeb7
25 changed files with 95 additions and 1148 deletions
|
@ -597,5 +597,24 @@ then trap 'sleep_pid=0; kill "$ksh_pid"; err_exit "'\''read'\'' hangs on EOF wit
|
|||
else err_exit "mkfifo failed; cannot test reading from FIFO"
|
||||
fi
|
||||
|
||||
# ======
|
||||
# "&>file" redirection operator, shorthand for ">file 2>&1" (new as of 93u+m; inherited from old SHOPT_BASH)
|
||||
if [[ -o ?posix ]]
|
||||
then set -o posix
|
||||
# This should print in a background job, then create an empty file, as '>aha1.txt' is a separate command.
|
||||
eval ' print -u1 bad1 &>aha1.txt
|
||||
print -u2 bad2 &>aha2.txt
|
||||
' >/dev/null 2>&1
|
||||
[[ -s aha1.txt ]] && err_exit "&> not deactivated in POSIX mode (stdout; got '$(cat aha1.txt)')"
|
||||
[[ -s aha2.txt ]] && err_exit "&> not deactivated in POSIX mode (stderr; got '$(cat aha2.txt)')"
|
||||
set +o posix
|
||||
# This should write the text to the file.
|
||||
eval ' print -u1 ok1 &>aha1.txt
|
||||
print -u2 ok2 &>aha2.txt
|
||||
' >/dev/null 2>&1
|
||||
[[ $(< aha1.txt) == ok1 ]] || err_exit '&> does not redirect stdout'
|
||||
[[ $(< aha2.txt) == ok2 ]] || err_exit '&> does not redirect stderr'
|
||||
fi
|
||||
|
||||
# ======
|
||||
exit $((Errors<125?Errors:125))
|
||||
|
|
|
@ -53,28 +53,9 @@ then err_exit 'sh -e not working'
|
|||
fi
|
||||
[[ $($SHELL -D -c 'print hi; print $"hello"') == '"hello"' ]] || err_exit 'ksh -D not working'
|
||||
|
||||
env=$tmp/.env
|
||||
print $'(print -u1 aha) &>/dev/null\n(print -u2 aha) &>/dev/null' > $env
|
||||
rc=$tmp/.kshrc
|
||||
print $'PS1=""\nfunction env_hit\n{\n\tprint OK\n}' > $rc
|
||||
|
||||
export ENV=/.$env
|
||||
if [[ ! -o privileged ]]
|
||||
then
|
||||
got=$($SHELL -E -c : 2>/dev/null)
|
||||
if [[ $g ]]
|
||||
then
|
||||
got=$(printf %q "$got")
|
||||
err_exit "\$ENV file &>/dev/null does not redirect stdout -- expected '', got $got"
|
||||
fi
|
||||
got=$(set +x; $SHELL -E -c : 2>&1 >/dev/null)
|
||||
if [[ $got != *nonstandard* || $got == *$'\n'* ]]
|
||||
then
|
||||
got=$(printf %q "$got")
|
||||
err_exit "\$ENV file &>/dev/null does not redirect stderr -- expected one diagnostic line, got $got"
|
||||
fi
|
||||
fi
|
||||
|
||||
export ENV=/.$rc
|
||||
if [[ -o privileged ]]
|
||||
then
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue