From fff0c545387028eeeb6ac89d7c9c0d94fb46965b Mon Sep 17 00:00:00 2001 From: Peter Howkins Date: Wed, 7 Nov 2018 01:05:56 +0000 Subject: [PATCH 1/2] libDtHelp: Fix a regression with the Help Index pages caused by an overzealous Coverity fix --- cde/lib/DtHelp/GlobSearch.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/cde/lib/DtHelp/GlobSearch.c b/cde/lib/DtHelp/GlobSearch.c index e789e6e7e..ef572f494 100644 --- a/cde/lib/DtHelp/GlobSearch.c +++ b/cde/lib/DtHelp/GlobSearch.c @@ -510,9 +510,6 @@ static Boolean GetVolumeInfoCB ( *ret_docId = locDocId ? locDocId : XtNewString(&empty); if (ret_timeStamp) *ret_timeStamp = locTimeStamp?locTimeStamp:XtNewString(&empty); - - free(locDocId); - free(locTimeStamp); } if (ret_nameKey) From cb4075e85506636b4d5603b2601b6246672e1a55 Mon Sep 17 00:00:00 2001 From: Peter Howkins Date: Wed, 7 Nov 2018 17:04:59 +0000 Subject: [PATCH 2/2] libDtHelp: Fix another regression caused by Coverity fix, clicking 'Help Manager' works again. --- cde/lib/DtHelp/Access.c | 1 - 1 file changed, 1 deletion(-) diff --git a/cde/lib/DtHelp/Access.c b/cde/lib/DtHelp/Access.c index bd08c941c..5b2ac4750 100644 --- a/cde/lib/DtHelp/Access.c +++ b/cde/lib/DtHelp/Access.c @@ -2654,7 +2654,6 @@ _DtHelpCeIsTopTopic ( if (_DtHelpCeMapCcdfTargetToId(vol, id, &topicId) == 0 && _DtHelpCeGetCcdfTopTopic(vol, &topId) == 0) result = _DtHelpCeStrCaseCmpLatin1(topId, topicId); - free(topicId); } else if (_DtHelpCeMapIdToSdlTopicId(vol, id, &topicId) == 0) {