external/cde
1
0
Fork 0
mirror of git://git.code.sf.net/p/cdesktopenv/code synced 2025-03-09 15:50:02 +00:00
Code Issues Releases Wiki Activity

Revert buggy exec optimisation (re: d6c9821c)

Browse source 
As of 2022-06-18, ksh 93u+m is not capable of being used as /bin/sh
while building GNU binutils. The execution of some of its build
system's dot scripts is incorrectly aborted as an external 'sed'
command is execve(2)'d without forking. This means that incorrect
exec optimization was happening.

Unfortunately I have not been able to derive a minimal reproducer
of the problem yet because the GNU binutils build scripts are very
complex. Pending further research, the optimisation is reverted.
Even if a way to make it work is found, it will not be reintroduced
to the 1.0 branch.

Thanks to @atheik for finding the problem and identifying the
commit that introduced it.

Resolves: https://github.com/ksh93/ksh/issues/507
This commit is contained in:
Martijn Dekker 2022-08-05 12:14:03 +02:00
parent c848433d41
commit 9c9743998f
5 changed files with 24 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/cmd/ksh93/include/version.h
View file

@ -17,8 +17,8 @@
#include <releaseflags.h>
#define SH_RELEASE_FORK "93u+m" /* only change if you develop a new ksh93 fork */
#define SH_RELEASE_SVER "1.0.0" /* semantic version number: https://semver.org */
#define SH_RELEASE_DATE "2022-08-01" /* must be in this format for $((.sh.version)) */
#define SH_RELEASE_SVER "1.0.1" /* semantic version number: https://semver.org */
#define SH_RELEASE_DATE "2022-08-05" /* must be in this format for $((.sh.version)) */
#define SH_RELEASE_CPYR "(c) 2020-2022 Contributors to ksh " SH_RELEASE_FORK
/* Scripts sometimes field-split ${.sh.version}, so don't change amount of whitespace. */