external/cde
1
0
Fork 0
mirror of git://git.code.sf.net/p/cdesktopenv/code synced 2025-03-09 15:50:02 +00:00
Code Issues Releases Wiki Activity

dtwm/WmFP: Coverity (memory corruption, moderate)

Browse source
This commit is contained in:
Jon Trulson 2014-12-26 18:10:07 -07:00
parent f05c124807
commit a71cde075e
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
cde/programs/dtwm/WmFP.c
View file

@ -745,8 +745,6 @@ WmPanelistShow (Widget w)
int i; int i;
Arg al[20]; Arg al[20];
int ac; int ac;
/* Find the switch data for later processing */ /* Find the switch data for later processing */
@ -785,16 +783,15 @@ WmPanelistShow (Widget w)
if (shell_geometry == NULL) if (shell_geometry == NULL)
{ {
Position x; Position x;
char geometry_buffer[32];
if (panel.element_values[PANEL_GEOMETRY].string_value != NULL) if (panel.element_values[PANEL_GEOMETRY].string_value != NULL)
{ {
shell_geometry = panel.element_values[PANEL_GEOMETRY].parsed_value; shell_geometry = panel.element_values[PANEL_GEOMETRY].parsed_value;
} }
else else
{ {
x = (screen_width > width) ? (Position)(screen_width - width) / 2 : 0; x = (screen_width > width) ? (Position)(screen_width - width) / 2 : 0;
sprintf (geometry_buffer, "+%d-0", x); snprintf (geometry_buffer, 32 - 1, "+%d-0", x);
shell_geometry = geometry_buffer; shell_geometry = geometry_buffer;
} }