From a77253f9ced047d3dde3387140e414a025164fb8 Mon Sep 17 00:00:00 2001 From: Jon Trulson Date: Sun, 12 Dec 2021 13:28:44 -0700 Subject: [PATCH] Fix a Wself-assign-field clang warning The arg that should be on the rhs seems to be commented out for some reason, and assigning a variable to itself is pointless, so just comment it out with a comment explaining why. --- cde/programs/dtprintinfo/libUI/MotifUI/Dialog.C | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cde/programs/dtprintinfo/libUI/MotifUI/Dialog.C b/cde/programs/dtprintinfo/libUI/MotifUI/Dialog.C index 561477304..4c1ba2341 100644 --- a/cde/programs/dtprintinfo/libUI/MotifUI/Dialog.C +++ b/cde/programs/dtprintinfo/libUI/MotifUI/Dialog.C @@ -338,7 +338,11 @@ Dialog::Dialog(MotifUI *parent, char *title, char *base_directory, StringFree(pattern_string); if (help) { - _help_callback_data = _help_callback_data; + // JET - this does nothing - should probably be assigned from + // help_callback_data, but that argument seems to have been + // removed from the arg list (commented out for some reason). + // So, I'll just comment this out for now: + // _help_callback_data = _help_callback_data; XtAddCallback(_w, XmNhelpCallback, &Dialog::DialogCB, (XtPointer) this); } else