From d10eab988af9082513f595cacf11a2df6eb095d9 Mon Sep 17 00:00:00 2001 From: Martijn Dekker Date: Sun, 17 May 2020 10:11:06 +0100 Subject: [PATCH] Regression test suite: bugfix: accurately report number of errors The number of errors in each tests/*.sh test set is reported using its exit code (up to 125). The main test script saves this code in $e to report the number of errors. But if a set had errors, $e was then erroneously overwritten before reporting the number of errors, so it was always 1. src/cmd/ksh93/tests/shtests: - Don't overwrite $e with the exit code of ((e == 0)). (cherry picked from commit b9ab95488b23167316f5b21f338368c9490ebc50) --- src/cmd/ksh93/tests/shtests | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/cmd/ksh93/tests/shtests b/src/cmd/ksh93/tests/shtests index ae28f9dca..654201047 100755 --- a/src/cmd/ksh93/tests/shtests +++ b/src/cmd/ksh93/tests/shtests @@ -347,8 +347,7 @@ do if [[ ! -r $i ]] fi if (( e == 0 )) then echo test $o passed ${time:+"at $(date +%Y-%m-%d+%H:%M:%S)"} "[ $t $T 0 ${E}s ]" - else e=$? - if (( e != 1 )) + else if (( e != 1 )) then E=${E}s fi echo test $o failed ${time:+"at $(date +%Y-%m-%d+%H:%M:%S)"} with exit code $e "[ $t $T $e $E ]"