1
0
Fork 0
mirror of git://git.code.sf.net/p/cdesktopenv/code synced 2025-03-09 15:50:02 +00:00
cde/src/cmd/ksh93/sh/expand.c
Martijn Dekker 2182ecfa08 Fix compile/regress fails on compiling without SHOPT_* options
Many compile-time options were broken so that they could not be
turned off without causing compile errors and/or regression test
failures. This commit now allows the following to be disabled:

SHOPT_2DMATCH    # two dimensional ${.sh.match} for ${var//pat/str}
SHOPT_BGX        # one SIGCHLD trap per completed job
SHOPT_BRACEPAT   # C-shell {...,...} expansions (, required)
SHOPT_ESH        # emacs/gmacs edit mode
SHOPT_HISTEXPAND # csh-style history file expansions
SHOPT_MULTIBYTE  # multibyte character handling
SHOPT_NAMESPACE  # allow namespaces
SHOPT_STATS      # add .sh.stats variable
SHOPT_VSH        # vi edit mode

The following still break ksh when disabled:

SHOPT_FIXEDARRAY # fixed dimension indexed array
SHOPT_RAWONLY    # make viraw the only vi mode
SHOPT_TYPEDEF    # enable typeset type definitions

Compiling without SHOPT_RAWONLY just gives four regression test
failures in pty.sh, but turning off SHOPT_FIXEDARRAY and
SHOPT_TYPEDEF causes compilation to fail. I've managed to tweak the
code to make it compile without those two options, but then dozens
of regression test failures occur, often in things nothing directly
to do with those options. It looks like the separation between the
code for these options and the rest was never properly maintained.
Making it possible to disable SHOPT_FIXEDARRAY and SHOPT_TYPEDEF
may involve major refactoring and testing and may not be worth it.

This commit has far too many tweaks to list. Notables fixes are:

src/cmd/ksh93/data/builtins.c,
src/cmd/ksh93/data/options.c:
- Do not compile in the shell options and documentation for
  disabled features (braceexpand, emacs/gmacs, vi/viraw), so the
  shell is not left with no-op options and inaccurate self-doc.

src/cmd/ksh93/data/lexstates.c:
- Comment the state tables to associte them with their IDs.
- In the ST_MACRO table (sh_lexstate9[]), do not make the S_BRACE
  state for position 123 (ASCII for '{') conditional upon
  SHOPT_BRACEPAT (brace expansion), otherwise disabling this causes
  glob patterns of the form {3}(x) (matching 3 x'es) to stop
  working as well -- and that is ksh globbing, not brace expansion.

src/cmd/ksh93/edit/edit.c: ed_read():
- Fixed a bug: SIGWINCH was not handled by the gmacs edit mode.

src/cmd/ksh93/sh/name.c: nv_putval():
- The -L/-R left/right adjustment options to typeset do not count
  zero-width characters. This is the behaviour with SHOPT_MULTIBYTE
  enabled, regardless of locale. Of course, what a zero-width
  character is depends on the locale, but control characters are
  always considered zero-width. So, to avoid a regression, add some
  fallback code for non-SHOPT_MULTIBYTE builds that skips ASCII
  control characters (as per iscntrl(3)) so they are still
  considered to have zero width.

src/cmd/ksh93/tests/shtests:
- Export the SHOPT_* macros from SHOPT.sh to the tests as
  environment variables, so the tests can check for them and decide
  whether or how to run tests based on the compile-time options
  that the tested binary was presumably compiled with.
- Do not run the C.UTF-8 tests if SHOPT_MULTIBYTE is not enabled.

src/cmd/ksh93/tests/*.sh:
- Add a bunch of checks for SHOPT_* env vars. Since most should
  have a value 0 (off) or 1 (on), the form ((SHOPT_FOO)) is a
  convenient way to use them as arithmetic booleans.

.github/workflows/ci.yml:
- Make GitHub do more testing: run two locale tests (Dutch and
  Japanese UTF-8 locales), then disable all the SHOPTs that we can
  currently disable, recompile ksh, and run the tests again.
2021-02-08 22:02:45 +00:00

384 lines
8.4 KiB
C

/***********************************************************************
* *
* This software is part of the ast package *
* Copyright (c) 1982-2011 AT&T Intellectual Property *
* and is licensed under the *
* Eclipse Public License, Version 1.0 *
* by AT&T Intellectual Property *
* *
* A copy of the License is available at *
* http://www.eclipse.org/org/documents/epl-v10.html *
* (with md5 checksum b35adb5213ca9657e911e9befb180842) *
* *
* Information and Software Systems Research *
* AT&T Research *
* Florham Park NJ *
* *
* David Korn <dgk@research.att.com> *
* *
***********************************************************************/
#pragma prototyped
/*
* File name expansion
*
* David Korn
* AT&T Labs
*
*/
#if KSHELL
# include "defs.h"
# include "variables.h"
# include "test.h"
#else
# include <ast.h>
# include <ctype.h>
# include <setjmp.h>
#endif /* KSHELL */
#include <glob.h>
#include <ls.h>
#include <stak.h>
#include <ast_dir.h>
#include "io.h"
#include "path.h"
#if KSHELL
# define argbegin argnxt.cp
static const char *sufstr;
static int suflen;
static int scantree(Dt_t*,const char*, struct argnod**);
#else
# define sh_sigcheck(sig) (0)
# define sh_access access
# define suflen 0
#endif /* KSHELL */
/*
* This routine builds a list of files that match a given pathname
* Uses external routine strgrpmatch() to match each component
* A leading . must match explicitly
*
*/
#ifndef GLOB_AUGMENTED
# define GLOB_AUGMENTED 0
#endif
#define GLOB_RESCAN 1
#define globptr() ((struct glob*)membase)
static struct glob *membase;
static char *nextdir(glob_t *gp, char *dir)
{
Shell_t *shp = sh_getinterp();
Pathcomp_t *pp = (Pathcomp_t*)gp->gl_handle;
if(!dir)
pp = path_get(shp,"");
else
pp = pp->next;
gp->gl_handle = (void*)pp;
if(pp)
return(pp->name);
return(0);
}
int path_expand(Shell_t *shp,const char *pattern, struct argnod **arghead)
{
glob_t gdata;
register struct argnod *ap;
register glob_t *gp= &gdata;
register int flags,extra=0;
sh_stats(STAT_GLOBS);
memset(gp,0,sizeof(gdata));
flags = GLOB_GROUP|GLOB_AUGMENTED|GLOB_NOCHECK|GLOB_NOSORT|GLOB_STACK|GLOB_LIST|GLOB_DISC;
if(sh_isoption(SH_MARKDIRS))
flags |= GLOB_MARK;
if(sh_isoption(SH_GLOBSTARS))
flags |= GLOB_STARSTAR;
if(sh_isstate(SH_COMPLETE))
{
#if KSHELL
extra += scantree(shp->alias_tree,pattern,arghead);
extra += scantree(shp->fun_tree,pattern,arghead);
gp->gl_nextdir = nextdir;
#endif /* KSHELL */
flags |= GLOB_COMPLETE;
flags &= ~GLOB_NOCHECK;
}
gp->gl_fignore = nv_getval(sh_scoped(shp,FIGNORENOD));
if(suflen)
gp->gl_suffix = sufstr;
gp->gl_intr = &shp->trapnote;
suflen = 0;
if(memcmp(pattern,"~(N",3)==0)
flags &= ~GLOB_NOCHECK;
glob(pattern, flags, 0, gp);
sh_sigcheck(shp);
for(ap= (struct argnod*)gp->gl_list; ap; ap = ap->argnxt.ap)
{
ap->argchn.ap = ap->argnxt.ap;
if(!ap->argnxt.ap)
ap->argchn.ap = *arghead;
}
if(gp->gl_list)
*arghead = (struct argnod*)gp->gl_list;
return(gp->gl_pathc+extra);
}
#if KSHELL
/*
* scan tree and add each name that matches the given pattern
*/
static int scantree(Dt_t *tree, const char *pattern, struct argnod **arghead)
{
register Namval_t *np;
register struct argnod *ap;
register int nmatch=0;
register char *cp;
np = (Namval_t*)dtfirst(tree);
for(;np && !nv_isnull(np);(np = (Namval_t*)dtnext(tree,np)))
{
if(strmatch(cp=nv_name(np),pattern))
{
ap = (struct argnod*)stakseek(ARGVAL);
stakputs(cp);
ap = (struct argnod*)stakfreeze(1);
ap->argbegin = NIL(char*);
ap->argchn.ap = *arghead;
ap->argflag = ARG_RAW|ARG_MAKE;
*arghead = ap;
nmatch++;
}
}
return(nmatch);
}
/*
* file name completion
* generate the list of files found by adding an suffix to end of name
* The number of matches is returned
*/
int path_complete(Shell_t *shp,const char *name,register const char *suffix, struct argnod **arghead)
{
sufstr = suffix;
suflen = strlen(suffix);
return(path_expand(shp,name,arghead));
}
#endif
#if SHOPT_BRACEPAT
static int checkfmt(Sfio_t* sp, void* vp, Sffmt_t* fp)
{
return -1;
}
int path_generate(Shell_t *shp,struct argnod *todo, struct argnod **arghead)
/*@
assume todo!=0;
return count satisfying count>=1;
@*/
{
register char *cp;
register int brace;
register struct argnod *ap;
struct argnod *top = 0;
struct argnod *apin;
char *pat, *rescan;
char *format;
char comma, range=0;
int first, last, incr, count = 0;
char tmp[32], end[1];
todo->argchn.ap = 0;
again:
apin = ap = todo;
todo = ap->argchn.ap;
cp = ap->argval;
range = comma = brace = 0;
/* first search for {...,...} */
while(1) switch(*cp++)
{
case '{':
if(brace++==0)
pat = cp;
break;
case '}':
if(--brace>0)
break;
if(brace==0 && comma && *cp!='(')
goto endloop1;
comma = brace = 0;
break;
case '.':
if(brace==1 && *cp=='.')
{
char *endc;
incr = 1;
if(isdigit(*pat) || *pat=='+' || *pat=='-')
{
first = strtol(pat,&endc,0);
if(endc==(cp-1))
{
last = strtol(cp+1,&endc,0);
if(*endc=='.' && endc[1]=='.')
incr = strtol(endc+2,&endc,0);
else if(last<first)
incr = -1;
if(incr)
{
if(*endc=='%')
{
Sffmt_t fmt;
memset(&fmt, 0, sizeof(fmt));
fmt.version = SFIO_VERSION;
fmt.form = endc;
fmt.extf = checkfmt;
sfprintf(sfstdout, "%!", &fmt);
if(!(fmt.flags&(SFFMT_LLONG|SFFMT_LDOUBLE)))
switch (fmt.fmt)
{
case 'c':
case 'd':
case 'i':
case 'o':
case 'u':
case 'x':
case 'X':
format = endc;
endc = fmt.form;
break;
}
}
else
format = "%d";
if(*endc=='}')
{
cp = endc+1;
range = 2;
goto endloop1;
}
}
}
}
else if((cp[2]=='}' || cp[2]=='.' && cp[3]=='.') && ((*pat>='a' && *pat<='z' && cp[1]>='a' && cp[1]<='z') || (*pat>='A' && *pat<='Z' && cp[1]>='A' && cp[1]<='Z')))
{
first = *pat;
last = cp[1];
cp += 2;
if(*cp=='.')
{
incr = strtol(cp+2,&endc,0);
cp = endc;
}
else if(first>last)
incr = -1;
if(incr && *cp=='}')
{
cp++;
range = 1;
goto endloop1;
}
}
cp++;
}
break;
case ',':
if(brace==1)
comma = 1;
break;
case '\\':
cp++;
break;
case 0:
/* insert on stack */
ap->argchn.ap = top;
top = ap;
if(todo)
goto again;
for(; ap; ap=apin)
{
apin = ap->argchn.ap;
if(!sh_isoption(SH_NOGLOB))
brace=path_expand(shp,ap->argval,arghead);
else
{
ap->argchn.ap = *arghead;
*arghead = ap;
brace=1;
}
if(brace)
{
count += brace;
(*arghead)->argflag |= ARG_MAKE;
}
}
return(count);
}
endloop1:
rescan = cp;
cp = pat-1;
*cp = 0;
while(1)
{
brace = 0;
if(range)
{
if(range==1)
{
pat[0] = first;
cp = &pat[1];
}
else
{
*(rescan - 1) = 0;
sfsprintf(pat=tmp,sizeof(tmp),format,first);
*(rescan - 1) = '}';
*(cp = end) = 0;
}
if(incr*(first+incr) > last*incr)
*cp = '}';
else
first += incr;
}
/* generate each pattern and put on the todo list */
else while(1) switch(*++cp)
{
case '\\':
cp++;
break;
case '{':
brace++;
break;
case ',':
if(brace==0)
goto endloop2;
break;
case '}':
if(--brace<0)
goto endloop2;
}
endloop2:
brace = *cp;
*cp = 0;
sh_sigcheck(shp);
ap = (struct argnod*)stakseek(ARGVAL);
ap->argflag = ARG_RAW;
ap->argchn.ap = todo;
stakputs(apin->argval);
stakputs(pat);
stakputs(rescan);
todo = ap = (struct argnod*)stakfreeze(1);
if(brace == '}')
break;
if(!range)
pat = cp+1;
}
goto again;
}
#endif /* SHOPT_BRACEPAT */