external/cde
1
0
Fork 0
mirror of git://git.code.sf.net/p/cdesktopenv/code synced 2025-02-24 15:04:13 +00:00
Code Issues Releases Wiki Activity
cde/src/cmd/ksh93/tests
History
Martijn Dekker a1f46d785f rm "I/O error" error msg; just keep >0 exit status (re: 9011fa93) 
The bug was really that I/O errors in output builtins were
undetectable by any means. Having a >0 exit status is sufficient.
Adding an error message risks making existing ksh scripts noisier,
or even breaking them if they redirect stderr to stdout.

Note to self: in future, implement the minimum change necessary to
fix bugs, nothing more. The fact that I needed to add four extra
2>/dev/null to the regression tests should have been a hint.

src/cmd/ksh93/bltins/print.c,
src/cmd/ksh93/data/msg.c,
src/cmd/ksh93/include/io.h:
- Remove "I/O error" message.

src/cmd/ksh93/tests/builtins.sh:
- Update to check for exit status only.

src/cmd/ksh93/tests/basic.sh,
src/cmd/ksh93/tests/coprocess.sh:
- Revert four new '2>/dev/null' to suppress the error message.

(cherry picked from commit 5e17be24d18455b575b6e98bc631c6935ffc795a)
2020-06-12 01:45:18 +02:00
..
alias.sh The unalias builtin should return an error for non-existent aliases 2020-06-12 01:45:18 +02:00
append.sh Version: 2012-08-01-master 2016-01-11 15:54:23 -05:00
arith.sh Regression test suite: get rid of unportable 'mktemp -dt' 2020-06-12 01:45:13 +02:00
arrays.sh Regression test suite: get rid of unportable 'mktemp -dt' 2020-06-12 01:45:13 +02:00
arrays2.sh Fix 47 typos in user-facing help and error messages 2020-06-12 01:45:12 +02:00
attributes.sh Regression test suite: get rid of unportable 'mktemp -dt' 2020-06-12 01:45:13 +02:00
basic.sh rm "I/O error" error msg; just keep >0 exit status (re: 9011fa93) 2020-06-12 01:45:18 +02:00
bracket.sh shtests: More speedups; also fix xtrace (re: 734e5953) 2020-06-12 01:45:17 +02:00
builtins.sh rm "I/O error" error msg; just keep >0 exit status (re: 9011fa93) 2020-06-12 01:45:18 +02:00
case.sh Version: 2012-08-01-master 2016-01-11 15:54:23 -05:00
comvar.sh Fix 80 typos in comments 2020-06-12 01:45:12 +02:00
comvario.sh regress tests: remove use of unportable direct paths to commands 2020-06-12 01:45:15 +02:00
coprocess.sh rm "I/O error" error msg; just keep >0 exit status (re: 9011fa93) 2020-06-12 01:45:18 +02:00
cubetype.sh Version: 2012-08-01-master 2016-01-11 15:54:23 -05:00
enum.sh Version: 2012-08-01-master 2016-01-11 15:54:23 -05:00
exit.sh Regression test suite: get rid of unportable 'mktemp -dt' 2020-06-12 01:45:13 +02:00
expand.sh Fix 47 typos in user-facing help and error messages 2020-06-12 01:45:12 +02:00
functions.sh shtests: More speedups; also fix xtrace (re: 734e5953) 2020-06-12 01:45:17 +02:00
glob.sh regress tests: remove use of unportable direct paths to commands 2020-06-12 01:45:15 +02:00
grep.sh Regression test suite: get rid of unportable 'mktemp -dt' 2020-06-12 01:45:13 +02:00
heredoc.sh regress tests: remove use of unportable direct paths to commands 2020-06-12 01:45:15 +02:00
io.sh shtests: More speedups; also fix xtrace (re: 734e5953) 2020-06-12 01:45:17 +02:00
leaks.sh Version: 2012-08-01-master 2016-01-11 15:54:23 -05:00
locale.sh shtests: More speedups; also fix xtrace (re: 734e5953) 2020-06-12 01:45:17 +02:00
math.sh Regression test suite: get rid of unportable 'mktemp -dt' 2020-06-12 01:45:13 +02:00
nameref.sh fix 24 more typos found with the help of codespell 2020-06-12 01:45:15 +02:00
namespace.sh Regression test suite: get rid of unportable 'mktemp -dt' 2020-06-12 01:45:13 +02:00
options.sh shtests: More speedups; also fix xtrace (re: 734e5953) 2020-06-12 01:45:17 +02:00
path.sh shtests: More speedups; also fix xtrace (re: 734e5953) 2020-06-12 01:45:17 +02:00
pointtype.sh Version: 2012-08-01-master 2016-01-11 15:54:23 -05:00
pty.sh Version: 2012-08-01-master 2016-01-11 15:54:23 -05:00
quoting.sh regress tests: remove use of unportable direct paths to commands 2020-06-12 01:45:15 +02:00
quoting2.sh Version: 2012-08-01-master 2016-01-11 15:54:23 -05:00
readcsv.sh Regression test suite: get rid of unportable 'mktemp -dt' 2020-06-12 01:45:13 +02:00
recttype.sh Version: 2012-08-01-master 2016-01-11 15:54:23 -05:00
restricted.sh regress tests: remove use of unportable direct paths to commands 2020-06-12 01:45:15 +02:00
return.sh Regression test suite: get rid of unportable 'mktemp -dt' 2020-06-12 01:45:13 +02:00
select.sh Regression test suite: get rid of unportable 'mktemp -dt' 2020-06-12 01:45:13 +02:00
shtests shtests: report total errors on terminal and in exit status 2020-06-12 01:45:17 +02:00
sigchld.sh shtests: More speedups; also fix xtrace (re: 734e5953) 2020-06-12 01:45:17 +02:00
signal.sh shtests: More speedups; also fix xtrace (re: 734e5953) 2020-06-12 01:45:17 +02:00
statics.sh fix 24 more typos found with the help of codespell 2020-06-12 01:45:15 +02:00
subshell.sh shtests: fix loose ends 2020-06-12 01:45:17 +02:00
substring.sh shtests: More speedups; also fix xtrace (re: 734e5953) 2020-06-12 01:45:17 +02:00
tilde.sh Regression test suite: get rid of unportable 'mktemp -dt' 2020-06-12 01:45:13 +02:00
timetype.sh Version: 2012-08-01-master 2016-01-11 15:54:23 -05:00
treemove.sh Version: 2012-08-01-master 2016-01-11 15:54:23 -05:00
types.sh Regression test suite: get rid of unportable 'mktemp -dt' 2020-06-12 01:45:13 +02:00
variables.sh shtests: fix loose ends 2020-06-12 01:45:17 +02:00
vartree1.sh Version: 2012-08-01-master 2016-01-11 15:54:23 -05:00
vartree2.sh Version: 2012-08-01-master 2016-01-11 15:54:23 -05:00