Martijn Dekker d7cada7b2e xtrace: fix restore of standard error stream state ... The sh_trace() function, which prints an xtrace line to standard error, clears the SF_SHARE and SF_PUBLIC flags from the sfstderr stream during the xtrace in order to guarantee an atomic trace write. But it only restored those flags if the passed argv pointer is non-NULL. Redirections are traced with a NULL argv parameter, so the stderr state was not restored for them. This somehow caused unpredictable behaviour, including (on some systems) a crash in sfwrite(3) when running the heredoc.sh tests with xtrace on. src/cmd/ksh93/sh/xec.c: sh_xtrace(): - Move the sfset() invocation that restores the SF_SHARE|SF_PUBLIC flags to sfstderr out of the if(argv) block. - Since we're here, don't bother wasting cycles initialising local variable values if xtrace is not on. Move that inside the if(sh_isoption(SH_XTRACE)) block. Resolves: https://github.com/ksh93/ksh/issues/306		2021-11-07 22:41:55 +00:00
..
cmd	xtrace: fix restore of standard error stream state	2021-11-07 22:41:55 +00:00
lib	libcmd: rm old fts_fix workaround	2021-11-07 22:41:48 +00:00
Mamfile	**/Mamfile: add header comment pointing to MAM docs (re: 6cc2f6a0)	2021-01-25 14:38:58 +00:00