Johnothan King 733f70e94b Fix many compiler warnings and remove unused variables (#191) ... Most of these changes remove unused variables, functions and labels to fix -Wunused compiler warnings. Somewhat notable changes: src/cmd/ksh93/bltins/print.c: - Removed the unused 'neg' variable. Patch from ksh2020: https://github.com/att/ast/pull/725 src/cmd/ksh93/bltins/sleep.c: - Initialized ns to fix three -Wsometimes-uninitialized warnings. src/cmd/ksh93/edit/{emacs,vi}.c: - Adjust strncpy size to fix two -Wstringop-truncation warnings. src/cmd/ksh93/include/shell.h: - The NOT_USED macro caused many -Wunused-value warnings, so it has been replaced with ksh2020's macro: 19d0620a src/cmd/ksh93/sh/expand.c: - Removed an unnecessary 'ap = ' since 'ap' is never read between stakseek and stakfreeze. src/cmd/ksh93/edit/vi.c: refresh(): - Undef this function's 'w' macro at the end of it to stop it potentially interfering with future code changes. src/cmd/ksh93/sh/nvdisc.c, src/lib/libast/misc/magic.c, src/lib/libast/regex/regsubexec.c, src/lib/libast/sfio/sfpool.c, src/lib/libast/vmalloc/vmbest.c: - Fixed some indentation to silence -Wmisleading-indentation warnings. src/lib/libast/include/ast.h: - For clang, now only suppress hundreds of -Wparentheses warnings as well as a few -Wstring-plus-int warnings. Clang's -Wparentheses warns about things like if(foo = bar()) which assigns to foo and checks the assigned value. Clang wants us to change this into if((foo = bar())) Clang's -Wstring-plus-int warns about things like "string"+x where x is an integer, e.g. "string"+3 represents the string "ing". Clang wants us to change that to "string"[3] The original versions represent a perfectly valid coding style that was common in the 1980s and 1990s and is not going to change in this historic code base. (gcc does not complain about these.) Co-authored-by: Martijn Dekker <martijn@inlv.org>		2021-02-22 22:16:32 +00:00
..
alarm.c	Add lots of checks for out of memory (re: 0ce0b671)	2021-02-21 22:27:28 +00:00
cd_pwd.c	cd: add missing "test.h" include (re: 5ee290c7)	2021-01-20 22:13:32 +00:00
cflow.c	Fix BUG_LOOPRET2 and related return/exit misbehaviour	2020-09-09 20:02:20 +02:00
enum.c	Fix typos in <customtypecommand> --man self-documentation	2021-02-10 16:25:11 +00:00
getopts.c	Version: 2012-08-01-master	2016-01-11 15:54:23 -05:00
hist.c	Fix many spelling errors and word repetitions (#188)	2021-02-20 03:22:24 +00:00
misc.c	Add lots of checks for out of memory (re: 0ce0b671)	2021-02-21 22:27:28 +00:00
mkservice.c	resolve/remove USAGE_LICENSE macros; remove repetitive (c) strings	2021-01-31 11:00:49 +00:00
print.c	Fix many compiler warnings and remove unused variables (#191)	2021-02-22 22:16:32 +00:00
read.c	Add lots of checks for out of memory (re: 0ce0b671)	2021-02-21 22:27:28 +00:00
regress.c	resolve/remove USAGE_LICENSE macros; remove repetitive (c) strings	2021-01-31 11:00:49 +00:00
sleep.c	Fix many compiler warnings and remove unused variables (#191)	2021-02-22 22:16:32 +00:00
test.c	test -p: fix bug due to wrong parentheses	2021-01-28 05:16:49 +00:00
trap.c	Fix I/O redirection in -c script (Solaris patch 280-23332860)	2021-01-08 15:15:53 +00:00
typeset.c	Fix many compiler warnings and remove unused variables (#191)	2021-02-22 22:16:32 +00:00
ulimit.c	Version: 2012-08-01-master	2016-01-11 15:54:23 -05:00
umask.c	Version: 2012-08-01-master	2016-01-11 15:54:23 -05:00
whence.c	command -x: fix efficiency; always run external cmd (re: acf84e96)	2021-01-30 06:53:19 +00:00