From a1edaa1ed6ab2a857ae7f0f67c89dacba41da4e1 Mon Sep 17 00:00:00 2001
From: topilski <atopilski@gmail.com>
Date: Tue, 3 Sep 2019 23:49:04 -0400
Subject: [PATCH] Review

---
 app/common                       | 2 +-
 app/service/service_manager.py   | 2 +-
 app/service/subscriber_client.py | 3 +--
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/app/common b/app/common
index 201c631..111b607 160000
--- a/app/common
+++ b/app/common
@@ -1 +1 @@
-Subproject commit 201c631c2464927690c3fe3b1c0d26853faa9586
+Subproject commit 111b60787080a1443d3d1ac09ea793b2eb605ca2
diff --git a/app/service/service_manager.py b/app/service/service_manager.py
index 4ea5e96..c300c4b 100644
--- a/app/service/service_manager.py
+++ b/app/service/service_manager.py
@@ -82,7 +82,7 @@ class ServiceManager(IClientHandler):
 
             for client in self._subscribers:
                 if ts_sec - client.last_ping_ts > ServiceManager.PING_SUBSCRIBERS_SEC:
-                    #client.ping()
+                    client.ping(client.gen_request_id())
                     client.last_ping_ts = ts_sec
 
     def process_response(self, client, req: Request, resp: Response):
diff --git a/app/service/subscriber_client.py b/app/service/subscriber_client.py
index be9799b..7b563df 100644
--- a/app/service/subscriber_client.py
+++ b/app/service/subscriber_client.py
@@ -52,8 +52,7 @@ class SubscriberConnection(SubscriberClient):
         self.process_commands(data)
         return True
 
-    # private
-    def _gen_request_id(self) -> int:
+    def gen_request_id(self) -> int:
         current_value = self._request_id
         self._request_id += 1
         return current_value