From b74e093ddf323e87b4d79107777dc35f63a7ab85 Mon Sep 17 00:00:00 2001 From: Hachi-R Date: Sun, 16 Feb 2025 17:05:55 -0300 Subject: [PATCH 1/3] fix: ensure objectId exists before removing game from favorites --- .../src/pages/game-details/hero/hero-panel-actions.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/renderer/src/pages/game-details/hero/hero-panel-actions.tsx b/src/renderer/src/pages/game-details/hero/hero-panel-actions.tsx index 0646b0f4..eee40df8 100644 --- a/src/renderer/src/pages/game-details/hero/hero-panel-actions.tsx +++ b/src/renderer/src/pages/game-details/hero/hero-panel-actions.tsx @@ -61,9 +61,9 @@ export function HeroPanelActions() { setToggleLibraryGameDisabled(true); try { - if (game?.favorite) { + if (game?.favorite && objectId) { await window.electron - .removeGameFromFavorites(shop, objectId!) + .removeGameFromFavorites(shop, objectId) .then(() => { showSuccessToast(t("game_removed_from_favorites")); }); From a372afc92c67645f978822dee5cfabe48f06d111 Mon Sep 17 00:00:00 2001 From: Hachi-R Date: Sun, 16 Feb 2025 17:07:39 -0300 Subject: [PATCH 2/3] fix: prevent adding game to favorites without objectId --- .../src/pages/game-details/hero/hero-panel-actions.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/renderer/src/pages/game-details/hero/hero-panel-actions.tsx b/src/renderer/src/pages/game-details/hero/hero-panel-actions.tsx index eee40df8..1ba24705 100644 --- a/src/renderer/src/pages/game-details/hero/hero-panel-actions.tsx +++ b/src/renderer/src/pages/game-details/hero/hero-panel-actions.tsx @@ -68,7 +68,9 @@ export function HeroPanelActions() { showSuccessToast(t("game_removed_from_favorites")); }); } else { - await window.electron.addGameToFavorites(shop, objectId!).then(() => { + if (!objectId) return; + + await window.electron.addGameToFavorites(shop, objectId).then(() => { showSuccessToast(t("game_added_to_favorites")); }); } From 043062eda88dd397129ee345cf93660f19d80739 Mon Sep 17 00:00:00 2001 From: Hachi-R Date: Sun, 16 Feb 2025 17:08:23 -0300 Subject: [PATCH 3/3] remove whitespace --- src/renderer/src/pages/game-details/hero/hero-panel-actions.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/src/pages/game-details/hero/hero-panel-actions.tsx b/src/renderer/src/pages/game-details/hero/hero-panel-actions.tsx index 1ba24705..a3b75d2e 100644 --- a/src/renderer/src/pages/game-details/hero/hero-panel-actions.tsx +++ b/src/renderer/src/pages/game-details/hero/hero-panel-actions.tsx @@ -69,7 +69,7 @@ export function HeroPanelActions() { }); } else { if (!objectId) return; - + await window.electron.addGameToFavorites(shop, objectId).then(() => { showSuccessToast(t("game_added_to_favorites")); });