Merge pull request #710 from hydralauncher/fix/window-auto-launch-on-startup

fix: windows auto launch on startup

electron-builder.yml

@@ -8,6 +8,7 @@ extraResources:
   - from: node_modules/ps-list/vendor/fastlist-0.3.0-x64.exe
     to: fastlist.exe
   - from: node_modules/create-desktop-shortcuts/src/windows.vbs
+  - from: resources/hydralauncher.vbs
 files:
   - "!**/.vscode/*"
   - "!src/*"

resources/hydralauncher.vbs

@@ -0,0 +1,3 @@
+Set WshShell = CreateObject("WScript.Shell" ) 
+WshShell.Run """%localappdata%\Programs\Hydra\Hydra.exe""", 0 'Must quote command if it has spaces; must escape quotes
+Set WshShell = Nothing

src/main/constants.ts

@@ -14,3 +14,12 @@ export const logsPath = path.join(app.getPath("appData"), "hydra", "logs");
 export const seedsPath = app.isPackaged
   ? path.join(process.resourcesPath, "seeds")
   : path.join(__dirname, "..", "..", "seeds");
+
+export const windowsStartupPath = path.join(
+  app.getPath("appData"),
+  "Microsoft",
+  "Windows",
+  "Start Menu",
+  "Programs",
+  "Startup"
+);

src/main/events/index.ts

@@ -49,4 +49,8 @@ import "./profile/update-profile";
 
 ipcMain.handle("ping", () => "pong");
 ipcMain.handle("getVersion", () => app.getVersion());
+ipcMain.handle(
+  "isPortableVersion",
+  () => process.env.PORTABLE_EXECUTABLE_FILE != null
+);
 ipcMain.handle("getDefaultDownloadsPath", () => defaultDownloadsPath);

src/main/events/user-preferences/auto-launch.ts

@@ -1,18 +1,35 @@
+import { windowsStartupPath } from "@main/constants";
 import { registerEvent } from "../register-event";
 import AutoLaunch from "auto-launch";
 import { app } from "electron";
+import fs from "node:fs";
+import path from "node:path";
 
 const autoLaunch = async (
   _event: Electron.IpcMainInvokeEvent,
   enabled: boolean
 ) => {
-  const appLauncher = new AutoLaunch({
-    name: app.getName(),
-  });
-  if (enabled) {
-    appLauncher.enable().catch();
+  if (!app.isPackaged) return;
+
+  if (process.platform == "win32") {
+    const destination = path.join(windowsStartupPath, "hydralauncher.vbs");
+
+    if (enabled) {
+      const scriptPath = path.join(process.resourcesPath, "hydralauncher.vbs");
+
+      fs.copyFileSync(scriptPath, destination);
+    } else {
+      fs.rmSync(destination);
+    }
   } else {
-    appLauncher.disable().catch();
+    const appLauncher = new AutoLaunch({
+      name: app.getName(),
+    });
+    if (enabled) {
+      appLauncher.enable().catch();
+    } else {
+      appLauncher.disable().catch();
+    }
   }
 };
 

src/preload/index.ts

@@ -110,6 +110,7 @@ contextBridge.exposeInMainWorld("electron", {
   ping: () => ipcRenderer.invoke("ping"),
   getVersion: () => ipcRenderer.invoke("getVersion"),
   getDefaultDownloadsPath: () => ipcRenderer.invoke("getDefaultDownloadsPath"),
+  isPortableVersion: () => ipcRenderer.invoke("isPortableVersion"),
   openExternal: (src: string) => ipcRenderer.invoke("openExternal", src),
   isUserLoggedIn: () => ipcRenderer.invoke("isUserLoggedIn"),
   showOpenDialog: (options: Electron.OpenDialogOptions) =>

src/renderer/src/declaration.d.ts

@@ -104,6 +104,7 @@ declare global {
     getVersion: () => Promise<string>;
     ping: () => string;
     getDefaultDownloadsPath: () => Promise<string>;
+    isPortableVersion: () => Promise<boolean>;
     showOpenDialog: (
       options: Electron.OpenDialogOptions
     ) => Promise<Electron.OpenDialogReturnValue>;

src/renderer/src/pages/settings/settings-behavior.tsx

@@ -10,6 +10,8 @@ export function SettingsBehavior() {
     (state) => state.userPreferences.value
   );
 
+  const [showRunAtStartup, setShowRunAtStartup] = useState(false);
+
   const { updateUserPreferences } = useContext(settingsContext);
 
   const [form, setForm] = useState({
@@ -28,6 +30,12 @@ export function SettingsBehavior() {
     }
   }, [userPreferences]);
 
+  useEffect(() => {
+    window.electron.isPortableVersion().then((isPortableVersion) => {
+      setShowRunAtStartup(!isPortableVersion);
+    });
+  }, []);
+
   const handleChange = (values: Partial<typeof form>) => {
     setForm((prev) => ({ ...prev, ...values }));
     updateUserPreferences(values);
@@ -45,14 +53,16 @@ export function SettingsBehavior() {
         }
       />
 
-      <CheckboxField
-        label={t("launch_with_system")}
-        onChange={() => {
-          handleChange({ runAtStartup: !form.runAtStartup });
-          window.electron.autoLaunch(!form.runAtStartup);
-        }}
-        checked={form.runAtStartup}
-      />
+      {showRunAtStartup && (
+        <CheckboxField
+          label={t("launch_with_system")}
+          onChange={() => {
+            handleChange({ runAtStartup: !form.runAtStartup });
+            window.electron.autoLaunch(!form.runAtStartup);
+          }}
+          checked={form.runAtStartup}
+        />
+      )}
     </>
   );
 }