From 37e76c6e4ab2b8dec00d53e98d1fbbfeb3218d74 Mon Sep 17 00:00:00 2001 From: A Holt Date: Thu, 29 Oct 2020 22:54:08 -0400 Subject: [PATCH 1/4] nodejs: 12.x -> 14.x --- vars/default_vars.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vars/default_vars.yml b/vars/default_vars.yml index 7b5882282..6388effa0 100644 --- a/vars/default_vars.yml +++ b/vars/default_vars.yml @@ -395,7 +395,7 @@ nodejs_install: False nodejs_enabled: False # Node.js version used by roles/nodejs/tasks/main.yml for 3 roles: # nodered (Node-RED), pbx (Asterix, FreePBX) & sugarizer (Sugarizer) -nodejs_version: 12.x # was 8.x until 2019-02-02, was 10.x until 2019-12-21 +nodejs_version: 14.x # was 8.x til 2019-02-02, 10.x until 2019-12-21, 12.x til 2020-10-29 # Flow-based visual programming for wiring together IoT hardware devices etc nodered_install: False From 9a8ce5bfb0a3fe98ffb93ef310dd9b81319bfe8d Mon Sep 17 00:00:00 2001 From: A Holt Date: Thu, 29 Oct 2020 22:59:50 -0400 Subject: [PATCH 2/4] Update default_vars.yml --- vars/default_vars.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vars/default_vars.yml b/vars/default_vars.yml index 6388effa0..9deff57fe 100644 --- a/vars/default_vars.yml +++ b/vars/default_vars.yml @@ -395,7 +395,7 @@ nodejs_install: False nodejs_enabled: False # Node.js version used by roles/nodejs/tasks/main.yml for 3 roles: # nodered (Node-RED), pbx (Asterix, FreePBX) & sugarizer (Sugarizer) -nodejs_version: 14.x # was 8.x til 2019-02-02, 10.x until 2019-12-21, 12.x til 2020-10-29 +nodejs_version: 14.x # was 8.x til 2019-02-02, 10.x til 2019-12-21, 12.x til 2020-10-29 # Flow-based visual programming for wiring together IoT hardware devices etc nodered_install: False From c062e5101f5ce946ca107c96e74206ff59b5b373 Mon Sep 17 00:00:00 2001 From: A Holt Date: Thu, 29 Oct 2020 23:11:33 -0400 Subject: [PATCH 3/4] Clarify: "IA supports Node.js 10.x, 12.x or 14.x" --- roles/internetarchive/tasks/install.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/roles/internetarchive/tasks/install.yml b/roles/internetarchive/tasks/install.yml index 8cfcfc272..2dd6863d8 100644 --- a/roles/internetarchive/tasks/install.yml +++ b/roles/internetarchive/tasks/install.yml @@ -9,10 +9,10 @@ include_role: name: nodejs -- name: FAIL (STOP INSTALLING) IF nodejs_version is not set to 10.x or 12.x +- name: FAIL (STOP INSTALLING) IF nodejs_version is not set to 10.x, 12.x or 14.x fail: - msg: "Internet Archive install cannot proceed, as it currently requires Node.js 10.x or 12.x, and your nodejs_version is set to {{ nodejs_version }}. Please check the value of nodejs_version in /opt/iiab/iiab/vars/default_vars.yml and possibly also /etc/iiab/local_vars.yml" - when: (nodejs_version != "10.x") and (nodejs_version != "12.x") + msg: "Internet Archive install cannot proceed, as it currently requires Node.js 10.x or 12.x or 14.x, and your nodejs_version is set to {{ nodejs_version }}. Please check the value of nodejs_version in /opt/iiab/iiab/vars/default_vars.yml and possibly also /etc/iiab/local_vars.yml" + when: (nodejs_version != "10.x") and (nodejs_version != "12.x") and (nodejs_version != "14.x") - name: "Set 'yarn_install: True' and 'yarn_enabled: True'" set_fact: From ad007eae1017602916ba5eaa0fcf39218dbb15dd Mon Sep 17 00:00:00 2001 From: A Holt Date: Thu, 29 Oct 2020 23:15:19 -0400 Subject: [PATCH 4/4] Eliminate Node-RED's checking for Node.js version --- roles/nodered/tasks/install.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/roles/nodered/tasks/install.yml b/roles/nodered/tasks/install.yml index 4a7473f63..2b40ff5d6 100644 --- a/roles/nodered/tasks/install.yml +++ b/roles/nodered/tasks/install.yml @@ -26,10 +26,11 @@ msg: "Node-RED install cannot proceed, as Node.js is not installed." when: nodejs_installed is undefined -- name: FAIL (STOP THE INSTALL) IF 'nodejs_version != "12.x"' - fail: - msg: "Node-RED install cannot proceed, as it currently requires Node.js 12.x, whereas nodejs_version is set to {{ nodejs_version }}. Please check the value of nodejs_version in /opt/iiab/iiab/vars/default_vars.yml, /etc/iiab/local_vars.yml, /opt/iiab/iiab/roles/nodejs, etc." - when: nodejs_version != "12.x" +# 2020-10-29: not really be nec as Node-RED supports recent Node.js versions +#- name: FAIL (STOP THE INSTALL) IF 'nodejs_version != "12.x"' +# fail: +# msg: "Node-RED install cannot proceed, as it currently requires Node.js 12.x, whereas nodejs_version is set to {{ nodejs_version }}. Please check the value of nodejs_version in /opt/iiab/iiab/vars/default_vars.yml, /etc/iiab/local_vars.yml, /opt/iiab/iiab/roles/nodejs, etc." +# when: nodejs_version != "12.x" # BRUTAL but ensures consistency across OS's / distros like Raspbian Desktop &