From 05e8a62736211241f7763d7682747ee77e3826df Mon Sep 17 00:00:00 2001
From: A Holt <holta@users.noreply.github.com>
Date: Tue, 11 Feb 2020 16:31:30 -0500
Subject: [PATCH] Update internetarchive/tasks/main.yml

---
 roles/internetarchive/tasks/main.yml | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/roles/internetarchive/tasks/main.yml b/roles/internetarchive/tasks/main.yml
index 538041ed8..190880cf0 100644
--- a/roles/internetarchive/tasks/main.yml
+++ b/roles/internetarchive/tasks/main.yml
@@ -19,27 +19,30 @@
     quiet: yes
 
 
-#- name: Set --reinstall fact
-#  set_fact:
-#    internetarchive_upgrade: True
-#  when: reinstall is defined
+# 2020-02-11: @mitra42 & @holta agree (#2247) that the following 2-stanza
+# "UPDATE internetarchive" block should run whenever one is isn't installing
+# (or reinstalling) internetarchive, for now.  We're aware this means slowness
+# during "./runrole internetarchive" but that's very intentional for now -- as
+# it leads to more testing of more recent versions of internetarchive, which
+# is strongly desired.  Finally, these current norms can and probably will be
+# changed in future, when broader IIAB norms develop around "./runrole
+# --upgrade internetarchive" or "./runrole --update internetarchive" or such,
+# as may evolve @ https://github.com/iiab/iiab/pull/2238#discussion_r376168178
 
-- block:    # UPDATE IF... internetarchive_installed is defined and internet_available
+- block:    # BEGIN 2-STANZA BLOCK
 
-  - name: Stop 'internetarchive' systemd service, if internetarchive_upgrade
+  - name: "UPGRADE: Stop 'internetarchive' systemd service, if internetarchive_installed is defined and internet_available"
     systemd:
       name: internetarchive
       daemon_reload: yes
       state: stopped
-    #when: internetarchive_enabled and internetarchive_upgrade
 
-  - name: Update pre-existing install (yarn upgrade) if internetarchive_upgrade
+  - name: "UPGRADE: Run 'yarn upgrade' in {{ internetarchive_dir }}, if internetarchive_installed is defined and internet_available"
     shell: yarn config set child-concurrency 1 && yarn install && yarn upgrade
     args:
       chdir: "{{ internetarchive_dir }}"
-    #when: internetarchive_enabled and internetarchive_upgrade
 
-  when: internetarchive_installed is defined and internet_available   # END BLOCK
+  when: internetarchive_installed is defined and internet_available    # END 2-STANZA BLOCK
 
 # "ELSE" INSTALL...