Merge pull request #2111 from holta/nextcloud-readability

Nextcloud minimal cleanup for code readability

roles/nextcloud/tasks/enable_or_disable.yml

@@ -23,7 +23,7 @@
     state: absent
   when: not nextcloud_enabled and is_redhat
 
-- name: Restart Apache, enabling/disabling http://box/nextcloud
+- name: Restart {{ apache_service }}, enabling/disabling http://box/nextcloud
   systemd:
     name: "{{ apache_service }}"
     daemon-reload: yes

roles/nextcloud/tasks/main.yml

@@ -9,10 +9,10 @@
   include_tasks: install.yml
   when: nextcloud_install and (not nextcloud_installed is defined or not nextcloud_page.stat.exists)
 
-- name: Provision NextCloud's Mysql DB
+- name: Provision Nextcloud's MySQL DB, run Nextcloud's install wizard, etc
   include_tasks: setup.yml
   when: nextcloud_install and not installing
 
-- name: Enables or disable Nextcloud!
+- name: Enable or disable Nextcloud
   include_tasks: enable_or_disable.yml
   when: nextcloud_install or nextcloud_installed is defined

roles/nextcloud/tasks/setup.yml

@@ -14,7 +14,7 @@
     - ::1
     - localhost
 
-# the install wizard does not succeed if already installed
+# The install wizard fails if already installed.
 - name: Determine if Nextcloud is installed
   shell: >
     php {{ nextcloud_prefix }}/nextcloud/occ status |
@@ -37,7 +37,9 @@
   become_user: "{{ apache_user }}"
   when: nextcloud_enabled and returned.stdout == "false"
 
-- name: Allow access from all hosts and ips
+# RELATED: /etc/apache2/sites-available/nextcloud.conf sourced from
+# https://github.com/iiab/iiab/blob/master/roles/nextcloud/templates/nextcloud.conf.j2
+- name: 'Allow Nextcloud access from all hosts and IP addresses (SEE ALSO: /etc/apache2/sites-available/nextcloud.conf)'
   command: php {{ nextcloud_prefix }}/nextcloud/occ config:system:set trusted_domains 1 --value=*
   become: yes
   become_user: "{{ apache_user }}"