Merge pull request #1152 from holta/etckeeper-removal

Remove etckeeper & clean roles/2-common/tasks/packages.yml

roles/2-common/tasks/packages.yml

@@ -14,16 +14,22 @@
     - avahi-tools
   when: is_redhat
 
-- name: Download usbmount -- not in Debian Stretch (debian-9)
-  get_url:
-    url: "{{ iiab_download_url }}/usbmount_0.0.14.1_all.deb"
-    dest: "{{ downloads_dir }}"
-    timeout: "{{ download_timeout }}"
+- name: Download & install usbmount, missing from Debian Stretch (debian-9)
+  apt:
+    deb: "{{ iiab_download_url }}/usbmount_0.0.14.1_all.deb"
+    #timeout: "{{ download_timeout }}"    # Ansible's apt module doesn't support timeout parameter; that's ok as usbmount_0.0.14.1_all.deb is only 10KB
   when: internet_available and is_debian_9
 
-- name: Install usbmount (debian-9)
-  command: apt install -y {{ downloads_dir }}/usbmount_0.0.14.1_all.deb
-  when: is_debian_9
+#- name: Download usbmount -- not in Debian Stretch (debian-9)
+#  get_url:
+#    url: "{{ iiab_download_url }}/usbmount_0.0.14.1_all.deb"
+#    dest: "{{ downloads_dir }}"
+#    timeout: "{{ download_timeout }}"
+#  when: internet_available and is_debian_9
+#
+#- name: Install usbmount (debian-9)
+#  command: apt install -y {{ downloads_dir }}/usbmount_0.0.14.1_all.deb
+#  when: is_debian_9
 
 - name: Install packages (debuntu)
   package:
@@ -48,7 +54,7 @@
     - mlocate
     - rsync
     - htop
-    - etckeeper
+    #- etckeeper    # "nobody is really using etckeeper and it's bloating the filesystem every time apt runs" per @jvonau at https://github.com/iiab/iiab/issues/1146
     - python-passlib
     - usbmount
     - net-tools
@@ -65,7 +71,7 @@
     - usbutils
     - hostapd
     - wget
-    - openssl   #FC 18 does not supply, but pear requires
+    - openssl    # FC 18 does not supply, but pear requires
     - gawk
     - curl
     - pandoc