From 47a78b426c671a399c96fd20153fd1e177b0f4aa Mon Sep 17 00:00:00 2001 From: A Holt Date: Fri, 27 Oct 2017 19:17:51 -0400 Subject: [PATCH 1/4] Ansible output tweak --- roles/2-common/tasks/udev.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/roles/2-common/tasks/udev.yml b/roles/2-common/tasks/udev.yml index 7e55c9f83..7e66a2d93 100644 --- a/roles/2-common/tasks/udev.yml +++ b/roles/2-common/tasks/udev.yml @@ -23,13 +23,12 @@ shell: systemctl daemon-reload when: udev_unit.stat.exists is defined and udev_unit.stat.exists -- name: restart so systemd recognizes the changes +- name: Restart so systemd recognizes the changes shell: systemctl restart systemd-udevd.service when: udev_unit.stat.exists is defined and udev_unit.stat.exists -- name: reload systemd-udevd so it has rootfs open read-write +- name: Reload systemd-udevd so it has rootfs open read-write template: src=udev-reload.service dest=/etc/systemd/system/ -- name: enable the reload service +- name: Enable the reload service shell: systemctl enable udev-reload.service - From f101f87a36d23a20cb7f94fd73b7ef6273c2b95d Mon Sep 17 00:00:00 2001 From: A Holt Date: Fri, 27 Oct 2017 20:13:45 -0400 Subject: [PATCH 2/4] tweaks to cultivate implementers into engaging+understanding more deeply --- roles/mysql/tasks/main.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/roles/mysql/tasks/main.yml b/roles/mysql/tasks/main.yml index e4819172a..2b1a622fe 100644 --- a/roles/mysql/tasks/main.yml +++ b/roles/mysql/tasks/main.yml @@ -1,4 +1,4 @@ - - name: Install MySQL Debian + - name: Install MySQL if Debian/Debuntu package: name={{ item }} state=present with_items: @@ -18,11 +18,11 @@ tags: - download - - name: php-xml for ubuntu and debian-9 + - name: php-xml for 'ubuntu' and 'debian-9' package: name=php{{ php_version }}-xml state=present when: is_ubuntu or is_debian_9 - - name: php-xml for debian-8 + - name: php-xml for 'debian-8' package: name=php-xml-parser state=present when: is_debian_8 @@ -78,7 +78,7 @@ template: src=my.cnf.j2 dest=/root/.my.cnf owner=root mode=0600 when: mysql_enabled - - name: Update mysql root password for all remaining root accounts + - name: Update MySQL root password for all remaining root accounts mysql_user: name=root host={{ item }} password={{ mysql_root_password }} priv=*.*:ALL,GRANT with_items: # - "{{ iiab_hostname }}.{{ iiab_domain }}" @@ -106,7 +106,7 @@ when: not mysql_enabled - - name: Add mysql to service list + - name: Add 'mysql' to service list ini_file: dest='{{ service_filelist }}' section=mysql option='{{ item.option }}' @@ -115,6 +115,6 @@ - option: name value: mysql-database - option: description - value: '"MySQL is a widely used database service on the Internet which runs on many platforms, and is often offered and available at hosting Internet Service Providers"' + value: '"MySQL is a widely used free and open source (GPLv2) database, offered by most web hosting services, on a diversity of platforms."' - option: enabled value: "{{ mysql_enabled }}" From 40a0a4063a7b9207bc8174ab8053b919de7a0a57 Mon Sep 17 00:00:00 2001 From: A Holt Date: Fri, 27 Oct 2017 20:17:40 -0400 Subject: [PATCH 3/4] Update main.yml --- roles/mysql/tasks/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/roles/mysql/tasks/main.yml b/roles/mysql/tasks/main.yml index 2b1a622fe..7ae2cfad6 100644 --- a/roles/mysql/tasks/main.yml +++ b/roles/mysql/tasks/main.yml @@ -1,4 +1,4 @@ - - name: Install MySQL if Debian/Debuntu + - name: Install MySQL for Debian/Debuntu package: name={{ item }} state=present with_items: @@ -26,7 +26,7 @@ package: name=php-xml-parser state=present when: is_debian_8 - - name: Install MySQL + - name: Install MySQL for non-Debian/Debuntu package: name={{ item }} state=present with_items: From e2a8b090143821930680c0aa16023254bd173a4e Mon Sep 17 00:00:00 2001 From: A Holt Date: Fri, 27 Oct 2017 20:56:48 -0400 Subject: [PATCH 4/4] tweaks for understandability --- roles/monit/tasks/main.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/roles/monit/tasks/main.yml b/roles/monit/tasks/main.yml index 26a3c2a7f..e57ee7c39 100644 --- a/roles/monit/tasks/main.yml +++ b/roles/monit/tasks/main.yml @@ -1,10 +1,10 @@ -- name: Install monit package +- name: Install Monit package package: name=monit state=present tags: - download -- name: Install chkconfig package -- not in debian 9 +- name: Install chkconfig package -- not in Debian 8 package: name=chkconfig state=present when: is_debian and ansible_distribution_major_version == "8" @@ -34,14 +34,14 @@ delay: 1 #TODO: create systemd script -- name: Enable monit service +- name: Enable 'monit' service command: chkconfig monit on when: is_debian and ansible_local.local_facts.os_ver == "debian-8" #- name: Restart monit service # command: service monit restart -- name: Add monit to service list +- name: Add 'monit' to service list ini_file: dest='{{ service_filelist }}' section=monit option='{{ item.option }}' @@ -50,6 +50,6 @@ - option: name value: monit - option: description - value: '"Monit is a background service monitor which can correct problems, send email, restart services"' + value: '"Monit is a background service monitor which can correct problems, send email, restart services."' - option: enabled value: "{{ monit_enabled }}"