Merge pull request #2128 from holta/ansible-str-warns-and-state-file

Avoid iiab.ini Ansible warnings by using "{{ item.value | string }}"

roles/0-init/tasks/iiab_ini.yml

@@ -9,7 +9,7 @@
     path: "{{ iiab_ini_file }}"
     section: location
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: iiab_base
       value: "{{ iiab_base }}"
@@ -21,7 +21,7 @@
     path: "{{ iiab_ini_file }}"
     section: version
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: distribution
       value: "{{ ansible_distribution }}"

roles/0-init/tasks/main.yml

@@ -189,7 +189,7 @@
     dest: "{{ iiab_ini_file }}"
     section: runtime
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: iiab_stage
       value: "{{ iiab_stage }}"
@@ -237,7 +237,7 @@
     dest: "{{ iiab_ini_file }}"
     section: runtime
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: is_VM
       value: "yes"

roles/2-common/tasks/xo.yml

@@ -60,9 +60,9 @@
     dest: /etc/NetworkManager/system-connections/"Sugar Modem Connection"
     section: ppp
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value }}"    # "{{ item.value | string }}" not nec, as they're already strings.
     backup: yes
-    mode: 0600
+    mode: '0600'
   with_items:
     - { option: 'lcp-echo-failure', value: '5' }
     - { option: 'lcp-echo-interval', value: '30' }

roles/activity-server/tasks/main.yml

@@ -122,7 +122,7 @@
     path: "{{ iiab_ini_file }}"
     section: activity-server
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: "Activity Server"

roles/ajenti/tasks/main.yml

@@ -52,7 +52,7 @@
     path: "{{ iiab_ini_file }}"
     section: ajenti
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: ajenti

roles/authserver/tasks/main.yml

@@ -55,7 +55,7 @@
     path: "{{ iiab_ini_file }}"
     section: authserver
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: XS-authserver

roles/awstats/tasks/enable.yml

@@ -46,7 +46,7 @@
     path: "{{ iiab_ini_file }}"
     section: awstats
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: AWStats

roles/bluetooth/tasks/enable.yml

@@ -61,7 +61,7 @@
     path: "{{ iiab_ini_file }}"
     section: bluetooth
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Bluetooth

roles/calibre-web/tasks/enable.yml

@@ -60,7 +60,7 @@
     path: "{{ iiab_ini_file }}"
     section: calibre-web
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: calibre-web

roles/calibre/tasks/enable.yml

@@ -38,7 +38,7 @@
     path: "{{ iiab_ini_file }}"
     section: calibre
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
   - option: name
     value: Calibre

roles/cups/tasks/main.yml

@@ -74,7 +74,7 @@
     path: "{{ iiab_ini_file }}"
     section: cups
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: CUPS

roles/docker/tasks/main.yml

@@ -45,7 +45,7 @@
     path: "{{ iiab_ini_file }}"
     section: docker
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Docker Container

roles/dokuwiki/tasks/enable.yml

@@ -22,7 +22,7 @@
     path: "{{ iiab_ini_file }}"
     section: dokuwiki
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: DokuWiki

roles/elgg/tasks/enable.yml

@@ -27,7 +27,7 @@
     path: "{{ iiab_ini_file }}"
     section: elgg
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Elgg

roles/gitea/tasks/enable.yml

@@ -61,7 +61,7 @@
     dest: "{{ iiab_ini_file }}"
     section: gitea
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: gitea

roles/idmgr/tasks/main.yml

@@ -84,7 +84,7 @@
     path: "{{ iiab_ini_file }}"
     section: idmgr
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: idmgr

roles/iiab-admin/tasks/main.yml

@@ -12,7 +12,7 @@
     dest: "{{ iiab_ini_file }}"
     section: iiab-admin
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: iiab-admin

roles/internetarchive/tasks/enable.yml

@@ -37,7 +37,7 @@
     path: "{{ iiab_ini_file }}"
     section: internetarchive
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Internet Archive Offline

roles/kalite/tasks/enable.yml

@@ -43,7 +43,7 @@
     path: "{{ iiab_ini_file }}"
     section: kalite
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
   - option: name
     value: "KA Lite"

roles/kiwix/tasks/kiwix_enable.yml

@@ -70,7 +70,7 @@
     path: "{{ iiab_ini_file }}"
     section: kiwix
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
   - option: name
     value: Kiwix

roles/kolibri/tasks/enable.yml

@@ -52,7 +52,7 @@
     path: "{{ iiab_ini_file }}"
     section: kolibri
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: kolibri

roles/lokole/tasks/enable.yml

@@ -49,7 +49,7 @@
     path: "{{ iiab_ini_file }}"
     section: lokole
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: lokole

roles/mediawiki/tasks/enable.yml

@@ -40,7 +40,7 @@
     path: "{{ iiab_ini_file }}"
     section: mediawiki
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: mediawiki

roles/minetest/tasks/enable.yml

@@ -20,7 +20,7 @@
     path: "{{ iiab_ini_file }}"
     section: minetest
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Minetest Server

roles/mongodb/tasks/enable.yml

@@ -27,7 +27,7 @@
     path: "{{ iiab_ini_file }}"
     section: mongodb
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: MongoDB

roles/monit/tasks/install.yml

@@ -49,7 +49,7 @@
     path: "{{ iiab_ini_file }}"
     section: monit
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Monit

roles/moodle-1.9/moodle/tasks/main.yml

@@ -80,7 +80,7 @@
     path: "{{ iiab_ini_file }}"
     section: moodle
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Moodle

roles/moodle/tasks/enable.yml

@@ -22,7 +22,7 @@
     path: "{{ iiab_ini_file }}"
     section: moodle
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Moodle

roles/mosquitto/tasks/enable.yml

@@ -11,7 +11,7 @@
     path: "{{ iiab_ini_file }}"
     section: mosquitto
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Mosquitto service

roles/munin/tasks/enable.yml

@@ -55,7 +55,7 @@
     path: "{{ iiab_ini_file }}"
     section: munin
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Munin

roles/mysql/tasks/main.yml

@@ -187,7 +187,7 @@
     path: "{{ iiab_ini_file }}"
     section: mysql
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: MySQL

roles/network/tasks/computed_network.yml

@@ -197,7 +197,7 @@
     dest: "{{ iiab_ini_file }}"
     section: computed_network
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
   - option: iiab_wan_enabled
     value: "{{ iiab_wan_enabled }}"

roles/network/tasks/computed_services.yml

@@ -54,7 +54,7 @@
     dest: "{{ iiab_ini_file }}"
     section: network
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
   - option: dansguardian_enabled
     value: "{{ dansguardian_enabled }}"

roles/network/tasks/detected_network.yml

@@ -193,7 +193,7 @@
     dest: "{{ iiab_ini_file }}"
     section: detected_network
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
   - option: has_ifcfg_gw
     value: "{{ has_ifcfg_gw }}"

roles/network/tasks/enable_services.yml

@@ -206,7 +206,7 @@
     path: "{{ iiab_ini_file }}"
     section: squid
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: enabled
       value: "{{ squid_enabled }}"
@@ -216,7 +216,7 @@
     path: "{{ iiab_ini_file }}"
     section: dansguardian
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: enabled
       value: "{{ dansguardian_enabled }}"
@@ -226,7 +226,7 @@
     path: "{{ iiab_ini_file }}"
     section: wondershaper
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: enabled
       value: "{{ wondershaper_enabled }}"

roles/network/tasks/squid.yml

@@ -95,7 +95,7 @@
     dest: "{{ iiab_ini_file }}"
     section: "{{ proxy }}"
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Squid
@@ -109,7 +109,7 @@
     dest: "{{ iiab_ini_file }}"
     section: dansguardian
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: DansGuardian

roles/network/tasks/wondershaper.yml

@@ -50,7 +50,7 @@
     dest: "{{ iiab_ini_file }}"
     section: wondershaper
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: wondershaper

roles/nextcloud/tasks/enable.yml

@@ -34,7 +34,7 @@
     path: "{{ iiab_ini_file }}"
     section: Nextcloud
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Nextcloud

roles/nextcloud/tasks/main.yml

@@ -14,5 +14,5 @@
   when: nextcloud_install and not installing
 
 - name: Enable or disable Nextcloud
-  include_tasks: enable_or_disable.yml
+  include_tasks: enable.yml
   when: nextcloud_install or nextcloud_installed is defined

roles/nodered/tasks/enable.yml

@@ -40,7 +40,7 @@
     path: "{{ iiab_ini_file }}"
     section: nodered
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Node-RED

roles/nodogsplash/tasks/rpi.yml

@@ -57,7 +57,7 @@
     path: "{{ iiab_ini_file }}"
     section: nodogsplash
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: nodogsplash

roles/openvpn/tasks/main.yml

@@ -204,7 +204,7 @@
     path: "{{ iiab_ini_file }}"
     section: openvpn
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
   - option: name
     value: OpenVPN

roles/osm/tasks/main.yml

@@ -177,7 +177,7 @@
     path: "{{ iiab_ini_file }}"
     section: osm
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
   - option: name
     value: OpenStreetMap

roles/owncloud/tasks/main.yml

@@ -110,7 +110,7 @@
     path: "{{ iiab_ini_file }}"
     section: owncloud
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: owncloud

roles/pathagar/tasks/main.yml

@@ -198,7 +198,7 @@
     path: "{{ iiab_ini_file }}"
     section: pathagar
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: pathagar

roles/phpmyadmin/tasks/main.yml

@@ -70,7 +70,7 @@
     path: "{{ iiab_ini_file }}"
     section: phpmyadmin
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: phpMyAdmin

roles/postgresql/tasks/main.yml

@@ -105,7 +105,7 @@
     path: "{{ iiab_ini_file }}"
     section: postgresql
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: PostgreSQL

roles/rachel/tasks/main.yml

@@ -28,7 +28,7 @@
     path: "{{ iiab_ini_file }}"
     section: rachel
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: rachel

roles/samba/tasks/main.yml

@@ -78,7 +78,7 @@
     path: "{{ iiab_ini_file }}"
     section: samba
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Samba

roles/schooltool/tasks/main.yml

@@ -60,7 +60,7 @@
     path: "{{ iiab_ini_file }}"
     section: schooltool
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Schooltool

roles/sugar-stats/tasks/main.yml

@@ -45,7 +45,7 @@
     path: "{{ iiab_ini_file }}"
     section: sugar_stats
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: sugar_stats

roles/sugarizer/tasks/enable.yml

@@ -76,7 +76,7 @@
     path: "{{ iiab_ini_file }}"
     section: sugarizer
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: Sugarizer

roles/teamviewer/tasks/main.yml

@@ -13,7 +13,7 @@
     path: "{{ iiab_ini_file }}"
     section: teamviewer
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: teamviewer

roles/transmission/tasks/main.yml

@@ -58,7 +58,7 @@
     path: "{{ iiab_ini_file }}"
     section: transmission
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: transmission

roles/usb-lib/tasks/main.yml

@@ -89,7 +89,7 @@
     path: "{{ iiab_ini_file }}"
     section: usb-lib
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: usb-lib

roles/vnstat/tasks/main.yml

@@ -31,7 +31,7 @@
     path: "{{ iiab_ini_file }}"
     section: vnstat
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: vnStat

roles/wordpress/tasks/enable.yml

@@ -21,7 +21,7 @@
     path: "{{ iiab_ini_file }}"
     section: wordpress
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: WordPress

roles/xovis/tasks/main.yml

@@ -86,7 +86,7 @@
     path: "{{ iiab_ini_file }}"
     section: xovis
     option: "{{ item.option }}"
-    value: "{{ item.value }}"
+    value: "{{ item.value | string }}"
   with_items:
     - option: name
       value: xovis