From fec4019d9f2e4f2536b6caa494baeefbe2469e2e Mon Sep 17 00:00:00 2001 From: A Holt Date: Tue, 3 Nov 2020 09:02:25 -0500 Subject: [PATCH 1/9] mongodb_port: 27018 -> 27017 per Sugarizer Server rec --- vars/default_vars.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vars/default_vars.yml b/vars/default_vars.yml index c71774088..916dbb88a 100644 --- a/vars/default_vars.yml +++ b/vars/default_vars.yml @@ -485,7 +485,7 @@ mongodb_install: False # misleading as Sugarizer starts mongodb's systemd service on its own, due to # 'Requires=mongodb.service' within /etc/systemd/system/sugarizer.service mongodb_enabled: False -mongodb_port: 27018 +mongodb_port: 27017 # roles/sugarizer/meta/main.yml auto-invokes 2 above prereqs: mongodb & nodejs # Might stall MongoDB on Power Failure: github.com/xsce/xsce/issues/879 From faed221becea73a8bf7fc39dc1e7a36565ceb0ce Mon Sep 17 00:00:00 2001 From: A Holt Date: Tue, 3 Nov 2020 09:02:48 -0500 Subject: [PATCH 2/9] mongodb_port: 27018 -> 27017 per Sugarizer Server rec --- roles/mongodb/defaults/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/mongodb/defaults/main.yml b/roles/mongodb/defaults/main.yml index a96fe6f99..1c54103e7 100644 --- a/roles/mongodb/defaults/main.yml +++ b/roles/mongodb/defaults/main.yml @@ -15,7 +15,7 @@ # mongodb_enabled: False -# mongodb_port: 27018 +# mongodb_port: 27017 # All above are set in: github.com/iiab/iiab/blob/master/vars/default_vars.yml # If nec, change them by editing /etc/iiab/local_vars.yml prior to installing! From c464f83d0b6eef9c8c83fb85981a979a810297d6 Mon Sep 17 00:00:00 2001 From: A Holt Date: Tue, 3 Nov 2020 09:22:01 -0500 Subject: [PATCH 3/9] lineinfile regex for /etc/mongod.conf port change (though 27017 is recommended for most everyone!) --- roles/mongodb/tasks/install.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/roles/mongodb/tasks/install.yml b/roles/mongodb/tasks/install.yml index 71e111b2e..953d8b119 100644 --- a/roles/mongodb/tasks/install.yml +++ b/roles/mongodb/tasks/install.yml @@ -117,8 +117,8 @@ - name: Change {{ mongodb_conf }} port to {{ mongodb_port }} -- takes effect on next (re)start of the service -- via enable-or-disable.yml or via sugarizer.service auto-starting MongoDB on demand lineinfile: path: "{{ mongodb_conf }}" - regexp: "port: 27017" - backrefs: yes + regexp: '^\s*port:' # \s = any whitespace char. stackoverflow.com/a/38491899 + #backrefs: yes line: " port: {{ mongodb_port }}" # 27018 # end block From a58b4e74b93aa07549a40b3700b4283cae212d7f Mon Sep 17 00:00:00 2001 From: A Holt Date: Tue, 3 Nov 2020 09:30:07 -0500 Subject: [PATCH 4/9] Explain mongodb_port in mongod.conf.j2 (template for /etc/mongod.conf) --- roles/mongodb/templates/mongod.conf.j2 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/roles/mongodb/templates/mongod.conf.j2 b/roles/mongodb/templates/mongod.conf.j2 index 9d9c9c9c1..958c4a50e 100644 --- a/roles/mongodb/templates/mongod.conf.j2 +++ b/roles/mongodb/templates/mongod.conf.j2 @@ -5,7 +5,8 @@ # Comma separated list of ip addresses to listen on (all local ips by default) bind_ip = 127.0.0.1 -# Specify port number (27017 by default...but typically 27018 for IIAB) +# Specify port number (27017 by default). Sugarizer Server & IIAB had earlier +# used 27018. https://docs.mongodb.com/manual/reference/default-mongodb-port/ port = {{ mongodb_port }} # Fork server process (false by default) From b28e4fbb8f602484ae87c2937b6d940549ca7d13 Mon Sep 17 00:00:00 2001 From: A Holt Date: Tue, 3 Nov 2020 10:00:45 -0500 Subject: [PATCH 5/9] Comment cleanup in mongodb/tasks/install.yml --- roles/mongodb/tasks/install.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/mongodb/tasks/install.yml b/roles/mongodb/tasks/install.yml index 953d8b119..7612bdbe7 100644 --- a/roles/mongodb/tasks/install.yml +++ b/roles/mongodb/tasks/install.yml @@ -119,7 +119,7 @@ path: "{{ mongodb_conf }}" regexp: '^\s*port:' # \s = any whitespace char. stackoverflow.com/a/38491899 #backrefs: yes - line: " port: {{ mongodb_port }}" # 27018 + line: " port: {{ mongodb_port }}" # 27017 # end block when: (ansible_architecture == "aarch64") or (ansible_architecture == "x86_64") From 822cb816fc473564eda41eef55bebe7c93f0e67c Mon Sep 17 00:00:00 2001 From: A Holt Date: Tue, 3 Nov 2020 10:56:54 -0500 Subject: [PATCH 6/9] mongodb/tasks/install.yml: cleaner mongodb_conf explanation --- roles/mongodb/tasks/install.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/mongodb/tasks/install.yml b/roles/mongodb/tasks/install.yml index 7612bdbe7..3f1eb6578 100644 --- a/roles/mongodb/tasks/install.yml +++ b/roles/mongodb/tasks/install.yml @@ -114,7 +114,7 @@ - mongodb-org-server state: present - - name: Change {{ mongodb_conf }} port to {{ mongodb_port }} -- takes effect on next (re)start of the service -- via enable-or-disable.yml or via sugarizer.service auto-starting MongoDB on demand + - name: Establish {{ mongodb_conf }} port {{ mongodb_port }} (mongodb_conf) -- takes effect on next (re)start of the service -- via enable-or-disable.yml or via sugarizer.service auto-starting MongoDB on demand lineinfile: path: "{{ mongodb_conf }}" regexp: '^\s*port:' # \s = any whitespace char. stackoverflow.com/a/38491899 From d35fba01d80bb48308364739239574eca8e398a6 Mon Sep 17 00:00:00 2001 From: A Holt Date: Tue, 3 Nov 2020 12:00:20 -0500 Subject: [PATCH 7/9] sugarizer/tasks/install.yml: 27018 -> 27017, explain better, lint Ansible regex's (single quote habit, for safety) --- roles/sugarizer/tasks/install.yml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/roles/sugarizer/tasks/install.yml b/roles/sugarizer/tasks/install.yml index f478457ff..5ca212dd2 100644 --- a/roles/sugarizer/tasks/install.yml +++ b/roles/sugarizer/tasks/install.yml @@ -176,7 +176,7 @@ - name: Set Sugarizer port to {{ sugarizer_port }} in /opt/iiab/sugarizer-server/env/sugarizer.ini lineinfile: path: "{{ iiab_base }}/sugarizer-server/env/sugarizer.ini" - regexp: "^port = 8080$" + regexp: '^port = 8080$' line: "port = {{ sugarizer_port }}" # 2019-02-02 No Longer Required thanks to @llaske's upstream fix: @@ -193,15 +193,19 @@ #- name: Set MongoDB "server" from localhost to 127.0.0.1 in /opt/iiab/sugarizer-server/env/sugarizer.ini # lineinfile: # path: "{{ iiab_base }}/sugarizer-server/env/sugarizer.ini" -# regexp: "^server = localhost$" +# regexp: '^server = localhost$' # line: "server = 127.0.0.1" -# mongodb_port is set to 27018 in /opt/iiab/iiab/vars/default_vars.yml -# If you need to change this, edit /etc/iiab/local_vars.yml prior to installing +# mongodb_port is set to 27017 in /opt/iiab/iiab/vars/default_vars.yml +# If you must change this, edit /etc/iiab/local_vars.yml prior to installing +# See also upstream recommendations: +# https://github.com/llaske/sugarizer-server/blob/master/env/sugarizer.ini line ~22 under [database] +# https://docs.mongodb.com/manual/reference/default-mongodb-port/ +# https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.txt - name: Set MongoDB port to {{ mongodb_port }} in /opt/iiab/sugarizer-server/env/sugarizer.ini lineinfile: path: "{{ iiab_base }}/sugarizer-server/env/sugarizer.ini" - regexp: "^port = 27017$" + regexp: '^port = 27017$' # Careful as file also contains 2 other ports! line: "port = {{ mongodb_port }}" # 2-LINE FIX FOR sugarizer.js BY @georgejhunt FOR http://box/sugarizer @@ -211,7 +215,7 @@ - name: For http://box/sugarizer -- add pathPrefix lines in /opt/iiab/sugarizer-server/sugarizer.js lineinfile: path: "{{ iiab_base }}/sugarizer-server/sugarizer.js" - regexp: "AUTO-INSERTED BY IIAB" # avoids inserting it twice! + regexp: 'AUTO-INSERTED BY IIAB' # avoids inserting it twice! insertbefore: "// Start listening$" line: | # SEE https://yaml-multiline.info (use |+ to 'keep' newlines at end...though |8 and |+4 "indentation indicators" don't work with Ansible) // AUTO-INSERTED BY IIAB FOR http://box/sugarizer From a104a01b7ac04487c2475cc1b7edd830e5068870 Mon Sep 17 00:00:00 2001 From: A Holt Date: Tue, 3 Nov 2020 12:05:22 -0500 Subject: [PATCH 8/9] Update mongod.conf.j2 --- roles/mongodb/templates/mongod.conf.j2 | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/roles/mongodb/templates/mongod.conf.j2 b/roles/mongodb/templates/mongod.conf.j2 index 958c4a50e..8d450c508 100644 --- a/roles/mongodb/templates/mongod.conf.j2 +++ b/roles/mongodb/templates/mongod.conf.j2 @@ -5,8 +5,12 @@ # Comma separated list of ip addresses to listen on (all local ips by default) bind_ip = 127.0.0.1 -# Specify port number (27017 by default). Sugarizer Server & IIAB had earlier -# used 27018. https://docs.mongodb.com/manual/reference/default-mongodb-port/ +# mongodb_port is set to 27017 in /opt/iiab/iiab/vars/default_vars.yml +# If you must change this, it's best to edit /etc/iiab/local_vars.yml prior to +# installing IIAB. Please also see upstream recommendations: +# https://github.com/llaske/sugarizer-server/blob/master/env/sugarizer.ini line ~22 under [database] +# https://docs.mongodb.com/manual/reference/default-mongodb-port/ +# https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.txt port = {{ mongodb_port }} # Fork server process (false by default) From 61f00f219838526c4344f9d14086fc3cc8c231b4 Mon Sep 17 00:00:00 2001 From: A Holt Date: Tue, 3 Nov 2020 12:07:40 -0500 Subject: [PATCH 9/9] sugarizer/tasks/install.yml: Explain mongodb_port context --- roles/sugarizer/tasks/install.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/roles/sugarizer/tasks/install.yml b/roles/sugarizer/tasks/install.yml index 5ca212dd2..ac490d70e 100644 --- a/roles/sugarizer/tasks/install.yml +++ b/roles/sugarizer/tasks/install.yml @@ -197,8 +197,8 @@ # line: "server = 127.0.0.1" # mongodb_port is set to 27017 in /opt/iiab/iiab/vars/default_vars.yml -# If you must change this, edit /etc/iiab/local_vars.yml prior to installing -# See also upstream recommendations: +# If you must change this, it's best to edit /etc/iiab/local_vars.yml prior to +# installing IIAB. Please also see upstream recommendations: # https://github.com/llaske/sugarizer-server/blob/master/env/sugarizer.ini line ~22 under [database] # https://docs.mongodb.com/manual/reference/default-mongodb-port/ # https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.txt