From 388603c0722bee246118b5bb7279411ce2419630 Mon Sep 17 00:00:00 2001 From: A Holt Date: Sun, 26 Nov 2017 15:36:12 -0500 Subject: [PATCH] stale comments removed (chown tested as unnec) --- roles/kiwix/tasks/kiwix_install.yml | 22 +++------------------- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/roles/kiwix/tasks/kiwix_install.yml b/roles/kiwix/tasks/kiwix_install.yml index 7c598b461..28f20a615 100644 --- a/roles/kiwix/tasks/kiwix_install.yml +++ b/roles/kiwix/tasks/kiwix_install.yml @@ -60,7 +60,7 @@ # 2. INSTALL KIWIX-TOOLS EXECUTABLES IF kiwix_force_install # (We get a whole web server for i686 but only kiwix execs for linux64 & armhf) -- name: Unarchive Kiwix to permanent location (bin_only, i.e. not i686) +- name: Unarchive Kiwix to permanent location (bin_only, i.e. NOT i686) unarchive: src: "{{ downloads_dir }}/{{ kiwix_src_file }}" dest: "{{ iiab_base }}/kiwix/bin" @@ -68,11 +68,7 @@ group: root when: kiwix_src_bin_only and kiwix_force_install -# EXPERIMENTAL i686 CODE PATH: as of Nov 2017 bunzip2 then untar unpacks -# to /tmp/kiwix-0.10-i686/bin WHOSE CONTENTS NEEDS TO BE MOVED TO -# /opt/iiab/kiwix/bin (STANZA FURTHER BELOW). All i686 code needs testing. -# ALSO: code below may need to be revived to chown -R root:root & chmod -- name: Unarchive kiwix*i686.tar.bz2 to /tmp (not bin_only, i.e. i686) +- name: Unarchive kiwix*i686.tar.bz2 to /tmp (NOT bin_only, i.e. i686) unarchive: src: "{{ downloads_dir }}/{{ kiwix_src_file }}" dest: /tmp @@ -81,22 +77,10 @@ group: root when: not kiwix_src_bin_only and kiwix_force_install -# EXPERIMENTAL i686 CODE PATH -- name: Move /tmp/kiwix*i686/bin/* to permanent location /opt/iiab/kiwix/bin (not bin_only, i.e. i686) +- name: Move /tmp/kiwix*i686/bin/* to permanent location /opt/iiab/kiwix/bin (NOT bin_only, i.e. i686) shell: "mv /tmp/kiwix*i686/bin/* /opt/iiab/kiwix/bin/" when: not kiwix_src_bin_only and kiwix_force_install -# MIGHT BE RESTORED LATER FOR i686? Unused as of Nov 2017: -# # workaround because unarchive does not set ownership properly -# - name: "Set ownership as if: 'chown -R root:root /opt/iiab/kiwix'" -# file: -# path: "{{ iiab_base }}/kiwix" -# owner: root -# group: root -# recurse: yes -# mode: ???? -# when: kiwix_force_install - # 3. ENABLE MODS FOR APACHE PROXY IF DEBUNTU - name: Enable the mods which permit Apache to proxy (debuntu)