From 86aa6a8c43fd49eecb0ee44c58c8be331384ecbd Mon Sep 17 00:00:00 2001 From: A Holt Date: Wed, 28 Mar 2018 14:00:10 -0400 Subject: [PATCH 1/3] English grammar --- roles/1-prep/templates/iiab.env.j2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/1-prep/templates/iiab.env.j2 b/roles/1-prep/templates/iiab.env.j2 index cca28cc1e..49458cd9b 100644 --- a/roles/1-prep/templates/iiab.env.j2 +++ b/roles/1-prep/templates/iiab.env.j2 @@ -1,5 +1,5 @@ # This is a configuration file for IIAB -# It can sourced in a shell script or read into an application +# It can be sourced in a shell script or read into an application IIAB_BASE_PATH={{ iiab_base }} IIAB_DIR={{ iiab_dir }} IIAB_RELEASE={{ iiab_base_ver }} From 6e9fbdaf3a135b92ee63109d20ea0d2ad87c0f7f Mon Sep 17 00:00:00 2001 From: A Holt Date: Wed, 28 Mar 2018 14:01:59 -0400 Subject: [PATCH 2/3] runtags cleanup/refactoring --- runtags | 48 ++++++++++++++++++++++-------------------------- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/runtags b/runtags index 9c4de08a3..2c6e3f7c4 100755 --- a/runtags +++ b/runtags @@ -1,19 +1,19 @@ #!/bin/bash -# running from a git repo -PLAYBOOK="iiab.yml" + INVENTORY="ansible_hosts" +PLAYBOOK="iiab.yml" +#PLAYBOOK="iiab-stages.yml" CWD=`pwd` export ANSIBLE_LOG_PATH="$CWD/iiab-debug.log" -if [ ! -f $PLAYBOOK ] -then - echo "IIAB Playbook not found." - echo "Please run this command from the top level of the git repo." - echo "Exiting." - exit +if [ ! -f $PLAYBOOK ]; then + echo "Exiting: IIAB Playbook not found." + echo "Please run this in /opt/iiab/iiab (top level of the git repo)." + exit 1 fi +# Is the following stanza nec? if [ ! -f /etc/iiab/config_vars.yml ]; then mkdir -p /etc/iiab echo "{}" > /etc/iiab/config_vars.yml @@ -21,31 +21,27 @@ fi tags=$(echo $1 | tr "," "\n") -if [ "$tags" == "" ] -then - echo " usage: ./runtags " - echo " usage: ./runtags ,," - echo " Can take a single value or a comma-separated list (no spaces within the list!)" - echo " Now retrieving a list of possible Ansible playbook and tagname values..." - ansible-playbook -i ansible_hosts iiab.yml --connection=local --list-tag - exit 0 +if [ "$tags" == "" ]; then + echo " usage: ./runtags " + echo " usage: ./runtags ,," + echo " Can take a single value or a comma-separated list (no spaces within the list!)" + echo " Now retrieving a list of possible Ansible playbook and tagname values..." + ansible-playbook -i $INVENTORY $PLAYBOOK --connection=local --list-tags + exit 0 fi found="N" -for tag in $tags -do - if [ "$tag" == "0-init" ] - then - found="Y" - fi +for tag in $tags; do + if [ "$tag" == "0-init" ]; then + found="Y" + fi done taglist=$1 -if [ "$found" == "N" ] -then - taglist="0-init,"$taglist +if [ "$found" == "N" ]; then + taglist="0-init,"$taglist fi -ansible-playbook -i ansible_hosts iiab.yml --connection=local --tags="""$taglist""" +ansible-playbook -i $INVENTORY $PLAYBOOK --connection=local --tags=$taglist From fc758c950be3985e2e7188eb86bd091e77077748 Mon Sep 17 00:00:00 2001 From: Jerry Vonau Date: Thu, 29 Mar 2018 10:11:21 -0500 Subject: [PATCH 3/3] delay usbmount's actions during boot to be as late as possible --- roles/usb-lib/templates/usbmount@.service.j2 | 1 + 1 file changed, 1 insertion(+) diff --git a/roles/usb-lib/templates/usbmount@.service.j2 b/roles/usb-lib/templates/usbmount@.service.j2 index 8ee5cb632..513d4fb08 100644 --- a/roles/usb-lib/templates/usbmount@.service.j2 +++ b/roles/usb-lib/templates/usbmount@.service.j2 @@ -1,6 +1,7 @@ [Unit] BindTo=%i.device After=%i.device +After=rc-local.service [Service] Type=oneshot