From 1884f484aeb35e370f792b7fc675bf46878418b4 Mon Sep 17 00:00:00 2001
From: Jerry Vonau <jvonau3@gmail.com>
Date: Thu, 27 Apr 2023 10:40:04 -0500
Subject: [PATCH] iiab-clone-wifi needs template from hostapd - record
 wifi_up_down

---
 roles/network/tasks/hostapd.yml          | 14 ++++++++++++++
 roles/network/tasks/restart.yml          | 18 ++++++------------
 roles/network/tasks/rpi_debian.yml       |  6 ------
 roles/network/tasks/sysd-netd-debian.yml |  7 -------
 4 files changed, 20 insertions(+), 25 deletions(-)

diff --git a/roles/network/tasks/hostapd.yml b/roles/network/tasks/hostapd.yml
index 7f732f73f..4d64bf843 100644
--- a/roles/network/tasks/hostapd.yml
+++ b/roles/network/tasks/hostapd.yml
@@ -100,6 +100,18 @@
     line: 'HOSTAPD_ENABLED={{ hostapd_enabled }}'
     state: present
 
+- name: Create /etc/hostapd/hostapd.conf and backup .iiab from template if needed
+  template:
+    owner: root
+    group: root
+    mode: 0644
+    src: "{{ item.src }}"
+    dest: "{{ item.dest }}"
+  with_items:
+    - { src: 'hostapd/hostapd.conf.j2', dest: '/etc/hostapd/hostapd.conf' }
+    - { src: 'hostapd/hostapd.conf.j2', dest: '/etc/hostapd/hostapd.conf.iiab' }
+  when: can_be_ap
+
 - name: Record host_country_code_applied and host_channel in network of {{ iiab_ini_file }}
   ini_file:
     dest: "{{ iiab_ini_file }}"    # /etc/iiab/iiab.ini
@@ -113,6 +125,8 @@
       value: "{{ host_ssid }}"
     - option: host_wifi_mode
       value: "{{ host_wifi_mode }}"
+    - option: wifi_up_down
+      value: "{{ wifi_up_down }}"
     - option: host_country_code_applied
       value: "{{ host_country_code }}"
     - option: host_channel
diff --git a/roles/network/tasks/restart.yml b/roles/network/tasks/restart.yml
index 0d33f210f..ec1dda7b6 100644
--- a/roles/network/tasks/restart.yml
+++ b/roles/network/tasks/restart.yml
@@ -14,18 +14,6 @@
     - wpa_supplicant
   when: wifi_up_down and hostapd_enabled
 
-- name: Create /etc/hostapd/hostapd.conf and backup .iiab from template if needed
-  template:
-    owner: root
-    group: root
-    mode: 0644
-    src: "{{ item.src }}"
-    dest: "{{ item.dest }}"
-  with_items:
-    - { src: 'hostapd/hostapd.conf.j2', dest: '/etc/hostapd/hostapd.conf' }
-    - { src: 'hostapd/hostapd.conf.j2', dest: '/etc/hostapd/hostapd.conf.iiab' }
-  when: can_be_ap
-
 - name: Enable & Restart networkd-dispatcher.service
   systemd:
     name: networkd-dispatcher
@@ -34,6 +22,12 @@
     masked: no
   when: systemd_networkd_active
 
+- name: Clone wifi if needed
+  systemd:
+    name: iiab-clone-wifi
+    state: restarted
+  when: wifi_up_down and can_be_ap and ansible_ap0 is undefined
+
 - name: Restart hostapd when WiFi is present but not when using WiFi as gateway with wifi_up_down False
   systemd:
     name: hostapd
diff --git a/roles/network/tasks/rpi_debian.yml b/roles/network/tasks/rpi_debian.yml
index 247b969df..fc02dccd7 100644
--- a/roles/network/tasks/rpi_debian.yml
+++ b/roles/network/tasks/rpi_debian.yml
@@ -78,12 +78,6 @@
   systemd:
     daemon_reload: yes
 
-- name: Clone wifi if needed
-  systemd:
-    name: iiab-clone-wifi
-    state: restarted
-  when: wifi_up_down and can_be_ap and ansible_ap0 is undefined
-
 - name: Restart the networking service if appropriate
   systemd:
     name: networking
diff --git a/roles/network/tasks/sysd-netd-debian.yml b/roles/network/tasks/sysd-netd-debian.yml
index 1681f6cf7..391494382 100644
--- a/roles/network/tasks/sysd-netd-debian.yml
+++ b/roles/network/tasks/sysd-netd-debian.yml
@@ -87,12 +87,6 @@
   systemd:
     daemon_reload: yes
 
-- name: Clone wifi if needed
-  systemd:
-    name: iiab-clone-wifi
-    state: restarted
-  when: wifi_up_down and can_be_ap and ansible_ap0 is undefined
-
 - name: Enable & Restart systemd-networkd.service
   systemd:
     name: systemd-networkd
@@ -106,4 +100,3 @@
     state: restarted
     enabled: yes
     masked: no
-