Merge pull request #2549 from holta/validate_vars-minus-ancients

Further deprecate long-unmaintained roles for IIAB 7.2 release

roles/0-init/tasks/validate_vars.yml

@@ -37,45 +37,54 @@
 # I want to perform input validation for Ansible playbooks"
 # https://stackoverflow.com/questions/46664127/how-do-i-fail-a-task-in-ansible-if-the-variable-contains-a-boolean-value-i-want/46667499#46667499
 
-# 2020-01-23: checks 53 + 53 + up-to-53 vars...for now...expect this to change!
+# 2020-01-23: Checks 53 + 53 + up-to-53 vars...for now...expect this to change!
-# Should we remove {xo_services, activity_server, ejabberd_xs, idmgr} as these
+# 2020-09-26: Commented out 14 vars that are {mandatory, dependencies, or
-# are officially now UNMAINTAINED in default_vars.yml and
+# unmaintained-for-years} for IIAB 7.2 release.  Keeping in mind that vars
-# https://github.com/iiab/iiab/blob/master/unmaintained-roles.txt etc?
+# will come and go as IIAB evolves, let's try to keep these 9 aligned:
+#
+# http://FAQ.IIAB.IO > "What services (IIAB apps) are suggested during installation?"
+# https://github.com/iiab/iiab/blob/master/vars/local_vars_min.yml
+# https://github.com/iiab/iiab/blob/master/vars/local_vars_medium.yml
+# https://github.com/iiab/iiab/blob/master/vars/local_vars_big.yml
+# https://github.com/iiab/iiab/blob/master/vars/default_vars.yml
+# https://github.com/iiab/iiab/blob/master/unmaintained-roles.txt
+# https://github.com/iiab/iiab/blob/master/roles/0-DEPRECATED-ROLES/
+# https://github.com/iiab/iiab/blob/master/tests/test.yml
+# https://github.com/iiab/iiab/blob/master/roles/0-init/tasks/validate_vars.yml
 
-- name: Set vars_checklist for 47 + 47 + up-to-47 vars ("XYZ_install" + "XYZ_enabled" + "XYZ_installed") to be checked
+- name: Set vars_checklist for 40 + 40 + up-to-40 vars ("XYZ_install" + "XYZ_enabled" + "XYZ_installed") to be checked
   set_fact:
     vars_checklist:
       - hostapd
       - dhcpd
       - named
       - dnsmasq
-      - captiveportal
       - bluetooth
-      - wondershaper
+      #- wondershaper       # Unmaintained
       - sshd
       - openvpn
-      - admin_console
+      - admin_console       # Coming soon
       #- nginx              # MANDATORY
-      #- apache    # Dependency installed on demand, by other apps/services
+      #- apache             # Dependency installed on demand by other apps/svcs
       #- mysql              # MANDATORY
       - squid
       - dansguardian
       - cups
       - samba
       - usb_lib
-      - xo_services
+      #- xo_services        # Unmaintained
-      - activity_server
+      #- activity_server    # Unmaintained
-      - ejabberd_xs
+      #- ejabberd_xs        # Unmaintained
-      - idmgr
+      #- idmgr              # Unmaintained
       - azuracast
-      - dokuwiki
+      #- dokuwiki           # Unmaintained
-      - ejabberd
+      #- ejabberd           # Unmaintained
       - elgg
       - gitea
       - lokole
       - mediawiki
       - mosquitto
-      #- nodejs    # Dependency installed on demand, by other apps/services
+      #- nodejs             # Dependency installed on demand by other apps/svcs
       - nodered
       - nextcloud
       - pbx
@@ -83,9 +92,9 @@
       - kalite
       - kolibri
       - kiwix
-      #- postgresql    # Dependency installed on demand, by other apps/services
+      #- postgresql         # Dependency installed on demand by other apps/svcs
       - moodle
-      #- mongodb    # Dependency installed on demand, by other apps/services
+      #- mongodb            # Dependency installed on demand by other apps/svcs
       - sugarizer
       - osm_vector_maps
       - transmission
@@ -94,8 +103,9 @@
       - munin
       - phpmyadmin
       - vnstat
-      #- yarn    # Dependency installed on demand, by other apps/services
+      #- yarn               # Dependency installed on demand by other apps/svcs
       - internetarchive
+      - captiveportal
       - minetest
       - calibre
       - calibreweb

tests/test.yml

@@ -80,5 +80,14 @@
     - { role: yarn }
     #- { roles: xovis }
 
-# Let's try to keep the above list synchronized with:
+# Let's try to keep these 9 aligned:
+#
+# http://FAQ.IIAB.IO > "What services (IIAB apps) are suggested during installation?"
+# https://github.com/iiab/iiab/blob/master/vars/local_vars_min.yml
+# https://github.com/iiab/iiab/blob/master/vars/local_vars_medium.yml
+# https://github.com/iiab/iiab/blob/master/vars/local_vars_big.yml
+# https://github.com/iiab/iiab/blob/master/vars/default_vars.yml
 # https://github.com/iiab/iiab/blob/master/unmaintained-roles.txt
+# https://github.com/iiab/iiab/blob/master/roles/0-DEPRECATED-ROLES/
+# https://github.com/iiab/iiab/blob/master/tests/test.yml
+# https://github.com/iiab/iiab/blob/master/roles/0-init/tasks/validate_vars.yml

unmaintained-roles.txt

@@ -6,6 +6,8 @@ docker
 dokuwiki
 ejabberd
 ejabberd_xs
+homepage
+httpd-enable
 idmgr
 moodle-1.9
 nodogsplash