Merge pull request #2901 from holta/asterisk-lint

Lint pbx/tasks/asterisk.yml to a common baseline, as Apache extrication/isolation work continues

roles/pbx/tasks/asterisk.yml

@@ -19,12 +19,12 @@
   when: not asterisk_src.stat.exists
 
 - name: Asterisk - Create install source directory
-  file: 
+  file:
     path: "{{ asterisk_src_dir }}"
     state: directory
 
 - name: Asterisk - Extract source
-  unarchive: 
+  unarchive:
     src: "{{ downloads_dir }}/{{ asterisk_src_file }}"
     dest: "{{ asterisk_src_dir }}"
     owner: root
@@ -33,52 +33,52 @@
     creates: "{{ asterisk_src_dir }}/Makefile"
 
 - name: Asterisk - Download mp3 decoder library into source tree
-  command: "./contrib/scripts/get_mp3_source.sh"
+  command: ./contrib/scripts/get_mp3_source.sh
   args:
     chdir: "{{ asterisk_src_dir }}"
-    creates: "addons/mp3/mpg123.h"
+    creates: addons/mp3/mpg123.h
 
 - name: Asterisk - Install aptitude (otherwise install_prereq fails?)
-  package: 
+  package:
     name: aptitude
     state: latest
 
 - name: Asterisk - Ensure all dependencies are resolved - CAN TAKE 5 MIN OR LONGER!
-  shell: export DEBIAN_FRONTEND=noninteractive && ./contrib/scripts/install_prereq install 
+  shell: export DEBIAN_FRONTEND=noninteractive && ./contrib/scripts/install_prereq install
   args:
     chdir: "{{ asterisk_src_dir }}"
 
 - name: Asterisk - Run the configure script
-  command: "./configure --with-jansson-bundled"
+  command: ./configure --with-jansson-bundled
   args:
     chdir: "{{ asterisk_src_dir }}"
 
 - name: Asterisk - Run make menuselect.makeopts
-  command: "make menuselect.makeopts"
+  command: make menuselect.makeopts
   args:
     chdir: "{{ asterisk_src_dir }}"
-    creates: "menuselect.makeopts"  
+    creates: menuselect.makeopts
 
 - name: Asterisk - Do a bit of menuselect configuration
   command: >
     menuselect/menuselect --enable app_macro --enable format_mp3
     --enable CORE-SOUNDS-EN-WAV --enable CORE-SOUNDS-EN-G722
     --enable EXTRA-SOUNDS-EN-WAV --enable EXTRA-SOUNDS-EN-G722 --enable EXTRA-SOUNDS-EN-GSM
-    --disable-category MENUSELECT_MOH        
+    --disable-category MENUSELECT_MOH
   args:
     chdir: "{{ asterisk_src_dir }}"
 
 - name: Asterisk - Run 'make' - CAN TAKE 30 MIN OR LONGER!
-  command: make 
+  command: make
   args:
     chdir: "{{ asterisk_src_dir }}"
-    creates: "defaults.h"
+    creates: defaults.h
 
 - name: Asterisk - Run 'make install' - CAN TAKE 2 MIN OR LONGER!
   command: make install
   args:
     chdir: "{{ asterisk_src_dir }}"
-    creates: "/usr/sbin/asterisk"
+    creates: /usr/sbin/asterisk
 
 - name: Asterisk - Run 'make config'
   command: make config
@@ -105,14 +105,14 @@
     name: asterisk
     group: asterisk
     groups: audio,dialout
-    home: "/var/lib/asterisk"
+    home: /var/lib/asterisk
     system: yes
     append: yes
 
-- name: 'Asterisk - Set ownership of 5 directories: /etc/asterisk, /var/lib/asterisk, /var/log/asterisk, /var/spool/asterisk, /usr/lib/asterisk'
-  file: 
-    dest: "{{ item }}" 
-    owner: asterisk 
+- name: "Asterisk - Set ownership of 5 directories: /etc/asterisk, /var/lib/asterisk, /var/log/asterisk, /var/spool/asterisk, /usr/lib/asterisk (asterisk:asterisk)"
+  file:
+    dest: "{{ item }}"
+    owner: asterisk
     group: asterisk
     recurse: yes
   with_items: