Update main.yml

roles/samba/tasks/main.yml

@@ -1,23 +1,19 @@
----
+- name: 'Create smb user: {{ smbuser }}'
-# Create a smbuser
-#
-
-- name: Create smb user
   user:
     name: "{{ smbuser }}"
     shell: /sbin/nologin
     password: "{{ smbpassword }}"
 
-- name: Create the public folder
+- name: 'Create public folder: {{ shared_dir }}'
   file:
-    dest: "{{ shared_dir }}"
+    path: "{{ shared_dir }}"
     owner: "{{ smbuser }}"
     group: "{{ smbuser }}"
     mode: 0777
     state: directory
 
 # Install and configure samba server (requires ports 137, 138, 139, 445 open).
-- name: Install packages {samba, samba-client, samba-common, cifs-client}
+- name: Install 4 packages {samba, samba-client, samba-common, cifs-client}
   package:
     name:
       - samba
@@ -29,50 +25,50 @@
     - samba
     - download
 
-- name: Put our smb.conf in place
+- name: Install /etc/samba/smb.conf from template
   template:
     src: smb.conf.j2
     dest: /etc/samba/smb.conf
 
-- name: Ensure Samba is running and set to start on boot.
+- name: Enable & Start Samba systemd service
   service:
     name: "{{ smb_service }}"
     state: started
     enabled: yes
   tags:
     - samba
-  when : samba_enabled
+  when: samba_enabled
 
-- name: NetBIOS name server is running and set to start on boot
+- name: Enable & Start NetBIOS name server ({{ nmb_service }})
   service:
     name: "{{ nmb_service }}"
     state: started
     enabled: yes
   tags:
     - samba
-  when : samba_enabled
+  when: samba_enabled
 
-- name: Disable Samba if that is wanted
+- name: Disable Samba if not samba_enabled
   service:
     name: "{{ smb_service }}"
     state: stopped
     enabled: no
   tags:
     - samba
-  when : not samba_enabled
+  when: not samba_enabled
 
-- name: Disable Samba name server if that is wanted
+- name: Disable NetBIOS name server ({{ nmb_service }}) if not samba_enabled
   service:
     name: "{{ nmb_service }}"
     state: stopped
     enabled: no
   tags:
     - samba
-  when : not samba_enabled
+  when: not samba_enabled
 
-- name: Add 'samba' to list of services at {{ iiab_ini_file }}
+- name: Add 'samba' variable values to {{ iiab_ini_file }}
   ini_file:
-    dest: "{{ iiab_ini_file }}"
+    path: "{{ iiab_ini_file }}"
     section: samba
     option: "{{ item.option }}"
     value: "{{ item.value }}"