From 0e38eb667215d83f5a0792110464ae29917d8567 Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 18:13:55 -0500 Subject: [PATCH 01/18] 0-init/defaults/main.yml explanations tightened up --- roles/0-init/defaults/main.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/roles/0-init/defaults/main.yml b/roles/0-init/defaults/main.yml index 51218e11d..667d3518b 100644 --- a/roles/0-init/defaults/main.yml +++ b/roles/0-init/defaults/main.yml @@ -1,9 +1,9 @@ -# use these as a tag a release at a point in time +# Use these to tag a release at a point in time, for /etc/iiab/iiab.env iiab_base_ver: 6.5 iiab_revision: 0 # These entries should never be changed in this file. -# These are defaults for boolean routines, +# These are defaults for boolean routines. first_run: False rpi_model: none is_rpi: False @@ -21,10 +21,10 @@ is_F18: False rtc_id: ds3231 NUC6_firmware_needed: False -# used in 2-common xo.yml +# used in 2-common/tasks/xo.yml wifi_id: none -# used 3+ others +# used in 2-common, 3-base-server and roles/network installing: False # network From e330cebbc505a816ce5754c799c8b7d2adc37291 Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 19:41:29 -0500 Subject: [PATCH 02/18] Update README.rst --- roles/1-prep/README.rst | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/roles/1-prep/README.rst b/roles/1-prep/README.rst index 00fef1be7..e6dec28f7 100644 --- a/roles/1-prep/README.rst +++ b/roles/1-prep/README.rst @@ -1,7 +1,8 @@ -=========== -Prep README -=========== +============= +1-prep README +============= -This role is primarily hardware-focused, prior to OS additions/mods. Traditionally it included -preliminaries like hostname and things specific to a particular platform, such as the XO laptop, -done before the bulk of the install. +This 1st stage is primarily hardware-focused, prior to OS additions/mods. + +Traditionally it included preliminaries like hostname and things specific to a +particular platform, such as the XO laptop, done before the bulk of the install. From 57fb86699ea88050b7661d686610c45246454780 Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 19:41:39 -0500 Subject: [PATCH 03/18] Update README.rst --- roles/2-common/README.rst | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/roles/2-common/README.rst b/roles/2-common/README.rst index 7ca305eac..b350a35ba 100644 --- a/roles/2-common/README.rst +++ b/roles/2-common/README.rst @@ -1,6 +1,8 @@ -============= -Common README -============= +=============== +2-common README +=============== -This role aggregates roles containing packages and a few other tasks that are common to all platforms -and are required before creating a functioning server. +This 2nd stage is for low-level roles/packages/tasks *common* to all platforms, +as required to build up a functioning server. + +As in the case of 3-base-server, 4-server-options and 5-xo-services: this stage installs core server infra, that is not user-facing. From 823b7f8300074d6a1d883161d0106b7bbcbc0d6c Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 19:41:46 -0500 Subject: [PATCH 04/18] Update README.rst --- roles/3-base-server/README.rst | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/roles/3-base-server/README.rst b/roles/3-base-server/README.rst index e3f2ab091..2fd596b09 100644 --- a/roles/3-base-server/README.rst +++ b/roles/3-base-server/README.rst @@ -1,11 +1,10 @@ -================== -Base Server README -================== +==================== +3-base-server README +==================== -This role is a place to aggregate roles that are required to create a basic web server. -The functionality here is not packages that are not directly consumed by users, which are in common, -nor specific applications, such as those found in the apps and tools roles. +This 3rd stage installs base server infra required by all, such as: the web server, administrator +security (iiab-admin by default) and MySQL (the database underlying many/most user-facing apps). -The difference between this aggregate (3-base-server) and 4-server-options is that the roles here are required. +4-server-options follows with more optional/diverse server infra functionality. -Eventually a graphical configuration console will be added here. +As in the case of 2-common, 4-server-options and 5-xo-services: this stage installs core server infra, that is not user-facing. From cbf98d6ae784f0b8c89d7a974ab630b346c3c1bb Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 19:42:22 -0500 Subject: [PATCH 05/18] Update README.rst --- roles/4-server-options/README.rst | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/roles/4-server-options/README.rst b/roles/4-server-options/README.rst index 4ad68b2c9..8fd9c8a97 100644 --- a/roles/4-server-options/README.rst +++ b/roles/4-server-options/README.rst @@ -1,8 +1,9 @@ -===================== -Server Options README -===================== +======================= +4-server-options README +======================= -This role is a place to aggregate roles that may be optionally added to the basic server, -whereas the roles in base-server are required. As in the case of the base-server the -functionality here is not packages that are not directly consumed by users, which are in common, -nor specific applications, such as those found in the apps and tools roles. \ No newline at end of file +Whereas the roles/tasks in 3-base-server are required, this 4th stage includes more optional roles/tasks for core server infra. + +It includes some networking fundamentals, before they're configured later on. + +As in the case of 2-common, 3-base-server and 5-xo-services: this stage installs core server infra, that is not user-facing. From b6fb72e7f3b4cd1704a6486cde02a44a03299538 Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 19:42:32 -0500 Subject: [PATCH 06/18] Update README.rst --- roles/5-xo-services/README.rst | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/roles/5-xo-services/README.rst b/roles/5-xo-services/README.rst index b0926083c..54a2104e5 100644 --- a/roles/5-xo-services/README.rst +++ b/roles/5-xo-services/README.rst @@ -1,5 +1,7 @@ -================== -XO Services README -================== +==================== +5-xo-services README +==================== -This role is a place to aggregate roles that provide specific services for One Laptop Per Child's XO laptops. +This 5th stage provides services for One Laptop Per Child's XO laptops. + +As in the case of 2-common, 3-base-server and 4-server-options: this stage installs core server infra, that is not user-facing. From 613be3e7d995f7c0e2c10df21ecc8504e691fdcf Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 19:42:42 -0500 Subject: [PATCH 07/18] Update README.rst --- roles/6-generic-apps/README.rst | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/roles/6-generic-apps/README.rst b/roles/6-generic-apps/README.rst index 372e32d08..3843ce3c6 100644 --- a/roles/6-generic-apps/README.rst +++ b/roles/6-generic-apps/README.rst @@ -1,7 +1,9 @@ -=================== -Generic Apps README -=================== +===================== +6-generic-apps README +===================== -This role is a place to aggregate roles that install apps of a more generic or collaborative nature, -as opposed to educational or managment. Content Management Systems or Chat or Wiki applications -would go here. +This 6th stage is for apps of a more generic or collaborative nature, as opposed to educational or managerial apps in later stages. + +Chat, Wiki and CMS's (Content Management Systems) can go here. + +As in the case of 7-edu-apps, 8-mgmt-tools and 9-local-addons: this stage installs user-facing server apps. From a7f0b0c2a85fb38bbe3876aada4467197efc8771 Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 19:42:54 -0500 Subject: [PATCH 08/18] Update README.rst --- roles/7-edu-apps/README.rst | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/roles/7-edu-apps/README.rst b/roles/7-edu-apps/README.rst index edb32c1d9..74dad6564 100644 --- a/roles/7-edu-apps/README.rst +++ b/roles/7-edu-apps/README.rst @@ -1,6 +1,7 @@ -=================================== -Educational Apps and Content README -=================================== +================= +7-edu-apps README +================= -This role is a place to aggregate roles that provide Educational Content or -are specifically targetted at pedagogical activities. +This 7th stage is for Educational Apps and Learning Content, including LMS's (Learning Management Systems). + +As in the case of 6-generic-apps, 8-mgmt-tools and 9-local-addons: this stage installs user-facing server apps. From 8a188b1898d417a799855c7aa8f713b834abb8be Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 19:43:02 -0500 Subject: [PATCH 09/18] Update README.rst --- roles/8-mgmt-tools/README.rst | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/roles/8-mgmt-tools/README.rst b/roles/8-mgmt-tools/README.rst index 2207054a5..e7c631559 100644 --- a/roles/8-mgmt-tools/README.rst +++ b/roles/8-mgmt-tools/README.rst @@ -1,6 +1,7 @@ -====================================== -Assessment and Monitoring Tools README -====================================== +=================== +8-mgmt-tools README +=================== -This role is a place to aggregate roles that provide tools for Administering and -Monitoring the Server and for Assessing its use and effectiveness. +This 8th stage provides managerial tools to Administer and Monitor the server -- and for Assessing its use and effectiveness. + +As in the case of 6-generic-apps, 7-edu-apps and 9-local-addons: this stage installs user-facing server apps. From 1aca3673c3e184200374c89bd5ef6b9c77ced0d9 Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 19:43:48 -0500 Subject: [PATCH 10/18] Update README.rst --- roles/9-local-addons/README.rst | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/roles/9-local-addons/README.rst b/roles/9-local-addons/README.rst index b06e7f461..f2b19c890 100644 --- a/roles/9-local-addons/README.rst +++ b/roles/9-local-addons/README.rst @@ -1,19 +1,22 @@ -=================== -Local Addons README -=================== +===================== +9-local-addons README +===================== -This role is a place to aggregate roles developed by various contributors or locally developed. +This 9th stage is a placeholder for roles/tasks/server apps that are locally developed -- or of an experimental nature. + +As in the case of 6-generic-apps, 7-edu-apps, and 8-mgmt-tools: this stage is intended to install user-facing server apps. Development ----------- -Create the role you wish to add to Internet-in-a-Box by following the pattern of another role or any other means. +Consider creating your own Ansible role to add essential functionality to Internet-in-a-Box. You can copy any role you find within /opt/iiab/iiab/roles, and building from there! Packaging --------- -Add your role into the main.yml file in the tasks directory of the 9-local-addons role. It will now get installed as part of -the next ansible run. +Add your role into the main.yml file in the tasks directory of the 9-local-addons role. + +It will then get installed as part of the next Ansible run (e.g. "cd /opt/iiab/iiab" and then "./iiab-install --reinstall"). More Info --------- From c8a54daf5c30bf5c50cbec567b48d5a1cb33ac2d Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 19:50:40 -0500 Subject: [PATCH 11/18] indentation/syntax per new Ansible documentation --- roles/0-init/tasks/hostname.yml | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/roles/0-init/tasks/hostname.yml b/roles/0-init/tasks/hostname.yml index b929e18f1..490d00c80 100644 --- a/roles/0-init/tasks/hostname.yml +++ b/roles/0-init/tasks/hostname.yml @@ -1,22 +1,24 @@ -- name: Turn the crank for systemd +- name: Turn the crank for systemd (debuntu) shell: hostnamectl set-hostname "{{ iiab_hostname }}.{{ iiab_domain }}" when: is_debuntu -- name: Configure /etc/sysconfig/network - template: src=roles/network/templates/network/sysconfig.network.j2 - dest=/etc/sysconfig/network - owner=root - group=root - mode=0644 +- name: Configure /etc/sysconfig/network (redhat) + template: + src: roles/network/templates/network/sysconfig.network.j2 + dest: /etc/sysconfig/network + owner: root + group: root + mode: 0644 when: is_redhat - name: Configure short hostname in /etc/hosts - lineinfile: dest=/etc/hosts - regexp='^127\.0\.0\.1' - line='127.0.0.1 localhost.localdomain localhost box {{ iiab_hostname }}' - owner=root - group=root - mode=0644 + lineinfile: + dest: /etc/hosts + regexp: "^127\.0\.0\.1" + line: "127.0.0.1 localhost.localdomain localhost box {{ iiab_hostname }}" + owner: root + group: root + mode: 0644 #- name: Re-configuring httpd - not initial install # include_tasks: roles/httpd/tasks/main.yml From fa96b2e990ab70dcc1b3a368d8e3e1c2bc4701e5 Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 19:51:02 -0500 Subject: [PATCH 12/18] indentation/syntax per new Ansible documentation --- roles/0-init/tasks/fl.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/roles/0-init/tasks/fl.yml b/roles/0-init/tasks/fl.yml index 537029c48..8d0c1b01a 100644 --- a/roles/0-init/tasks/fl.yml +++ b/roles/0-init/tasks/fl.yml @@ -1,9 +1,10 @@ - name: Create various library directories - file: path={{ item }} - owner=root - group=root - mode=0755 - state=directory + file: + path: "{{ item }}" + owner: root + group: root + mode: 0755 + state: directory with_items: - /etc/iiab - "{{ yum_packages_dir }}" @@ -26,4 +27,3 @@ - "{{ doc_root }}/common/services" - /etc/sysconfig/olpc-scripts/ - /etc/sysconfig/olpc-scripts/setup.d/installed/ - From d124daa5cd8c72e223d7ade49bdc14a2ccb81017 Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 20:14:29 -0500 Subject: [PATCH 13/18] indentation/syntax per new Ansible documentation --- roles/0-init/tasks/iiab_ini.yml | 54 ++++++++++++++++----------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/roles/0-init/tasks/iiab_ini.yml b/roles/0-init/tasks/iiab_ini.yml index 88ec50dcb..9b4a13c7c 100644 --- a/roles/0-init/tasks/iiab_ini.yml +++ b/roles/0-init/tasks/iiab_ini.yml @@ -1,39 +1,39 @@ # workaround for fact that auto create does not work on ini_file - name: Create iiab config file file: - dest: '{{ iiab_config_file }}' - state: touch + dest: "{{ iiab_config_file }}" + state: touch - name: Add location section to config file ini_file: - dest: '{{ iiab_config_file }}' - section: location - option: '{{ item.option }}' - value: '{{ item.value }}' + dest: "{{ iiab_config_file }}" + section: location + option: "{{ item.option }}" + value: "{{ item.value }}" with_items: - - option: 'iiab_base' - value: '{{ iiab_base }}' - - option: 'iiab_dir' - value: '{{ iiab_dir }}' + - option: iiab_base + value: "{{ iiab_base }}" + - option: iiab_dir + value: "{{ iiab_dir }}" - name: add version section ini_file: - dest: '{{ iiab_config_file }}' + dest: "{{ iiab_config_file }}" section: version - option: '{{ item.option }}' - value: '{{ item.value }}' + option: "{{ item.option }}" + value: "{{ item.value }}" with_items: - - option: 'distribution' - value: '{{ ansible_distribution }}' - - option: 'arch' - value: '{{ ansible_architecture }}' - - option: 'iiab_base_ver' - value: '{{ iiab_base_ver }}' - - option: 'iiab_branch' - value: '{{ ansible_local.local_facts.iiab_branch }}' - - option: 'iiab_commit' - value: '{{ ansible_local.local_facts.iiab_commit }}' - - option: 'install_date' - value: '{{ ansible_date_time.iso8601 }}' - - option: 'install_xo' - value: '{{ xo_model }}' + - option: distribution + value: "{{ ansible_distribution }}" + - option: arch + value: "{{ ansible_architecture }}" + - option: iiab_base_ver + value: "{{ iiab_base_ver }}" + - option: iiab_branch + value: "{{ ansible_local.local_facts.iiab_branch }}" + - option: iiab_commit + value: "{{ ansible_local.local_facts.iiab_commit }}" + - option: install_date + value: "{{ ansible_date_time.iso8601 }}" + - option: install_xo + value: "{{ xo_model }}" From 9ba06756685b1e0233323669899b8c5eec3e1fef Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 20:16:46 -0500 Subject: [PATCH 14/18] indentation/syntax per new Ansible documentation --- roles/0-init/tasks/tz.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/roles/0-init/tasks/tz.yml b/roles/0-init/tasks/tz.yml index 5263c23d0..6dfd2e624 100644 --- a/roles/0-init/tasks/tz.yml +++ b/roles/0-init/tasks/tz.yml @@ -5,18 +5,18 @@ - name: Set local and iiab TZ to UTC if /etc/localtime is not set set_fact: - local_tz: 'UTC' - iiab_TZ: 'UTC' + local_tz: "UTC" + iiab_TZ: "UTC" when: TZ_set.stdout == "" - name: Override ansible on timezone if TZ set set_fact: - local_tz: '{{ TZ_set.stdout }}' + local_tz: "{{ TZ_set.stdout }}" when: TZ_set.stdout != "" - name: Using iiab TZ for local TZ set_fact: - local_tz: '{{ iiab_TZ }}' + local_tz: "{{ iiab_TZ }}" when: iiab_TZ is defined and iiab_TZ != "" and iiab_TZ != "TZ_set.stdout" - name: Set default Timezone from iiab TZ (debuntu) From 576dd128db94310f67f02e3dba7f593d69202f6a Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 20:18:21 -0500 Subject: [PATCH 15/18] Update README.rst --- roles/3-base-server/README.rst | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/roles/3-base-server/README.rst b/roles/3-base-server/README.rst index 2fd596b09..2e6265f21 100644 --- a/roles/3-base-server/README.rst +++ b/roles/3-base-server/README.rst @@ -2,9 +2,12 @@ 3-base-server README ==================== -This 3rd stage installs base server infra required by all, such as: the web server, administrator -security (iiab-admin by default) and MySQL (the database underlying many/most user-facing apps). +This 3rd stage installs base server infra that Internet-in-a-Box requires, including: -4-server-options follows with more optional/diverse server infra functionality. +- the web server +- administrator security (username iiab-admin by default) +- MySQL (the database underlying many/most user-facing apps) + +4-server-options follows with more diverse/optional server infra functionality. As in the case of 2-common, 4-server-options and 5-xo-services: this stage installs core server infra, that is not user-facing. From 80022624763ed1be0b5ea20d35d9dcce3feefd10 Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 20:19:59 -0500 Subject: [PATCH 16/18] Update README.rst --- roles/3-base-server/README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/3-base-server/README.rst b/roles/3-base-server/README.rst index 2e6265f21..4c8afe1c9 100644 --- a/roles/3-base-server/README.rst +++ b/roles/3-base-server/README.rst @@ -4,7 +4,7 @@ This 3rd stage installs base server infra that Internet-in-a-Box requires, including: -- the web server +- the web server (Apache for now, possibly NGINX in future) - administrator security (username iiab-admin by default) - MySQL (the database underlying many/most user-facing apps) From 4e92f19b76164a43a23287e182d039def331100e Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 20:20:32 -0500 Subject: [PATCH 17/18] Update README.rst --- roles/2-common/README.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/roles/2-common/README.rst b/roles/2-common/README.rst index b350a35ba..90bee5c7e 100644 --- a/roles/2-common/README.rst +++ b/roles/2-common/README.rst @@ -2,7 +2,7 @@ 2-common README =============== -This 2nd stage is for low-level roles/packages/tasks *common* to all platforms, -as required to build up a functioning server. +This 2nd stage is for OS-level roles/packages/tasks *common* to all platforms, +prerequisites to building up a functioning server. As in the case of 3-base-server, 4-server-options and 5-xo-services: this stage installs core server infra, that is not user-facing. From 6f747c71c83d3f57409e1e0014d58cb5c390ca6e Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 12 Feb 2018 20:25:41 -0500 Subject: [PATCH 18/18] indentation/syntax per new Ansible documentation --- roles/0-init/tasks/main.yml | 78 ++++++++++++++++++------------------- 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/roles/0-init/tasks/main.yml b/roles/0-init/tasks/main.yml index 3ecf2f829..b66db2d5a 100644 --- a/roles/0-init/tasks/main.yml +++ b/roles/0-init/tasks/main.yml @@ -93,7 +93,7 @@ gui_port: 443 when: adm_cons_force_ssl -- name: Require MySQL to be on +- name: Require MySQL to be on (mandatory in Stage 3!) set_fact: mysql_install: True mysql_enabled: True @@ -168,42 +168,42 @@ option: "{{ item.option }}" value: "{{ item.value }}" with_items: - - option: 'iiab_stage' - value: '{{ iiab_stage }}' - - option: 'iiab_base_ver' - value: '{{ iiab_base_ver }}' - - option: 'iiab_revision' - value: '{{ iiab_revision }}' - - option: 'runtime_php' - value: '{{ phplib_dir }}' - - option: 'runtime_branch' - value: '{{ ansible_local.local_facts.iiab_branch }}' - - option: 'runtime_commit' - value: '{{ ansible_local.local_facts.iiab_commit }}' - - option: 'runtime_date' - value: '{{ ansible_date_time.iso8601 }}' - - option: 'ansible_version' - value: '{{ ansible_local.local_facts.ansible_version }}' - - option: 'kernel' - value: '{{ ansible_kernel }}' - - option: 'memory_mb' - value: '{{ ansible_memtotal_mb }}' - - option: 'swap_mb' - value: '{{ ansible_swaptotal_mb }}' - - option: 'product_id' - value: '{{ ansible_product_uuid }}' - - option: 'gw_active' - value: '{{ gw_active }}' - - option: 'internet_available' - value: '{{ internet_available }}' - - option: 'is_rpi' - value: '{{ is_rpi }}' - - option: 'first_run' - value: '{{ first_run }}' - - option: 'local_tz' - value: '{{ local_tz }}' - - option: 'FQDN_changed' - value: '{{ FQDN_changed }}' + - option: iiab_stage + value: "{{ iiab_stage }}" + - option: iiab_base_ver + value: "{{ iiab_base_ver }}" + - option: iiab_revision + value: "{{ iiab_revision }}" + - option: runtime_php + value: "{{ phplib_dir }}" + - option: runtime_branch + value: "{{ ansible_local.local_facts.iiab_branch }}" + - option: runtime_commit + value: "{{ ansible_local.local_facts.iiab_commit }}" + - option: runtime_date + value: "{{ ansible_date_time.iso8601 }}" + - option: ansible_version + value: "{{ ansible_local.local_facts.ansible_version }}" + - option: kernel + value: "{{ ansible_kernel }}" + - option: memory_mb + value: "{{ ansible_memtotal_mb }}" + - option: swap_mb + value: "{{ ansible_swaptotal_mb }}" + - option: product_id + value: "{{ ansible_product_uuid }}" + - option: gw_active + value: "{{ gw_active }}" + - option: internet_available + value: "{{ internet_available }}" + - option: is_rpi + value: "{{ is_rpi }}" + - option: first_run + value: "{{ first_run }}" + - option: local_tz + value: "{{ local_tz }}" + - option: FQDN_changed + value: "{{ FQDN_changed }}" - name: Now changing FQDN include_tasks: hostname.yml @@ -216,6 +216,6 @@ option: "{{ item.option }}" value: "{{ item.value }}" with_items: - - option: 'is_VM' - value: 'yes' + - option: is_VM + value: "yes" when: is_VM is defined