Merge pull request #76 from iiab/master

sync from iiab/iiab

roles/0-init/tasks/main.yml

@@ -144,7 +144,7 @@
     mysql_service: mysqld
     no_NM_reload: True
     is_F18: True
-  when: ansible_distribution_release == "based on Fedora 18" or ansible_distribution_version == "18"
+  when: (ansible_distribution_release == "based on Fedora 18" or ansible_distribution_version == "18") and ansible_distribution == "Fedora"
 
 - name: Set mysql_service to mysql (debuntu)
   set_fact:

roles/kiwix/templates/iiab-make-kiwix-lib

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 
 {{ systemctl_program }} stop kiwix-serve
 /usr/bin/iiab-make-kiwix-lib.py

roles/moodle/tasks/main.yml

@@ -106,6 +106,7 @@
   postgresql_user:
     name: Admin
     password: changeme
+    encrypted: yes   # Required by PostgresSQL 10.3+ e.g. on Ubuntu 18.04, see https://github.com/iiab/iiab/issues/759
     role_attr_flags: NOSUPERUSER,NOCREATEROLE,NOCREATEDB
     state: present
   become: yes

roles/nextcloud/tasks/main.yml

@@ -56,9 +56,14 @@
     - "php{{ php_version }}-mysql"
     - "php{{ php_version }}-curl"
     - "php{{ php_version }}-intl"
-    - "php{{ php_version }}-mcrypt"
   when: is_debuntu
 
+- name: In php7.2, php dropped mcrypt
+  package:
+    name: "php{{ php_version }}-mcrypt"
+    state: present
+  when: is_debuntu and not is_ubuntu_18
+
 # we need to install the rpm in order to get the dependencies
 # but we only need to do this the first time
 

roles/openvpn/templates/iiab-remote-off

@@ -4,7 +4,7 @@
 # do nothing if it is not installed
 which openvpn
 if [ $? -ne 0 ]; then
-   echo Cannot find the openvpn program.
+    echo Cannot find the OpenVPN program (openvpn).
     exit 1
 fi
 systemctl disable openvpn@xscenet.service
@@ -13,7 +13,7 @@ systemctl stop openvpn@xscenet.service
 sleep 5
 ps -e|grep vpn
 if [ $? -eq 0 ]; then
-  echo Openvpn failed to stop.
+    echo OpenVPN failed to stop.
 else
-  echo Successfully stopped and disabled Openvpn
+    echo Successfully stopped and disabled OpenVPN.
 fi

roles/openvpn/templates/iiab-remote-on

@@ -4,7 +4,7 @@
 # do nothing if it is not installed
 which openvpn
 if [ $? -ne 0 ]; then
-   echo Cannot find the openvpn program.
+    echo Cannot find the OpenVPN program (openvpn).
     exit 1
 fi
 systemctl enable openvpn@xscenet.service
@@ -13,7 +13,7 @@ systemctl start openvpn@xscenet.service
 sleep 5
 ping -c 2 10.8.0.1
 if [ $? -eq 0 ]; then
-  echo Openvpn successfully started.
+    echo OpenVPN successfully started.
 else
-  echo Openvpn failed to contact remote server.
+    echo OpenVPN failed to contact remote server.
 fi

roles/openvpn/templates/iiab-vpn

@@ -1,5 +1,6 @@
-#!/bin/sh
+#!/bin/bash
 # script to manage openvpn
+
 if [ ! -f "/etc/openvpn/iiab-vpn.conf" ]; then
     VPNCONFIG='party-line.conf'
     VPNIP={{ openvpn_server_virtual_ip }}
@@ -15,25 +16,24 @@ if [ "$(id -u)" != "0" ]; then
 fi
 
 case $1 in
-"stop" | "no" | "off")
+    "stop" | "no" | "off")
         killall openvpn
         exit 0
         ;;
-"status")
+    "status")
         pid=`ps -e|grep openvpn`
         if [ -z "$pid" ]; then
-        echo "The openvpn process is not running"
+            echo "The OpenVPN process is not running"
         else
-        echo "Openvpn is running with id $pid"
+            echo "OpenVPN is running with id $pid"
             ip=`ifconfig tun | gawk '(/netmask /) {print( $2);}'`
             echo "Local vpn tunnel address is $ip"
         fi
         exit 0
         ;;
-    
 esac
 
-# we'd like for passwords authentication to be turned off
+# we'd like for password authentication to be turned off
 grep -e^PasswordAuthentication.*[Yy]es /etc/ssh/sshd_config
 PASSWORDS_ENABLED=$?
 
@@ -41,8 +41,7 @@ if [ $PASSWORDS_ENABLED -eq 0 ];then
     case $1 in
         "test" | "unsafe") ;;
         *)
-
+            echo "OpenVPN is only safe when public/private keys are used"
-		echo "Openvpn is only safe when public/private keys are used"
             echo " And when passwords are turned off in /etc/ssh/sshd_conf"
             exit 1
     esac
@@ -58,8 +57,8 @@ else
 fi
 
 case $cmd in
-"test" | "unsafe" )
+    "test" | "unsafe" )
-# load TUN/TAP kernel module
+        # load TUN/TAP kernel module
         modprobe tun
 
         # make sure the wan is functioning
@@ -77,7 +76,7 @@ case $cmd in
             echo "Stopping any openvpn instance"
             killall openvpn
             sleep 10
-		echo "Starting openvpn and waiting 10 seconds for daemon to become ready"
+            echo "Starting OpenVPN and waiting 10 seconds for daemon to become ready"
             openvpn --cd $dir --daemon --config $VPNCONFIG
         fi
         sleep 10

roles/sugarizer/tasks/main.yml

@@ -21,7 +21,7 @@
 
 - name: Set up Node.js 6.x apt sources (debuntu)
   shell: curl -sL https://deb.nodesource.com/setup_6.x | bash -
-  when: internet_available and is_debuntu
+  when: internet_available and is_debuntu and not ubuntu-18
 
 - name: Install latest Node.js which includes /usr/bin/npm (debuntu)
   package:
@@ -29,7 +29,7 @@
     state: latest
 # package: name=nodejs=6.*
 #          state=present
-  when: internet_available and is_debuntu
+  when: internet_available and is_debuntu and not ubuntu-18
 
 - name: Install npm (OS's other than debuntu)
   package:
@@ -40,6 +40,15 @@
     - nodejs
     - npm
 
+- name: Install npm (ubuntu-18)
+  package:
+    name: "{{ item }}"
+    state: latest
+  when: internet_available and is_ubuntu_18
+  with_items:
+    - npm
+    - nodejs
+
 # attempting to reinstall npm is broken on Raspbian 9
 - name: Check for Sugarizer already installed
   stat:

vars/ubuntu-18.yml

@@ -18,5 +18,6 @@ mysql_service: mysql
 apache_log: /var/log/apache2/access.log
 sshd_service: ssh
 php_version: 7.2
-postgresql_version: 10.3
+# "postgresql_version: 10.3" fails (too detailed for /etc/systemd/system/postgresql-iiab.service on Ubuntu 18.04)
+postgresql_version: 10
 systemd_location: /lib/systemd/system