external/iiab
1
0
Fork 0
mirror of https://github.com/iiab/iiab.git synced 2025-03-09 15:40:17 +00:00
Code Issues Releases Wiki Activity

validate_vars.yml: ansible-core 2.16.1 req 'loop' not 'with_items' w/ 'assert' templating

Browse source
This commit is contained in:
root 2023-12-04 18:01:55 -05:00
parent af9597d5b2
commit 9f00b7b41b
1 changed files with 30 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

42
roles/0-init/tasks/validate_vars.yml
View file

@ -158,20 +158,38 @@
when: item != 'mysql' and item != 'postgresql' and item != 'mongodb' and item != 'nodejs' and item != 'yarn' # Exclude auto-installed dependencies when: item != 'mysql' and item != 'postgresql' and item != 'mongodb' and item != 'nodejs' and item != 'yarn' # Exclude auto-installed dependencies
loop: "{{ vars_checklist }}" loop: "{{ vars_checklist }}"
- name: Set vars_deprecated_list for 4+ vars ("XYZ_install") to be checked
set_fact:
vars_deprecated_list:
- dhcpd # Deprecated
- named # Deprecated
- wondershaper # Deprecated
- dansguardian # Deprecated
#- xo_services # Unmaintained
#- activity_server # Unmaintained
#- ejabberd_xs # Unmaintained
#- idmgr # Unmaintained
#- dokuwiki # Unmaintained
#- ejabberd # Unmaintained
#- elgg # Unmaintained
- name: 'DISALLOW "XYZ_install: True" if deprecated' - name: 'DISALLOW "XYZ_install: True" if deprecated'
assert: assert:
that: "{{ item }}_install is undefined or not {{ item }}_install" that: "{{ item }}_install is undefined or not {{ item }}_install"
fail_msg: "DISALLOWED: '{{ item }}_install: True' (e.g. in /etc/iiab/local_vars.yml)" fail_msg: "DISALLOWED: '{{ item }}_install: True' (e.g. in /etc/iiab/local_vars.yml)"
quiet: yes quiet: yes
with_items: loop: "{{ vars_deprecated_list }}"
- dhcpd # Deprecated # 2023-12-04: ansible-core 2.16.1 suddenly no longer allows 'assert' with
- named # Deprecated # 'with_items' below (whereas 'loop' construct above works!) BACKGROUND:
- wondershaper # Deprecated #
- dansguardian # Deprecated # 'due to mitigation of security issue CVE-2023-5764 in ansible-core 2.16.1,
#- xo_services # Unmaintained # conditional expressions with embedded template blocks can fail with the
#- activity_server # Unmaintained # message “Conditional is marked as unsafe, and cannot be evaluated.”'
#- ejabberd_xs # Unmaintained # https://docs.ansible.com/ansible-core/2.16/porting_guides/porting_guide_core_2.16.html#playbook
#- idmgr # Unmaintained #
#- dokuwiki # Unmaintained # with_items:
#- ejabberd # Unmaintained # - dhcpd # Deprecated
#- elgg # Unmaintained # - named # Deprecated
# - wondershaper # Deprecated
# - dansguardian # Deprecated