From 26a9120f9caa6ac1bd44101118f5594aff496bdd Mon Sep 17 00:00:00 2001 From: Arky Date: Tue, 9 Oct 2018 22:38:16 +0700 Subject: [PATCH 1/3] Check if transmission_kalite_languages is defined Checks if any languages are defined in transmission_kalite_languages. Proposed fix for bug #1193. https://github.com/iiab/iiab/issues/1193 --- roles/transmission/tasks/main.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/roles/transmission/tasks/main.yml b/roles/transmission/tasks/main.yml index 6eca4c49c..8753964a0 100644 --- a/roles/transmission/tasks/main.yml +++ b/roles/transmission/tasks/main.yml @@ -18,7 +18,7 @@ systemd: name: transmission-daemon state: stopped - ignore_errors: yes + ignore_errors: yes - name: Create transmission-daemon settings template: @@ -42,9 +42,8 @@ --start-paused -n {{ transmission_username }}:{{ transmission_password }} -a http://pantry.learningequality.org/downloads/ka-lite/{{ transmission_kalite_version }}/content/ka-lite-0.17-resized-videos-{{ item }}.torrent - with_items: "{{ transmission_kalite_languages }}" + with_items: "{{ transmission_kalite_languages | default('english') }}" ignore_errors: yes - when: transmission_provision - name: Disable transmission-daemon service systemd: From 59f3b88cfc717871dd7eed97f8ca80318a2d4453 Mon Sep 17 00:00:00 2001 From: Arky Date: Sat, 13 Oct 2018 21:40:50 +0700 Subject: [PATCH 2/3] Using 'is defined' over default filters --- roles/transmission/tasks/main.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/roles/transmission/tasks/main.yml b/roles/transmission/tasks/main.yml index 8753964a0..eac8b12cf 100644 --- a/roles/transmission/tasks/main.yml +++ b/roles/transmission/tasks/main.yml @@ -42,7 +42,8 @@ --start-paused -n {{ transmission_username }}:{{ transmission_password }} -a http://pantry.learningequality.org/downloads/ka-lite/{{ transmission_kalite_version }}/content/ka-lite-0.17-resized-videos-{{ item }}.torrent - with_items: "{{ transmission_kalite_languages | default('english') }}" + with_items: "{{ transmission_kalite_languages }}" + when: transmission_kalite_languages is defined and transmission_provision ignore_errors: yes - name: Disable transmission-daemon service From ae8b9d93eda8aa453ae6ff4247a7605d2ad03646 Mon Sep 17 00:00:00 2001 From: A Holt Date: Sat, 13 Oct 2018 15:46:44 -0400 Subject: [PATCH 3/3] Update main.yml --- roles/transmission/tasks/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/transmission/tasks/main.yml b/roles/transmission/tasks/main.yml index eac8b12cf..0ee97e234 100644 --- a/roles/transmission/tasks/main.yml +++ b/roles/transmission/tasks/main.yml @@ -43,7 +43,7 @@ -n {{ transmission_username }}:{{ transmission_password }} -a http://pantry.learningequality.org/downloads/ka-lite/{{ transmission_kalite_version }}/content/ka-lite-0.17-resized-videos-{{ item }}.torrent with_items: "{{ transmission_kalite_languages }}" - when: transmission_kalite_languages is defined and transmission_provision + when: transmission_enabled and transmission_provision and transmission_kalite_languages is defined ignore_errors: yes - name: Disable transmission-daemon service