From b596360b8d2068729597dcd0b22e469e3b81cf8d Mon Sep 17 00:00:00 2001
From: A Holt <holta@users.noreply.github.com>
Date: Tue, 21 Jan 2020 19:43:20 -0500
Subject: [PATCH] Cleaner 0-init/tasks/validate_vars.yml

---
 roles/0-init/tasks/validate_vars.yml | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/roles/0-init/tasks/validate_vars.yml b/roles/0-init/tasks/validate_vars.yml
index c914a5a90..d17c63adb 100644
--- a/roles/0-init/tasks/validate_vars.yml
+++ b/roles/0-init/tasks/validate_vars.yml
@@ -32,7 +32,8 @@
 # I want to perform input validation for Ansible playbooks"
 # https://stackoverflow.com/questions/46664127/how-do-i-fail-a-task-in-ansible-if-the-variable-contains-a-boolean-value-i-want/46667499#46667499
 
-- name: Set vars_checklist for 46 + 46 vars ("XYZ_install" + "XYZ_enabled") to be checked
+# 2020-01-21: checks 46+46 vars...for now!
+- name: Set vars_checklist for ~46 + ~46 vars ("XYZ_install" + "XYZ_enabled") to be checked
   set_fact:
     vars_checklist:
       - hostapd
@@ -82,35 +83,35 @@
       - calibre
       - calibreweb
 
-- name: Assert that 46 "XYZ_install" vars are defined
+- name: Assert that {{ vars_checklist | length }} "XYZ_install" vars are all... defined
   assert:
     that: "{{ item }}_install is defined"
     quiet: yes
   loop: "{{ vars_checklist }}"
   #register: install_vars_defined
 
-- name: Assert that 46 "XYZ_enabled" vars are defined
+- name: Assert that {{ vars_checklist | length }} "XYZ_enabled" vars are all... defined
   assert:
     that: "{{ item }}_enabled is defined"
     quiet: yes
   loop: "{{ vars_checklist }}"
   #register: enabled_vars_defined
 
-- name: Assert that 46 "XYZ_install" vars are type boolean (not type string, which can invert logic!)
+- name: Assert that {{ vars_checklist | length }} "XYZ_install" vars are all... type boolean (not type string, which can invert logic!)
   assert:
     that: "{{ item }}_install | type_debug == 'bool'"
     quiet: yes
   loop: "{{ vars_checklist }}"
   #register: install_vars_boolean
 
-- name: Assert that 46 "XYZ_enabled" vars are type boolean (not type string, which can invert logic!)
+- name: Assert that {{ vars_checklist | length }} "XYZ_enabled" vars are all... type boolean (not type string, which can invert logic!)
   assert:
     that: "{{ item }}_enabled | type_debug == 'bool'"
     quiet: yes
   loop: "{{ vars_checklist }}"
   #register: enabled_vars_boolean
 
-- name: 'DISALLOW "XYZ_install: False" WITH "XYZ_enabled: True" for 46 var pairs'
+- name: 'DISALLOW "XYZ_install: False" WITH "XYZ_enabled: True" ...for all {{ vars_checklist | length }} var pairs'
   assert:
     that: "{{ item }}_install or not {{ item }}_enabled"
     #fail_msg: '{{ item }}_install or not {{ item }}_enabled    {{ item }}_install is {{ {{ item }}_install }}    {{ item }}_enabled is {{ {{ item }}_enabled }}'   # Is there a way to output var values ?