From 3a91d7f2ecf1a30543bb4d2c36450153f1dc382e Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 26 Apr 2021 14:38:03 -0400 Subject: [PATCH 1/3] 2-common/tasks/packages.yml: lint & explain --- roles/2-common/tasks/packages.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/roles/2-common/tasks/packages.yml b/roles/2-common/tasks/packages.yml index 83f3db415..2224816e1 100644 --- a/roles/2-common/tasks/packages.yml +++ b/roles/2-common/tasks/packages.yml @@ -17,12 +17,12 @@ - name: "Install 6 deb/apt packages: avahi-daemon, exfat-fuse, exfat-utils, inetutils-syslogd, libnss-mdns, wpasupplicant (debuntu)" package: name: -# - avahi-discover + #- avahi-discover - avahi-daemon - - exfat-fuse # Should no longer be nec with 5.4+ kernels. - - exfat-utils # Likewise. - - inetutils-syslogd - - libnss-mdns + - exfat-fuse # Should no longer be nec with 5.4+ kernels + - exfat-utils # Likewise + - inetutils-syslogd # Error logging facility + - libnss-mdns # Provides name resolution via mDNS (Multicast DNS) using Zeroconf/Bonjour e.g. Avahi - wpasupplicant state: present when: is_debuntu @@ -30,15 +30,15 @@ - name: "Install 22 common packages: acpid, bridge-utils, bzip2, curl, gawk, hostapd, htop, i2c-tools, logrotate, make, mlocate, netmask, net-tools, ntfs-3g, pandoc, pastebinit, rsync, sqlite3, tar, unzip, usbutils, wget" package: name: - - acpid - - bridge-utils + - acpid # Daemon for ACPI (power mgmt) events + - bridge-utils # DEPRECATED according to https://wiki.linuxfoundation.org/networking/bridge - bzip2 - curl #- etckeeper # "nobody is really using etckeeper and it's bloating the filesystem every time apt runs" per @jvonau at https://github.com/iiab/iiab/issues/1146 - gawk - hostapd - htop - - i2c-tools + - i2c-tools # Low-level bus/chip/register/EEPROM tools e.g. for RTC - logrotate #- lynx # Installed by 1-prep's roles/iiab-admin/tasks/access.yml - make @@ -56,6 +56,6 @@ - tar - unzip #- usbmount # Moved to roles/usb_lib/tasks/install.yml - - usbutils + - usbutils # Should this also move to roles/usb_lib/tasks/install.yml ? - wget state: present From 317f091fc86553e42774ddd0dc0a80cfcabe1d2e Mon Sep 17 00:00:00 2001 From: A Holt Date: Mon, 26 Apr 2021 22:35:32 -0400 Subject: [PATCH 2/3] 2-common/tasks/packages.yml: which apt packages are truly need? --- roles/2-common/tasks/packages.yml | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/roles/2-common/tasks/packages.yml b/roles/2-common/tasks/packages.yml index 2224816e1..dfa30b1ac 100644 --- a/roles/2-common/tasks/packages.yml +++ b/roles/2-common/tasks/packages.yml @@ -30,32 +30,32 @@ - name: "Install 22 common packages: acpid, bridge-utils, bzip2, curl, gawk, hostapd, htop, i2c-tools, logrotate, make, mlocate, netmask, net-tools, ntfs-3g, pandoc, pastebinit, rsync, sqlite3, tar, unzip, usbutils, wget" package: name: - - acpid # Daemon for ACPI (power mgmt) events + - acpid # Daemon for ACPI (power mgmt) events - bridge-utils # DEPRECATED according to https://wiki.linuxfoundation.org/networking/bridge - - bzip2 - - curl + - bzip2 # 2021-04-26: Prob not used, but can't hurt? + - curl # Used to install roles/nodejs and roles/nodered #- etckeeper # "nobody is really using etckeeper and it's bloating the filesystem every time apt runs" per @jvonau at https://github.com/iiab/iiab/issues/1146 - gawk - hostapd - htop - - i2c-tools # Low-level bus/chip/register/EEPROM tools e.g. for RTC + - i2c-tools # Low-level bus/chip/register/EEPROM tools e.g. for RTC - logrotate - #- lynx # Installed by 1-prep's roles/iiab-admin/tasks/access.yml - - make + #- lynx # Installed by 1-prep's roles/iiab-admin/tasks/access.yml + - make # 2021-04-26: What roles (if any) truly still use this? - mlocate - netmask - - net-tools - - ntfs-3g + - net-tools # 2021-04-26: @jvonau suggests possibly deleting this...unless oldtimers really want these older commands in iiab-diagnostics output? + - ntfs-3g # Possibly no longer nec, similar to exfat packages above? #- openssh-server # ssh (Raspbian) or openssh-server (other OS's) already installed by 1-prep's roles/sshd/tasks/main.yml - - pandoc - - pastebinit + - pandoc # For /usr/bin/iiab-refresh-wiki-docs + - pastebinit # For /usr/bin/iiab-diagnostics - rsync - #- screen # Installed by 1-prep's roles/iiab-admin/tasks/access.yml + #- screen # Installed by 1-prep's roles/iiab-admin/tasks/access.yml - sqlite3 - #- sudo # Installed by 1-prep's roles/iiab-admin/tasks/sudo-prereqs.yml + #- sudo # Installed by 1-prep's roles/iiab-admin/tasks/sudo-prereqs.yml - tar - unzip - #- usbmount # Moved to roles/usb_lib/tasks/install.yml - - usbutils # Should this also move to roles/usb_lib/tasks/install.yml ? + #- usbmount # Moved to roles/usb_lib/tasks/install.yml + - usbutils # 2021-04-26: Also move to roles/usb_lib/tasks/install.yml ? - wget state: present From a5155f6164979926e61b110fb1a11dc6ce4d7dbb Mon Sep 17 00:00:00 2001 From: A Holt Date: Tue, 27 Apr 2021 12:13:18 -0400 Subject: [PATCH 3/3] Update 2-common/tasks/packages.yml --- roles/2-common/tasks/packages.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/roles/2-common/tasks/packages.yml b/roles/2-common/tasks/packages.yml index dfa30b1ac..4d38c665a 100644 --- a/roles/2-common/tasks/packages.yml +++ b/roles/2-common/tasks/packages.yml @@ -20,7 +20,7 @@ #- avahi-discover - avahi-daemon - exfat-fuse # Should no longer be nec with 5.4+ kernels - - exfat-utils # Likewise + - exfat-utils # Likewise! - inetutils-syslogd # Error logging facility - libnss-mdns # Provides name resolution via mDNS (Multicast DNS) using Zeroconf/Bonjour e.g. Avahi - wpasupplicant @@ -31,7 +31,7 @@ package: name: - acpid # Daemon for ACPI (power mgmt) events - - bridge-utils # DEPRECATED according to https://wiki.linuxfoundation.org/networking/bridge + - bridge-utils # DEPRECATED according to https://wiki.linuxfoundation.org/networking/bridge SEE PR #2752 - bzip2 # 2021-04-26: Prob not used, but can't hurt? - curl # Used to install roles/nodejs and roles/nodered #- etckeeper # "nobody is really using etckeeper and it's bloating the filesystem every time apt runs" per @jvonau at https://github.com/iiab/iiab/issues/1146