From d35fba01d80bb48308364739239574eca8e398a6 Mon Sep 17 00:00:00 2001 From: A Holt Date: Tue, 3 Nov 2020 12:00:20 -0500 Subject: [PATCH] sugarizer/tasks/install.yml: 27018 -> 27017, explain better, lint Ansible regex's (single quote habit, for safety) --- roles/sugarizer/tasks/install.yml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/roles/sugarizer/tasks/install.yml b/roles/sugarizer/tasks/install.yml index f478457ff..5ca212dd2 100644 --- a/roles/sugarizer/tasks/install.yml +++ b/roles/sugarizer/tasks/install.yml @@ -176,7 +176,7 @@ - name: Set Sugarizer port to {{ sugarizer_port }} in /opt/iiab/sugarizer-server/env/sugarizer.ini lineinfile: path: "{{ iiab_base }}/sugarizer-server/env/sugarizer.ini" - regexp: "^port = 8080$" + regexp: '^port = 8080$' line: "port = {{ sugarizer_port }}" # 2019-02-02 No Longer Required thanks to @llaske's upstream fix: @@ -193,15 +193,19 @@ #- name: Set MongoDB "server" from localhost to 127.0.0.1 in /opt/iiab/sugarizer-server/env/sugarizer.ini # lineinfile: # path: "{{ iiab_base }}/sugarizer-server/env/sugarizer.ini" -# regexp: "^server = localhost$" +# regexp: '^server = localhost$' # line: "server = 127.0.0.1" -# mongodb_port is set to 27018 in /opt/iiab/iiab/vars/default_vars.yml -# If you need to change this, edit /etc/iiab/local_vars.yml prior to installing +# mongodb_port is set to 27017 in /opt/iiab/iiab/vars/default_vars.yml +# If you must change this, edit /etc/iiab/local_vars.yml prior to installing +# See also upstream recommendations: +# https://github.com/llaske/sugarizer-server/blob/master/env/sugarizer.ini line ~22 under [database] +# https://docs.mongodb.com/manual/reference/default-mongodb-port/ +# https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.txt - name: Set MongoDB port to {{ mongodb_port }} in /opt/iiab/sugarizer-server/env/sugarizer.ini lineinfile: path: "{{ iiab_base }}/sugarizer-server/env/sugarizer.ini" - regexp: "^port = 27017$" + regexp: '^port = 27017$' # Careful as file also contains 2 other ports! line: "port = {{ mongodb_port }}" # 2-LINE FIX FOR sugarizer.js BY @georgejhunt FOR http://box/sugarizer @@ -211,7 +215,7 @@ - name: For http://box/sugarizer -- add pathPrefix lines in /opt/iiab/sugarizer-server/sugarizer.js lineinfile: path: "{{ iiab_base }}/sugarizer-server/sugarizer.js" - regexp: "AUTO-INSERTED BY IIAB" # avoids inserting it twice! + regexp: 'AUTO-INSERTED BY IIAB' # avoids inserting it twice! insertbefore: "// Start listening$" line: | # SEE https://yaml-multiline.info (use |+ to 'keep' newlines at end...though |8 and |+4 "indentation indicators" don't work with Ansible) // AUTO-INSERTED BY IIAB FOR http://box/sugarizer