Update main.yml

roles/samba/tasks/main.yml

@@ -2,16 +2,25 @@
 # Create a smbuser
 #
 
-- name: create smb user
+- name: Create smb user
-  user: name="{{ smbuser }}" shell=/sbin/nologin password="{{ smbpassword }}"
+  user:
+    name: "{{ smbuser }}"
+    shell: /sbin/nologin
+    password: "{{ smbpassword }}"
 
-- name: create the public folder
+- name: Create the public folder
-  file: dest="{{ shared_dir }}" owner="{{ smbuser }}" group="{{ smbuser }}" mode=0777 state=directory
+  file:
+    dest: "{{ shared_dir }}"
+    owner: "{{ smbuser }}"
+    group: "{{ smbuser }}"
+    mode: 0777
+    state: directory
 
 # Install and configure samba server (requires ports 137, 138, 139, 445 open).
-- name: Ensure Samba-related packages are installed.
+- name: Ensure Samba-related packages are installed
-  package: name={{ item }}
+  package:
-           state=present
+    name: "{{ item }}"
+    state: present
   with_items:
   - samba
   - samba-client
@@ -21,41 +30,56 @@
     - samba
     - download
 
-- name: put our smb.conf in place
+- name: Put our smb.conf in place
-  template: src=smb.conf.j2 dest=/etc/samba/smb.conf
+  template:
+    src: smb.conf.j2
+    dest: /etc/samba/smb.conf
 
 - name: Ensure Samba is running and set to start on boot.
-  service: name={{ smb_service }} state=started enabled=yes
+  service:
+    name: "{{ smb_service }}"
+    state: started
+    enabled: yes
   tags:
     - samba
   when : samba_enabled
 
-- name: netbios name server is running and set to start on boot.
+- name: NetBIOS name server is running and set to start on boot
-  service: name={{ nmb_service }} state=started enabled=yes
+  service:
+    name: "{{ nmb_service }}"
+    state: started
+    enabled: yes
   tags:
     - samba
   when : samba_enabled
 
 - name: Disable Samba if that is wanted
-  service: name={{ smb_service }} state=stopped enabled=no
+  service:
+    name: "{{ smb_service }}"
+    state: stopped
+    enabled: no
   tags:
     - samba
   when : not samba_enabled
 
 - name: Disable Samba name server if that is wanted
-  service: name={{ nmb_service }} state=stopped enabled=no
+  service:
+    name: "{{ nmb_service }}"
+    state: stopped
+    enabled: no
   tags:
     - samba
   when : not samba_enabled
 
-- name: Add samba to service list
+- name: Add 'samba' to list of services at /etc/iiab/iiab.ini
-  ini_file: dest='{{ service_filelist }}'
+  ini_file:
-            section=samba
+    dest: "{{ service_filelist }}"
-            option='{{ item.option }}'
+    section: samba
-            value='{{ item.value }}'
+    option: "{{ item.option }}"
+    value: "{{ item.value }}"
   with_items:
     - option: name
-      value: samba
+      value: Samba
     - option: description
       value: '"Samba is a Microsoft-compatible network file system that re-implements SMB/CIFS (Common Internet File System)."'
     - option: enabled