From ef48d49b884f3e1d9577a772659bb83f49b7d266 Mon Sep 17 00:00:00 2001
From: A Holt <holta@users.noreply.github.com>
Date: Fri, 8 Dec 2017 01:33:31 -0500
Subject: [PATCH] Update install.yml

---
 roles/kalite/tasks/install.yml | 47 +++++++++++++++++++---------------
 1 file changed, 27 insertions(+), 20 deletions(-)

diff --git a/roles/kalite/tasks/install.yml b/roles/kalite/tasks/install.yml
index fa09461dc..1d0d0923f 100644
--- a/roles/kalite/tasks/install.yml
+++ b/roles/kalite/tasks/install.yml
@@ -1,13 +1,17 @@
 # This is for an OS other than Fedora 18
 
 - name: Install missing packages required for KA Lite startup
-  package: name={{ item }}
-           state=present
+  package:
+    name: "{{ item }}"
+    state: present
   with_items:
     - python-virtualenv
 
 - name: Grab the requirements file
-  get_url: url={{ kalite_requirements }} dest={{ pip_packages_dir }}/kalite.txt
+  get_url:
+    url: "{{ kalite_requirements }}"
+    dest: "{{ pip_packages_dir }}/kalite.txt"
+    timeout: "{{ download_timeout }}"
   when: internet_available
 
 #- name: Install KA Lite non-static + reqs file with pip - (debuntu)
@@ -19,11 +23,12 @@
 #  when: internet_available and is_debuntu
 
 - name: Install KA Lite static with pip - (debuntu)
-  pip: name=ka-lite-static
-       version={{ kalite_version }}
-       virtualenv={{ kalite_venv }}
-       virtualenv_site_packages=no
-       extra_args="--no-cache-dir"
+  pip:
+    name: ka-lite-static
+    version: "{{ kalite_version }}"
+    virtualenv: "{{ kalite_venv }}"
+    virtualenv_site_packages: no
+    extra_args: "--no-cache-dir"
 #       extra_args="--disable-pip-version-check"
   when: internet_available and is_debuntu
 
@@ -36,30 +41,32 @@
 #  when: internet_available and not is_debuntu
 
 - name: Install KA Lite static with pip - (OS's other than debuntu)
-  pip: name=ka-lite-static
-       version={{ kalite_version }}
-       virtualenv={{ kalite_venv }}
-       virtualenv_site_packages=no
+  pip:
+    name: ka-lite-static
+    version: "{{ kalite_version }}"
+    virtualenv: "{{ kalite_venv }}"
+    virtualenv_site_packages: no
 #       extra_args="--no-cache-dir"
 #       extra_args="--disable-pip-version-check"
   when: internet_available and not is_debuntu
 
 - name: Default is to have cronserve started with KA Lite
   set_fact:
-     job_scheduler_stanza: ""
+    job_scheduler_stanza: ""
 
 - name: Add --skip-job-scheduler to start if cronserve not enabled
   set_fact:
-     job_scheduler_stanza: "--skip-job-scheduler "
+    job_scheduler_stanza: "--skip-job-scheduler "
   when: not kalite_cron_enabled
 
 - name: Create 'kalite-serve' service, kalite.sh and kalite.conf
-  template: backup=no
-            src={{ item.src }}
-            dest={{ item.dest }}
-            owner=root
-            group=root
-            mode={{ item.mode }}
+  template:
+    backup: no
+    src: "{{ item.src }}"
+    dest: "{{ item.dest }}"
+    owner: root
+    group: root
+    mode: "{{ item.mode }}"
   with_items:
     - { src: 'kalite-serve.service.j2', dest: '/etc/systemd/system/kalite-serve.service', mode: '0644'}
     - { src: 'kalite.sh.j2', dest: '/usr/bin/kalite', mode: '0755'}