From 024ea8c7334eb0966708acc331d9283235f11a3f Mon Sep 17 00:00:00 2001 From: David Herrmann Date: Mon, 17 Feb 2014 12:18:55 +0100 Subject: [PATCH] dhcp: fix buffer-overflow for addresses Fix trivial buffer-overflow which caused configuration overwrites. Signed-off-by: David Herrmann --- src/miracle-dhcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/miracle-dhcp.c b/src/miracle-dhcp.c index a0a8180..3b3206e 100644 --- a/src/miracle-dhcp.c +++ b/src/miracle-dhcp.c @@ -709,7 +709,7 @@ static int make_address(char *buf, const char *prefix, const char *suffix, goto error; inet_ntop(AF_INET, &addr, buf, INET_ADDRSTRLEN); - buf[INET_ADDRSTRLEN] = 0; + buf[INET_ADDRSTRLEN - 1] = 0; return 0; error: @@ -728,7 +728,7 @@ static int make_subnet(char *buf, const char *subnet) goto error; inet_ntop(AF_INET, &addr, buf, INET_ADDRSTRLEN); - buf[INET_ADDRSTRLEN] = 0; + buf[INET_ADDRSTRLEN - 1] = 0; return 0; error: